All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gaetan Rivet <gaetan.rivet@6wind.com>
To: dev@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>, stable@dpdk.org
Subject: [PATCH v3 10/10] net/ring: fix dev handle in eth_dev
Date: Thu,  8 Jun 2017 01:53:24 +0200	[thread overview]
Message-ID: <2864d0bb005bab72dcddafa692a79e13826cbec8.1496876710.git.gaetan.rivet@6wind.com> (raw)
In-Reply-To: <cover.1496876710.git.gaetan.rivet@6wind.com>
In-Reply-To: <cover.1496876710.git.gaetan.rivet@6wind.com>

The ring PMD uses special eth_dev allocators, which cannot be updated to
accept an rte_vdev_device.
Circumvent the limitation and store the rte_device handle in the
rte_eth_dev structure.

Fixes: 050fe6e9ff97 ("drivers/net: use ethdev allocation helper for
vdev")
Cc: stable@dpdk.org

Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
---
 drivers/net/ring/rte_eth_ring.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index d4dce95..2cd32a9 100644
--- a/drivers/net/ring/rte_eth_ring.c
+++ b/drivers/net/ring/rte_eth_ring.c
@@ -515,6 +515,8 @@ rte_pmd_ring_probe(struct rte_vdev_device *dev)
 	RTE_LOG(INFO, PMD, "Initializing pmd_ring for %s\n", name);
 
 	if (params == NULL || params[0] == '\0') {
+		struct rte_eth_dev *eth_dev;
+
 		ret = eth_dev_ring_create(name, rte_socket_id(), DEV_CREATE);
 		if (ret == -1) {
 			RTE_LOG(INFO, PMD,
@@ -522,6 +524,11 @@ rte_pmd_ring_probe(struct rte_vdev_device *dev)
 			ret = eth_dev_ring_create(name, rte_socket_id(),
 						  DEV_ATTACH);
 		}
+		/* find an ethdev entry */
+		eth_dev = rte_eth_dev_allocated(name);
+		if (eth_dev == NULL)
+			return -ENODEV;
+		eth_dev->device = &dev->device;
 	}
 	else {
 		kvlist = rte_kvargs_parse(params, valid_arguments);
-- 
2.1.4

  parent reply	other threads:[~2017-06-07 23:53 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-24 15:04 [PATCH 0/9] bus: attach / detach API Gaetan Rivet
2017-05-24 15:04 ` [PATCH 1/9] bus: add bus iterator to find a particular bus Gaetan Rivet
2017-05-24 15:04 ` [PATCH 2/9] bus: add device iterator Gaetan Rivet
2017-05-24 15:04 ` [PATCH 3/9] bus: add helper to find bus for a particular device Gaetan Rivet
2017-05-24 15:04 ` [PATCH 4/9] bus: add bus helper iterator to find " Gaetan Rivet
2017-05-24 15:04 ` [PATCH 5/9] bus: introduce attach/detach functionality Gaetan Rivet
2017-05-24 15:04 ` [PATCH 6/9] vdev: implement find_device bus operation Gaetan Rivet
2017-05-24 15:04 ` [PATCH 7/9] vdev: implement detach " Gaetan Rivet
2017-05-24 15:05 ` [PATCH 8/9] eal: make virtual driver probe and remove take rte_vdev_device Gaetan Rivet
2017-05-24 15:05 ` [PATCH 9/9] ethdev: Use embedded rte_device to detach driver Gaetan Rivet
2017-05-31 13:17 ` [PATCH v2 00/11] bus: attach / detach API Gaetan Rivet
2017-05-31 13:17   ` [PATCH v2 01/11] bus: add bus iterator to find a particular bus Gaetan Rivet
2017-06-07  7:06     ` Shreyansh Jain
2017-06-07 13:27       ` Gaëtan Rivet
2017-06-07 16:55         ` Jan Blunck
2017-06-08  4:34         ` Shreyansh Jain
2017-06-08  8:05           ` Gaëtan Rivet
2017-05-31 13:17   ` [PATCH v2 02/11] bus: add device iterator Gaetan Rivet
2017-05-31 13:17   ` [PATCH v2 03/11] bus: add helper to find bus for a particular device Gaetan Rivet
2017-05-31 13:17   ` [PATCH v2 04/11] bus: add bus helper iterator to find " Gaetan Rivet
2017-06-07 16:41     ` Jan Blunck
2017-06-07 20:12       ` Gaëtan Rivet
2017-05-31 13:17   ` [PATCH v2 05/11] bus: introduce hotplug functionality Gaetan Rivet
2017-05-31 13:17   ` [PATCH v2 06/11] vdev: implement find_device bus operation Gaetan Rivet
2017-05-31 13:17   ` [PATCH v2 07/11] vdev: implement hotplug functionality Gaetan Rivet
2017-05-31 13:17   ` [PATCH v2 08/11] vdev: implement unplug bus operation Gaetan Rivet
2017-05-31 13:17   ` [PATCH v2 09/11] eal: make virtual driver probe and remove take rte_vdev_device Gaetan Rivet
2017-05-31 13:17   ` [PATCH v2 10/11] ethdev: Use embedded rte_device to detach driver Gaetan Rivet
2017-05-31 13:17   ` [PATCH v2 11/11] net/ring: fix dev handle in eth_dev Gaetan Rivet
2017-05-31 15:34   ` [PATCH v2 00/11] bus: attach / detach API Stephen Hemminger
2017-06-26  0:27     ` Gaëtan Rivet
2017-06-07 23:53   ` [PATCH v3 00/10] " Gaetan Rivet
2017-06-07 23:53     ` [PATCH v3 01/10] bus: add bus iterator to find a particular bus Gaetan Rivet
2017-06-10  8:58       ` Jan Blunck
2017-06-11 19:59         ` Gaëtan Rivet
2017-06-07 23:53     ` [PATCH v3 02/10] bus: add device iterator Gaetan Rivet
2017-06-07 23:53     ` [PATCH v3 03/10] bus: add helper to find bus for a particular device Gaetan Rivet
2017-06-07 23:53     ` [PATCH v3 04/10] bus: add bus helper iterator to find " Gaetan Rivet
2017-06-07 23:53     ` [PATCH v3 05/10] bus: introduce hotplug functionality Gaetan Rivet
2017-06-07 23:53     ` [PATCH v3 06/10] vdev: implement find_device bus operation Gaetan Rivet
2017-06-07 23:53     ` [PATCH v3 07/10] vdev: implement hotplug functionality Gaetan Rivet
2017-06-07 23:53     ` [PATCH v3 08/10] eal: make virtual driver probe and remove take rte_vdev_device Gaetan Rivet
2017-06-07 23:53     ` [PATCH v3 09/10] ethdev: use embedded rte_device to detach driver Gaetan Rivet
2017-06-07 23:53     ` Gaetan Rivet [this message]
2017-06-20 23:29     ` [PATCH v4 0/9] bus: attach / detach API Gaetan Rivet
2017-06-20 23:29       ` [PATCH v4 1/9] bus: add bus iterator to find a particular bus Gaetan Rivet
2017-06-21 12:12         ` Thomas Monjalon
2017-06-20 23:29       ` [PATCH v4 2/9] bus: add device iterator Gaetan Rivet
2017-06-21 11:55         ` Thomas Monjalon
2017-06-21 12:15           ` Gaëtan Rivet
2017-06-20 23:29       ` [PATCH v4 3/9] bus: add helper to find bus for a particular device Gaetan Rivet
2017-06-21 12:11         ` Thomas Monjalon
2017-06-20 23:29       ` [PATCH v4 4/9] bus: add bus helper iterator to find " Gaetan Rivet
2017-06-21 12:21         ` Thomas Monjalon
2017-06-20 23:29       ` [PATCH v4 5/9] bus: introduce hotplug functionality Gaetan Rivet
2017-06-20 23:29       ` [PATCH v4 6/9] vdev: implement find_device bus operation Gaetan Rivet
2017-06-20 23:29       ` [PATCH v4 7/9] vdev: implement hotplug functionality Gaetan Rivet
2017-06-20 23:29       ` [PATCH v4 8/9] eal: make virtual driver probe and remove take rte_vdev_device Gaetan Rivet
2017-06-20 23:29       ` [PATCH v4 9/9] ethdev: use embedded rte_device to detach driver Gaetan Rivet
2017-06-21 14:33         ` Thomas Monjalon
2017-06-21 14:35         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2864d0bb005bab72dcddafa692a79e13826cbec8.1496876710.git.gaetan.rivet@6wind.com \
    --to=gaetan.rivet@6wind.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.