From: Thomas Monjalon <email@example.com> To: kefu chai <firstname.lastname@example.org> Cc: Bruce Richardson <email@example.com>, Avi Kivity <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org Subject: Re: [dpdk-dev] [PATCH v4] build: add meson options of max_memseg_lists and atomic_mbuf_ref_counts Date: Wed, 13 Oct 2021 17:38:34 +0200 [thread overview] Message-ID: <28671346.9nabmiLcpg@thomas> (raw) In-Reply-To: <CAJE9aOOFq=z6wSSFF=MhSkCCz-2vfx28Fwc5w9VSDYChOtPU2A@mail.gmail.com> 27/09/2021 17:03, kefu chai: > On Mon, Sep 20, 2021 at 4:08 PM Bruce Richardson > <email@example.com> wrote: > > > > On Mon, Sep 20, 2021 at 03:51:06PM +0800, kefu chai wrote: > > > hello Bruce, > > > > > > do you have any further concerns? is there anything i can do to move > > > this forward? > > > > > > cheers, > > > > > > > +Anatoly, for his input for the memory segments change. > > > > I still would prefer not to have these as config options, but perhaps one > > or both needs to be. The atomic refcount seems more reasonable to add of > > the two. For the max memseg lists, what is the impact if we were to > > increase this value globally? > > hi Bruce, thank you for your insights. > > yeah, as i explained in the previous email.the atomic refcount is more > critical for my work on integration of DPDK+SPDK+Seastar. since > Seastar enforces share-nothing in its design, there is no need to use > atomic refcount under almost all circumstances. regarding to the max > memseg list, what i am trying is to port the change of > https://github.com/scylladb/seastar/commit/716c7c04db693c266f52de6b0cced0252d70b3bf > to the DPDK used by the latest release of SPDK. I think it would help acceptance to send these changes as 2 separate patches.
next prev parent reply other threads:[~2021-10-13 15:38 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-02 14:48 [dpdk-dev] [PATCH] build: add meson option of "max_memseg_lists" and "mbuf_refcnt_atomic" Kefu Chai 2021-09-02 15:02 ` Bruce Richardson 2021-09-02 15:05 ` [dpdk-dev] [PATCH v2] " Kefu Chai 2021-09-02 15:11 ` [dpdk-dev] [PATCH v3] build: add meson options of max_memseg_lists and atomic_mbuf_ref_counts Kefu Chai 2021-09-08 16:51 ` [dpdk-dev] [PATCH v4] " Kefu Chai 2021-09-20 7:51 ` kefu chai 2021-09-20 8:08 ` Bruce Richardson 2021-09-27 15:03 ` kefu chai 2021-10-13 15:38 ` Thomas Monjalon [this message] 2021-10-13 20:54 ` [dpdk-dev] [PATCH v5 0/2] build: add meson option of "max_memseg_lists" and "mbuf_refcnt_atomic" Kefu Chai 2021-10-13 20:54 ` [dpdk-dev] [PATCH v5 1/2] build: add meson options of atomic_mbuf_ref_counts Kefu Chai 2021-10-14 8:20 ` Bruce Richardson 2021-10-25 15:55 ` Thomas Monjalon 2021-10-13 20:54 ` [dpdk-dev] [PATCH v5 2/2] build: add meson options of max_memseg_lists Kefu Chai 2021-10-14 8:25 ` Bruce Richardson 2021-10-14 8:29 ` Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=28671346.9nabmiLcpg@thomas \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [dpdk-dev] [PATCH v4] build: add meson options of max_memseg_lists and atomic_mbuf_ref_counts' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.