All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Wang, Wei W" <wei.w.wang@intel.com>
To: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	"jbeulich@suse.com" <jbeulich@suse.com>
Cc: "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v3 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c
Date: Tue, 23 Jun 2015 01:40:51 +0000	[thread overview]
Message-ID: <286AC319A985734F985F78AFA26841F7996B2B@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1434011460-18222-1-git-send-email-wei.w.wang@intel.com>

Hi Jan,
On 11/06/2015 16:31, Wei Wang wrote:
> Add support in the pmstat.c so that the xenpm tool can request to access the
> intel_pstate driver.

I want to propose some other changes here to commonize the intel_pstate implementation in this common code (pmstat.c).
 
1) introduce a new struct:
    struct internal_governor {
        char *avail_gov;
        uint32_t cur_gov;         
        uint32_t gov_num;
    }

2) a new callback in cpufreq_driver, "cpufreq_driver->get_internal_gov(internal_gov)",
     This allows other possible cpufreq drivers, which implement their own internal governors, to return their own interenal governor info (e.g. we will not need to use the INTEL_PSTATE_GOV_NUM, which is defined to be 4, in this patch).

Do you think this would be better?

Best,
Wei

  parent reply	other threads:[~2015-06-23  1:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-11  8:31 [PATCH v3 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c Wei Wang
2015-06-11 14:10 ` Julien Grall
2015-06-12  3:03   ` Wang, Wei W
2015-06-12  8:39     ` Jan Beulich
2015-06-12 11:13     ` Julien Grall
2015-06-15  0:30       ` Wang, Wei W
2015-06-15  9:15         ` Jan Beulich
2015-06-15 12:28           ` Wang, Wei W
2015-06-15 12:36             ` Jan Beulich
2015-06-15 14:11               ` Wang, Wei W
2015-06-16  7:09               ` Wang, Wei W
2015-06-16  7:53                 ` Jan Beulich
2015-06-17  5:01                   ` Wang, Wei W
2015-06-23  1:40 ` Wang, Wei W [this message]
2015-06-23  8:45   ` Wang, Wei W
2015-06-23  8:48   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=286AC319A985734F985F78AFA26841F7996B2B@shsmsx102.ccr.corp.intel.com \
    --to=wei.w.wang@intel.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.