From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Subject: Re: [PATCH 09/13] drm/fb-helper: Split dpms handling
 into legacy and atomic paths
Date: Thu, 29 Jun 2017 12:22:25 +0200
Message-ID: <28764010-74e0-5049-ee9c-9ddc944efb20@linux.intel.com>
References: <20170627145936.18983-1-daniel.vetter@ffwll.ch>
 <20170627145936.18983-10-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
In-Reply-To: <20170627145936.18983-10-daniel.vetter@ffwll.ch>
Content-Language: en-US
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>, DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Thierry Reding <treding@nvidia.com>, Peter Rosin <peda@axentia.se>
List-Id: dri-devel@lists.freedesktop.org

T3AgMjctMDYtMTcgb20gMTY6NTkgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+IExpa2Ugd2l0aCBw
YW5uaW5nIGFuZCBtb2Rlc2V0dGluZywgYW5kIGxpa2Ugd2l0aCB0aG9zZSwgc3RpY2sgd2l0aAo+
IHNpbXBsZSBkcm1fbW9kZXNldF9sb2NraW5nX2FsbCBmb3IgdGhlIGxlZ2FjeSBwYXRoLCBhbmQg
dGhlIGZ1bGwKPiBhdG9taWMgZGFuY2UgZm9yIGF0b21pYyBkcml2ZXJzLgo+Cj4gVGhpcyBtZWFu
cyBhIGJpdCBtb3JlIGJvaWxlcnBsYXRlIHNpbmNlIHNldHRpbmcgdXAgdGhlIGF0b21pYyBzdGF0
ZQo+IG1hY2hpbmVyeSBpcyByYXRoZXIgdmVyYm9zZSwgYnV0IHRoZW4gdGhpcyBpcyBzaGFyZWQg
Y29kZSBmb3IgMzArCj4gZHJpdmVycyBvciBzbywgc28gbWVoLgo+Cj4gQWZ0ZXIgdGhpcyBwYXRj
aCB0aGVyZSdzIG9ubHkgdGhlIExVVC9jbWFwIHBhdGggd2hpY2ggaXMgc3RpbGwgdXNpbmcKPiBk
cm1fbW9kZXNldF9sb2NrX2FsbCBmb3IgYW4gYXRvbWljIGRyaXZlci4gQnV0IFBldGVyIGlzIGFs
cmVhZHkKPiBsb2NraW5nIGludG8gcmV3b3JraW5nIHRoYXQsIHNvIEknbGwgbGVhdmUgdGhhdCBj
b2RlIGFzLWlzIGZvciBub3cuCj4KPiBDYzogUGV0ZXIgUm9zaW4gPHBlZGFAYXhlbnRpYS5zZT4K
PiBDYzogSm9obiBTdHVsdHogPGpvaG4uc3R1bHR6QGxpbmFyby5vcmc+Cj4gQ2M6IFRoaWVycnkg
UmVkaW5nIDx0cmVkaW5nQG52aWRpYS5jb20+Cj4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRl
ciA8ZGFuaWVsLnZldHRlckBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1f
ZmJfaGVscGVyLmMgfCA4OCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0t
LQo+ICAxIGZpbGUgY2hhbmdlZCwgNzYgaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCj4K
PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYyBiL2RyaXZlcnMv
Z3B1L2RybS9kcm1fZmJfaGVscGVyLmMKPiBpbmRleCA1OWUyOTE2NDcxYjIuLmJiZDRjNmQwMzc4
ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4gKysrIGIv
ZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwo+IEBAIC02MTYsMjMgKzYxNiwxMyBAQCBz
dGF0aWMgc3RydWN0IHN5c3JxX2tleV9vcCBzeXNycV9kcm1fZmJfaGVscGVyX3Jlc3RvcmVfb3Ag
PSB7Cj4gIHN0YXRpYyBzdHJ1Y3Qgc3lzcnFfa2V5X29wIHN5c3JxX2RybV9mYl9oZWxwZXJfcmVz
dG9yZV9vcCA9IHsgfTsKPiAgI2VuZGlmCj4gIAo+IC1zdGF0aWMgdm9pZCBkcm1fZmJfaGVscGVy
X2RwbXMoc3RydWN0IGZiX2luZm8gKmluZm8sIGludCBkcG1zX21vZGUpCj4gK3N0YXRpYyB2b2lk
IGRwbXNfbGVnYWN5KHN0cnVjdCBkcm1fZmJfaGVscGVyICpmYl9oZWxwZXIsIGludCBkcG1zX21v
ZGUpCj4gIHsKPiAtCXN0cnVjdCBkcm1fZmJfaGVscGVyICpmYl9oZWxwZXIgPSBpbmZvLT5wYXI7
Cj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gZmJfaGVscGVyLT5kZXY7Cj4gIAlzdHJ1Y3Qg
ZHJtX2NydGMgKmNydGM7Cj4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yOwo+ICAJ
aW50IGksIGo7Cj4gIAo+IC0JLyoKPiAtCSAqIEZvciBlYWNoIENSVEMgaW4gdGhpcyBmYiwgdHVy
biB0aGUgY29ubmVjdG9ycyBvbi9vZmYuCj4gLQkgKi8KPiAtCW11dGV4X2xvY2soJmZiX2hlbHBl
ci0+bG9jayk7Cj4gLQlpZiAoIWRybV9mYl9oZWxwZXJfaXNfYm91bmQoZmJfaGVscGVyKSkgewo+
IC0JCW11dGV4X3VubG9jaygmZmJfaGVscGVyLT5sb2NrKTsKPiAtCQlyZXR1cm47Cj4gLQl9Cj4g
LQo+ICAJZHJtX21vZGVzZXRfbG9ja19hbGwoZGV2KTsKPiAgCWZvciAoaSA9IDA7IGkgPCBmYl9o
ZWxwZXItPmNydGNfY291bnQ7IGkrKykgewo+ICAJCWNydGMgPSBmYl9oZWxwZXItPmNydGNfaW5m
b1tpXS5tb2RlX3NldC5jcnRjOwo+IEBAIC02NDksNiArNjM5LDgxIEBAIHN0YXRpYyB2b2lkIGRy
bV9mYl9oZWxwZXJfZHBtcyhzdHJ1Y3QgZmJfaW5mbyAqaW5mbywgaW50IGRwbXNfbW9kZSkKPiAg
CQl9Cj4gIAl9Cj4gIAlkcm1fbW9kZXNldF91bmxvY2tfYWxsKGRldik7Cj4gK30KPiArCj4gK3N0
YXRpYyB2b2lkIGRwbXNfYXRvbWljKHN0cnVjdCBkcm1fZmJfaGVscGVyICpmYl9oZWxwZXIsIGlu
dCBkcG1zX21vZGUpCj4gK3sKPiArCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBmYl9oZWxwZXIt
PmRldjsKPiArCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZTsKPiArCWludCBpLCByZXQ7
Cj4gKwo+ICsJc3RydWN0IGRybV9tb2Rlc2V0X2FjcXVpcmVfY3R4IGN0eDsKPiArCj4gKwlkcm1f
bW9kZXNldF9hY3F1aXJlX2luaXQoJmN0eCwgMCk7Cj4gKwo+ICsJc3RhdGUgPSBkcm1fYXRvbWlj
X3N0YXRlX2FsbG9jKGRldik7Cj4gKwlpZiAoIXN0YXRlKSB7Cj4gKwkJcmV0ID0gLUVOT01FTTsK
PiArCQlnb3RvIG91dF9jdHg7Cj4gKwl9Cj4gKwo+ICsJc3RhdGUtPmFjcXVpcmVfY3R4ID0gJmN0
eDsKPiArcmV0cnk6Cj4gKwlmb3IgKGkgPSAwOyBpIDwgZmJfaGVscGVyLT5jcnRjX2NvdW50OyBp
KyspIHsKPiArCQlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4gKwkJc3RydWN0
IGRybV9jcnRjICpjcnRjOwo+ICsKPiArCQlpZiAoIWZiX2hlbHBlci0+Y3J0Y19pbmZvW2ldLm1v
ZGVfc2V0Lm1vZGUpCj4gKwkJCWNvbnRpbnVlOwo+ICsKPiArCQljcnRjID0gZmJfaGVscGVyLT5j
cnRjX2luZm9baV0ubW9kZV9zZXQuY3J0YzsKPiArCj4gKwkJY3J0Y19zdGF0ZSA9IGRybV9hdG9t
aWNfZ2V0X2NydGNfc3RhdGUoc3RhdGUsIGNydGMpOwo+ICsJCWlmIChJU19FUlIoY3J0Y19zdGF0
ZSkpIHsKPiArCQkJcmV0ID0gUFRSX0VSUihjcnRjX3N0YXRlKTsKPiArCQkJZ290byBvdXRfc3Rh
dGU7Cj4gKwkJfQpIbSwgbWF5YmUgcmVtb3ZlIHRoZSBlYXJseSBjb250aW51ZSwgYW5kIGNoYW5n
ZSB0aGlzIHRvIGlmIChjcnRjX3N0YXRlLT5lbmFibGUpIGNydGNfc3RhdGUtPmFjdGl2ZSA9IC4u
LjsgPwoKSSBkb24ndCBrbm93IGlmIGl0IG1hdHRlcnMgaW4gcHJhY3RpY2UsIGJ1dCBpdCBtaWdo
dCBiZSBtb3JlIHJlc2lsaWVudCB3aGVuIGNydGMgc3RhdGUgZG9lcyBub3QgbWF0Y2ggb3VyIGV4
cGVjdGVkIHN0YXRlLApzaW1pbGFyIHRvIGhvdyBEUE1TIG9uIGlzIGlnbm9yZWQgd2l0aG91dCBD
UlRDLgo+ICsJCWNydGNfc3RhdGUtPmFjdGl2ZSA9IGRwbXNfbW9kZSA9PSBEUk1fTU9ERV9EUE1T
X09OOwo+ICsJfQo+ICsKPiArCXJldCA9IGRybV9hdG9taWNfY29tbWl0KHN0YXRlKTsKPiArb3V0
X3N0YXRlOgo+ICsJaWYgKHJldCA9PSAtRURFQURMSykKPiArCQlnb3RvIGJhY2tvZmY7Cj4gKwo+
ICsJZHJtX2F0b21pY19zdGF0ZV9wdXQoc3RhdGUpOwo+ICtvdXRfY3R4Ogo+ICsJZHJtX21vZGVz
ZXRfZHJvcF9sb2NrcygmY3R4KTsKPiArCWRybV9tb2Rlc2V0X2FjcXVpcmVfZmluaSgmY3R4KTsK
PiArCj4gKwlyZXR1cm47Cj4gKwo+ICtiYWNrb2ZmOgo+ICsJZHJtX2F0b21pY19zdGF0ZV9jbGVh
cihzdGF0ZSk7Cj4gKwlkcm1fbW9kZXNldF9iYWNrb2ZmKCZjdHgpOwo+ICsKPiArCWdvdG8gcmV0
cnk7Cj4gKwo+ICt9Cj4gKwo+ICtzdGF0aWMgdm9pZCBkcm1fZmJfaGVscGVyX2RwbXMoc3RydWN0
IGZiX2luZm8gKmluZm8sIGludCBkcG1zX21vZGUpCj4gK3sKPiArCXN0cnVjdCBkcm1fZmJfaGVs
cGVyICpmYl9oZWxwZXIgPSBpbmZvLT5wYXI7Cj4gKwo+ICsJLyoKPiArCSAqIEZvciBlYWNoIENS
VEMgaW4gdGhpcyBmYiwgdHVybiB0aGUgY29ubmVjdG9ycyBvbi9vZmYuCj4gKwkgKi8KPiArCW11
dGV4X2xvY2soJmZiX2hlbHBlci0+bG9jayk7Cj4gKwlpZiAoIWRybV9mYl9oZWxwZXJfaXNfYm91
bmQoZmJfaGVscGVyKSkgewo+ICsJCW11dGV4X3VubG9jaygmZmJfaGVscGVyLT5sb2NrKTsKPiAr
CQlyZXR1cm47Cj4gKwl9Cj4gKwo+ICsJaWYgKGRybV9kcnZfdXNlc19hdG9taWNfbW9kZXNldChm
Yl9oZWxwZXItPmRldikpCj4gKwkJZHBtc19hdG9taWMoZmJfaGVscGVyLCBkcG1zX21vZGUpOwo+
ICsJZWxzZQo+ICsJCWRwbXNfbGVnYWN5KGZiX2hlbHBlciwgZHBtc19tb2RlKTsKPiAgCW11dGV4
X3VubG9jaygmZmJfaGVscGVyLT5sb2NrKTsKPiAgfQo+ICAKPiBAQCAtMjQ2Nyw3ICsyNTMyLDYg
QEAgRVhQT1JUX1NZTUJPTChkcm1fZmJfaGVscGVyX2luaXRpYWxfY29uZmlnKTsKPiAgICovCj4g
IGludCBkcm1fZmJfaGVscGVyX2hvdHBsdWdfZXZlbnQoc3RydWN0IGRybV9mYl9oZWxwZXIgKmZi
X2hlbHBlcikKPiAgewo+IC0Jc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGZiX2hlbHBlci0+ZGV2
Owo+ICAJaW50IGVyciA9IDA7Cj4gIAo+ICAJaWYgKCFkcm1fZmJkZXZfZW11bGF0aW9uKQoKCl9f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt
YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz
LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=