From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:40756 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388296AbeKWWuj (ORCPT ); Fri, 23 Nov 2018 17:50:39 -0500 From: Laurent Pinchart To: Fabrizio Castro Cc: Kieran Bingham , David Airlie , "dri-devel@lists.freedesktop.org" , "linux-renesas-soc@vger.kernel.org" , Simon Horman , Geert Uytterhoeven , Chris Paterson , Biju Das Subject: Re: [PATCH v2 3/5] drm: rcar-du: Add r8a77470 support Date: Fri, 23 Nov 2018 14:07:00 +0200 Message-ID: <2887339.4V2sBHk5lD@avalon> In-Reply-To: References: <1539709139-20342-1-git-send-email-fabrizio.castro@bp.renesas.com> <2608669.V0TntACJSi@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Fabrizio, On Thursday, 22 November 2018 18:03:44 EET Fabrizio Castro wrote: > On 17 October 2018 07:52 Laurent Pinchart wrote: > > On Tuesday, 16 October 2018 19:58:59 EEST Fabrizio Castro wrote: > > > Add RZ/G1C (a.k.a. r8a77470) support to the R-Car DU driver. > >> > >> Signed-off-by: Fabrizio Castro > >> Reviewed-by: Laurent Pinchart > >> > >> --- > >> v1->v2: > >> * Added flags RCAR_DU_FEATURE_INTERLACED and RCAR_DU_FEATURE_TVM_SYNC > >> * Reworked comment > > > > This looks all good, applied to my tree. > > It looks like I can't find the patch, which tree is it? The patch can be found in git://linuxtv.org/pinchartl/media.git drm/du/next. > >> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 28 ++++++++++++++++++++++++++++ > >> 1 file changed, 28 insertions(+) > >> > >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > >> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 084f58d..d8a02c4 100644 > >> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > >> @@ -77,6 +77,33 @@ static const struct rcar_du_device_info > >> rzg1_du_r8a7745_info = { }, > >> }; > >> > >> +static const struct rcar_du_device_info rzg1_du_r8a77470_info = { > >> +.gen = 2, > >> +.features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK > >> + | RCAR_DU_FEATURE_EXT_CTRL_REGS > >> + | RCAR_DU_FEATURE_INTERLACED > >> + | RCAR_DU_FEATURE_TVM_SYNC, > >> +.channels_mask = BIT(1) | BIT(0), > >> +.routes = { > >> +/* > >> + * R8A77470 has two RGB outputs, one LVDS output, and > >> + * one (currently unsupported) analog video output > >> + */ > >> +[RCAR_DU_OUTPUT_DPAD0] = { > >> +.possible_crtcs = BIT(0), > >> +.port = 0, > >> +}, > >> +[RCAR_DU_OUTPUT_DPAD1] = { > >> +.possible_crtcs = BIT(1), > >> +.port = 1, > >> +}, > >> +[RCAR_DU_OUTPUT_LVDS0] = { > >> +.possible_crtcs = BIT(0) | BIT(1), > >> +.port = 2, > >> +}, > >> +}, > >> +}; > >> + > >> static const struct rcar_du_device_info rcar_du_r8a7779_info = { > >> .gen = 2, > >> .features = RCAR_DU_FEATURE_INTERLACED > >> @@ -342,6 +369,7 @@ static const struct rcar_du_device_info > >> rcar_du_r8a7799x_info = { static const struct of_device_id > >> rcar_du_of_table[] = { > >> { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info }, > >> { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info }, > >> +{ .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info > >> }, > >> { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info }, > >> { .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info }, > >> { .compatible = "renesas,du-r8a7791", .data = &rcar_du_r8a7791_info }, -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 3/5] drm: rcar-du: Add r8a77470 support Date: Fri, 23 Nov 2018 14:07:00 +0200 Message-ID: <2887339.4V2sBHk5lD@avalon> References: <1539709139-20342-1-git-send-email-fabrizio.castro@bp.renesas.com> <2608669.V0TntACJSi@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id A7C086E082 for ; Fri, 23 Nov 2018 12:06:41 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Fabrizio Castro Cc: Simon Horman , Chris Paterson , Geert Uytterhoeven , David Airlie , "dri-devel@lists.freedesktop.org" , Biju Das , "linux-renesas-soc@vger.kernel.org" , Kieran Bingham List-Id: dri-devel@lists.freedesktop.org SGkgRmFicml6aW8sCgpPbiBUaHVyc2RheSwgMjIgTm92ZW1iZXIgMjAxOCAxODowMzo0NCBFRVQg RmFicml6aW8gQ2FzdHJvIHdyb3RlOgo+IE9uIDE3IE9jdG9iZXIgMjAxOCAwNzo1MiBMYXVyZW50 IFBpbmNoYXJ0IHdyb3RlOgo+ID4gT24gVHVlc2RheSwgMTYgT2N0b2JlciAyMDE4IDE5OjU4OjU5 IEVFU1QgRmFicml6aW8gQ2FzdHJvIHdyb3RlOgo+ID4gPiBBZGQgUlovRzFDIChhLmsuYS4gcjhh Nzc0NzApIHN1cHBvcnQgdG8gdGhlIFItQ2FyIERVIGRyaXZlci4KPiA+PiAKPiA+PiBTaWduZWQt b2ZmLWJ5OiBGYWJyaXppbyBDYXN0cm8gPGZhYnJpemlvLmNhc3Ryb0BicC5yZW5lc2FzLmNvbT4K PiA+PiBSZXZpZXdlZC1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVh c29uYm9hcmQuY29tPgo+ID4+IAo+ID4+IC0tLQo+ID4+IHYxLT52MjoKPiA+PiAqIEFkZGVkIGZs YWdzIFJDQVJfRFVfRkVBVFVSRV9JTlRFUkxBQ0VEIGFuZCBSQ0FSX0RVX0ZFQVRVUkVfVFZNX1NZ TkMKPiA+PiAqIFJld29ya2VkIGNvbW1lbnQKPiA+IAo+ID4gVGhpcyBsb29rcyBhbGwgZ29vZCwg YXBwbGllZCB0byBteSB0cmVlLgo+IAo+IEl0IGxvb2tzIGxpa2UgSSBjYW4ndCBmaW5kIHRoZSBw YXRjaCwgd2hpY2ggdHJlZSBpcyBpdD8KClRoZSBwYXRjaCBjYW4gYmUgZm91bmQgaW4gZ2l0Oi8v bGludXh0di5vcmcvcGluY2hhcnRsL21lZGlhLmdpdCBkcm0vZHUvbmV4dC4KCj4gPj4gIGRyaXZl cnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmMgfCAyOCArKysrKysrKysrKysrKysrKysr KysrKysrKysrCj4gPj4gIDEgZmlsZSBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCspCj4gPj4gCj4g Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmMKPiA+ PiBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmMgaW5kZXggMDg0ZjU4ZC4u ZDhhMDJjNCAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1 X2Rydi5jCj4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYwo+ ID4+IEBAIC03Nyw2ICs3NywzMyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHJjYXJfZHVfZGV2aWNl X2luZm8KPiA+PiByemcxX2R1X3I4YTc3NDVfaW5mbyA9IHsgfSwKPiA+PiAgfTsKPiA+PiAKPiA+ PiArc3RhdGljIGNvbnN0IHN0cnVjdCByY2FyX2R1X2RldmljZV9pbmZvIHJ6ZzFfZHVfcjhhNzc0 NzBfaW5mbyA9IHsKPiA+PiArLmdlbiA9IDIsCj4gPj4gKy5mZWF0dXJlcyA9IFJDQVJfRFVfRkVB VFVSRV9DUlRDX0lSUV9DTE9DSwo+ID4+ICsgIHwgUkNBUl9EVV9GRUFUVVJFX0VYVF9DVFJMX1JF R1MKPiA+PiArICB8IFJDQVJfRFVfRkVBVFVSRV9JTlRFUkxBQ0VECj4gPj4gKyAgfCBSQ0FSX0RV X0ZFQVRVUkVfVFZNX1NZTkMsCj4gPj4gKy5jaGFubmVsc19tYXNrID0gQklUKDEpIHwgQklUKDAp LAo+ID4+ICsucm91dGVzID0gewo+ID4+ICsvKgo+ID4+ICsgKiBSOEE3NzQ3MCBoYXMgdHdvIFJH QiBvdXRwdXRzLCBvbmUgTFZEUyBvdXRwdXQsIGFuZAo+ID4+ICsgKiBvbmUgKGN1cnJlbnRseSB1 bnN1cHBvcnRlZCkgYW5hbG9nIHZpZGVvIG91dHB1dAo+ID4+ICsgKi8KPiA+PiArW1JDQVJfRFVf T1VUUFVUX0RQQUQwXSA9IHsKPiA+PiArLnBvc3NpYmxlX2NydGNzID0gQklUKDApLAo+ID4+ICsu cG9ydCA9IDAsCj4gPj4gK30sCj4gPj4gK1tSQ0FSX0RVX09VVFBVVF9EUEFEMV0gPSB7Cj4gPj4g Ky5wb3NzaWJsZV9jcnRjcyA9IEJJVCgxKSwKPiA+PiArLnBvcnQgPSAxLAo+ID4+ICt9LAo+ID4+ ICtbUkNBUl9EVV9PVVRQVVRfTFZEUzBdID0gewo+ID4+ICsucG9zc2libGVfY3J0Y3MgPSBCSVQo MCkgfCBCSVQoMSksCj4gPj4gKy5wb3J0ID0gMiwKPiA+PiArfSwKPiA+PiArfSwKPiA+PiArfTsK PiA+PiArCj4gPj4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgcmNhcl9kdV9kZXZpY2VfaW5mbyByY2Fy X2R1X3I4YTc3NzlfaW5mbyA9IHsKPiA+PiAgLmdlbiA9IDIsCj4gPj4gIC5mZWF0dXJlcyA9IFJD QVJfRFVfRkVBVFVSRV9JTlRFUkxBQ0VECj4gPj4gQEAgLTM0Miw2ICszNjksNyBAQCBzdGF0aWMg Y29uc3Qgc3RydWN0IHJjYXJfZHVfZGV2aWNlX2luZm8KPiA+PiByY2FyX2R1X3I4YTc3OTl4X2lu Zm8gPSB7IHN0YXRpYyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkCj4gPj4gcmNhcl9kdV9vZl90 YWJsZVtdID0gewo+ID4+ICB7IC5jb21wYXRpYmxlID0gInJlbmVzYXMsZHUtcjhhNzc0MyIsIC5k YXRhID0gJnJ6ZzFfZHVfcjhhNzc0M19pbmZvIH0sCj4gPj4gIHsgLmNvbXBhdGlibGUgPSAicmVu ZXNhcyxkdS1yOGE3NzQ1IiwgLmRhdGEgPSAmcnpnMV9kdV9yOGE3NzQ1X2luZm8gfSwKPiA+PiAr eyAuY29tcGF0aWJsZSA9ICJyZW5lc2FzLGR1LXI4YTc3NDcwIiwgLmRhdGEgPSAmcnpnMV9kdV9y OGE3NzQ3MF9pbmZvCj4gPj4gfSwKPiA+PiAgeyAuY29tcGF0aWJsZSA9ICJyZW5lc2FzLGR1LXI4 YTc3NzkiLCAuZGF0YSA9ICZyY2FyX2R1X3I4YTc3NzlfaW5mbyB9LAo+ID4+ICB7IC5jb21wYXRp YmxlID0gInJlbmVzYXMsZHUtcjhhNzc5MCIsIC5kYXRhID0gJnJjYXJfZHVfcjhhNzc5MF9pbmZv IH0sCj4gPj4gIHsgLmNvbXBhdGlibGUgPSAicmVuZXNhcyxkdS1yOGE3NzkxIiwgLmRhdGEgPSAm cmNhcl9kdV9yOGE3NzkxX2luZm8gfSwKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoK CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK