All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Suanming Mou <suanmingm@mellanox.com>
Cc: dev@dpdk.org, "Pattan, Reshma" <reshma.pattan@intel.com>,
	"Varghese, Vipin" <vipin.varghese@intel.com>,
	"Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH v9] app/pdump: exit with primary process
Date: Thu, 11 Jul 2019 00:28:16 +0200	[thread overview]
Message-ID: <2890132.ffEPgPjtxx@xps> (raw)
In-Reply-To: <f616c2b5-4c00-a313-fb54-fbd3440a8998@mellanox.com>

10/07/2019 16:04, Suanming Mou:
> On 6/24/2019 6:30 AM, Thomas Monjalon wrote:
> > 20/06/2019 15:32, Pattan, Reshma:
> >> From: Suanming.Mou [mailto:mousuanming@huawei.com]
> >>> Signed-off-by: Suanming Mou <mousuanming@huawei.com>
> >>> Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
> >>> Reviewed-by: Vipin Varghese <vipin.varghese@intel.com>
> >>> Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
> >>> Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
> >>> ---
> >>> V9:
> >>> * reword the comments and update the git log.
> >>> * move release note to release_19_08.rst.
> >>> * remove dot in name.
> >>>
> >> Acked-by line is missing, so re acking. Keep my ack if you have to send next version.
> >> Acked-by: Reshma Pattan <reshma.pattan@intel.com>
> > That's not correct to add Reviewed-by lines if it was not explicitly
> > found in a previous reply.
> > Suanming, I think you need to remove some lines above.
> 
> Thanks for the guidelines.
> Yes, the tags should be as below since just Anatoly gave the Reviewed-by 
> tag and Reshma gave the Acked-by tag in the previous mail.
> Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Acked-by: Reshma Pattan reshma.pattan@intel.com
> 
> Sorry for the mistake and the late response.
> (I wish my thunderbird would correctly handle the In-Reply-To header by 
> direct click the mailto link.)

Applied, thanks





  reply	other threads:[~2019-07-10 22:28 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-25 16:35 [dpdk-dev] [PATCH] app/pdump: exits once primary app exited Suanming.Mou
2019-04-25 15:51 ` Varghese, Vipin
2019-04-26  7:11   ` Suanming.Mou
2019-04-26 10:54     ` Varghese, Vipin
2019-04-26 10:56       ` Varghese, Vipin
2019-04-26 12:08         ` Suanming.Mou
2019-04-26 13:46           ` Burakov, Anatoly
2019-04-26 14:32             ` Suanming.Mou
2019-04-26 14:39               ` Burakov, Anatoly
2019-04-26 14:49                 ` Suanming.Mou
2019-04-26 14:50                   ` Burakov, Anatoly
2019-04-28  4:58 ` [dpdk-dev] [PATCH v2] app/pdump: add exit_with_primary option support Suanming.Mou
2019-04-28  5:07   ` [dpdk-dev] [PATCH v3] " Suanming.Mou
2019-04-30  3:39     ` [dpdk-dev] [PATCH v4] app/pdump: add pudmp exits with primary support Suanming.Mou
2019-04-30  2:33       ` Varghese, Vipin
2019-04-30  3:43         ` Suanming.Mou
2019-04-30  5:03           ` Varghese, Vipin
2019-04-30  9:34         ` Burakov, Anatoly
2019-04-30 10:37           ` Varghese, Vipin
2019-04-30 16:38             ` Burakov, Anatoly
2019-04-30 11:35       ` [dpdk-dev] [PATCH v5] Make pdump exits with primary Suanming.Mou
2019-04-30 11:35         ` [dpdk-dev] [PATCH v5] app/pdump: add pudmp exits with primary support Suanming.Mou
2019-04-30  9:42           ` Burakov, Anatoly
2019-04-30 11:25             ` Suanming.Mou
2019-04-30 16:39               ` Burakov, Anatoly
2019-05-02  3:07                 ` Suanming.Mou
2019-04-30 12:44           ` Pattan, Reshma
2019-05-02  5:20           ` [dpdk-dev] [PATCH v6] " Suanming.Mou
2019-05-02  8:04             ` Varghese, Vipin
2019-05-02  8:32               ` Suanming.Mou
2019-05-02  9:12                 ` Burakov, Anatoly
2019-05-02  9:22                 ` Varghese, Vipin
2019-05-02  9:54             ` Pattan, Reshma
2019-05-02 10:40               ` Suanming.Mou
2019-05-02 12:35             ` [dpdk-dev] [PATCH v7] " Suanming.Mou
2019-05-02 11:03               ` Pattan, Reshma
2019-05-02 11:31               ` Burakov, Anatoly
2019-05-03  5:48               ` [dpdk-dev] [PATCH v8] " Suanming.Mou
2019-05-04 21:17                 ` Thomas Monjalon
2019-05-05  1:20                   ` Suanming.Mou
2019-05-05  9:42                     ` Thomas Monjalon
2019-05-05 11:13                       ` Suanming.Mou
2019-05-08  8:04                 ` Thomas Monjalon
2019-05-08  9:37                   ` Suanming.Mou
2019-05-08 10:22                     ` Thomas Monjalon
2019-05-08 13:14                       ` Suanming.Mou
2019-05-15  5:10                 ` [dpdk-dev] [PATCH v9] app/pdump: exit with primary process Suanming.Mou
2019-06-20 12:32                   ` Pattan, Reshma
2019-06-23 22:30                     ` Thomas Monjalon
2019-07-10 14:04                       ` Suanming Mou
2019-07-10 22:28                         ` Thomas Monjalon [this message]
2019-04-29  9:14   ` [dpdk-dev] [PATCH v2] app/pdump: add exit_with_primary option support Burakov, Anatoly
2019-04-29  9:43     ` Suanming.Mou
2019-04-29 10:42       ` Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2890132.ffEPgPjtxx@xps \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=reshma.pattan@intel.com \
    --cc=suanmingm@mellanox.com \
    --cc=vipin.varghese@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.