From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 127C1C433EF for ; Tue, 19 Jul 2022 05:23:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235635AbiGSFXQ (ORCPT ); Tue, 19 Jul 2022 01:23:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229916AbiGSFXM (ORCPT ); Tue, 19 Jul 2022 01:23:12 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D52C029C9F; Mon, 18 Jul 2022 22:23:10 -0700 (PDT) X-UUID: 4e8846fb173b4eccb21f85352c42b6a4-20220719 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.8,REQID:24a99d57-fe52-4693-b06a-2ab937f7a3d0,OB:0,LO B:0,IP:0,URL:5,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:5 X-CID-META: VersionHash:0f94e32,CLOUDID:0229dbd7-5d6d-4eaf-a635-828a3ee48b7c,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:1,File:nil ,QS:nil,BEC:nil,COL:0 X-UUID: 4e8846fb173b4eccb21f85352c42b6a4-20220719 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 2079981862; Tue, 19 Jul 2022 13:23:08 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs11n2.mediatek.inc (172.21.101.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Tue, 19 Jul 2022 13:23:06 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Tue, 19 Jul 2022 13:23:06 +0800 Message-ID: <2893728a294ef13bdeba9e587083b82fb794cc68.camel@mediatek.com> Subject: Re: [for-next][PATCH 13/23] USB: mtu3: tracing: Use the new __vstring() helper From: Chunfeng Yun To: Steven Rostedt CC: , Ingo Molnar , "Andrew Morton" , , , , Greg Kroah-Hartman Date: Tue, 19 Jul 2022 13:23:06 +0800 In-Reply-To: <20220715173944.386743d8@gandalf.local.home> References: <20220714164256.403842845@goodmis.org> <20220714164330.311734558@goodmis.org> <1267b234b09280b9b475cfe2bb32580e967e2dac.camel@mediatek.com> <20220715173944.386743d8@gandalf.local.home> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2022-07-15 at 17:39 -0400, Steven Rostedt wrote: > On Fri, 15 Jul 2022 14:32:05 +0800 > Chunfeng Yun wrote: > > > Can you help to remove macro "MTU3_MSG_MAX" and one blank line > > after it > > in this file, this macro is not used anymore after apply this > > patch. > > Care to send me a patch, and I'll just include it in my series? Seems no need add another patch, just modify this patch as below: diff --git a/drivers/usb/mtu3/mtu3_trace.h b/drivers/usb/mtu3/mtu3_trace.h index a09deae1146f..03d2a9bac27e 100644 --- a/drivers/usb/mtu3/mtu3_trace.h +++ b/drivers/usb/mtu3/mtu3_trace.h @@ -18,18 +18,16 @@ #include "mtu3.h" -#define MTU3_MSG_MAX 256 - TRACE_EVENT(mtu3_log, TP_PROTO(struct device *dev, struct va_format *vaf), TP_ARGS(dev, vaf), TP_STRUCT__entry( __string(name, dev_name(dev)) - __dynamic_array(char, msg, MTU3_MSG_MAX) + __vstring(msg, vaf->fmt, vaf->va) ), TP_fast_assign( __assign_str(name, dev_name(dev)); - vsnprintf(__get_str(msg), MTU3_MSG_MAX, vaf->fmt, *vaf- >va); + __assign_vstr(msg, vaf->fmt, vaf->va); ), TP_printk("%s: %s", __get_str(name), __get_str(msg)) ); > remove below two lines " -#define MTU3_MSG_MAX 256 - " Thanks > -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3CD4C43334 for ; Tue, 19 Jul 2022 06:14:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qxRzWsYJpLsm7zsS/oZEJSFt7aoMH/AxlQDmQqZRBUM=; b=VhqifI7k6DrTcq iVJGNpwtk8bE4e/Ul7fJHKbqvIH7xNVg8FF9pnmpkrCf2xkebMGqrlXx/sLSsZLrL12z/IU77U1kD Y3Gfee/dDRwmm1klbelOkmhwmu3MCfgMu2o0wfZ9pAZjFFz0nYbeQNPm+too+CD9Z/dpygDckWBHY nxFg94j/1iK2kIL8LMO4vA8+io6PLwc7DWBEoaZtq1eqAoggCMZcjV5jAQueWdTWYF53tJM/QKk1l l8LqmVpqz6JVyi94O9WIgaUQXaO0F+UzZf7dehoW6wtniqPqOMN9F9ytQXbISZfxHwEtVL2MENYAn gG5t8OLzB1q2Z6WWk4AQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDgTv-005cwR-QN; Tue, 19 Jul 2022 06:13:19 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDgTs-005cvc-M0; Tue, 19 Jul 2022 06:13:17 +0000 X-UUID: f3bb4e55efbb44828735624ec3e58d0d-20220718 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=+vtvFKOriBDSAwwMa2gfg320KgNN4SXwPXoryI7fbes=; b=poY2v/C45zTjxGu71h1MWqghs5P53A7oh2DbhY5CwVdICDvSHNGfinR+ARDQKZ5I6QR6wmEVXzb7GRVGwxE61lJBMfg53EpKR3/o5zLpfHDSeg7lRFqPaplwQwJufM8+151OeL7bSV5NX30cIsrTSYyOF5C9hAXz97Jw4RGp2XA=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.8,REQID:f7b99077-9199-49cd-be81-415da3a01d0a,OB:0,LO B:0,IP:0,URL:5,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:5 X-CID-META: VersionHash:0f94e32,CLOUDID:2265aa64-0b3f-4b2c-b3a6-ed5c044366a0,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:1,File:nil ,QS:nil,BEC:nil,COL:0 X-UUID: f3bb4e55efbb44828735624ec3e58d0d-20220718 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1874285875; Mon, 18 Jul 2022 23:13:11 -0700 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs11n2.mediatek.inc (172.21.101.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Tue, 19 Jul 2022 13:23:06 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Tue, 19 Jul 2022 13:23:06 +0800 Message-ID: <2893728a294ef13bdeba9e587083b82fb794cc68.camel@mediatek.com> Subject: Re: [for-next][PATCH 13/23] USB: mtu3: tracing: Use the new __vstring() helper From: Chunfeng Yun To: Steven Rostedt CC: , Ingo Molnar , "Andrew Morton" , , , , Greg Kroah-Hartman Date: Tue, 19 Jul 2022 13:23:06 +0800 In-Reply-To: <20220715173944.386743d8@gandalf.local.home> References: <20220714164256.403842845@goodmis.org> <20220714164330.311734558@goodmis.org> <1267b234b09280b9b475cfe2bb32580e967e2dac.camel@mediatek.com> <20220715173944.386743d8@gandalf.local.home> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220718_231316_744331_3569D290 X-CRM114-Status: GOOD ( 12.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2022-07-15 at 17:39 -0400, Steven Rostedt wrote: > On Fri, 15 Jul 2022 14:32:05 +0800 > Chunfeng Yun wrote: > > > Can you help to remove macro "MTU3_MSG_MAX" and one blank line > > after it > > in this file, this macro is not used anymore after apply this > > patch. > > Care to send me a patch, and I'll just include it in my series? Seems no need add another patch, just modify this patch as below: diff --git a/drivers/usb/mtu3/mtu3_trace.h b/drivers/usb/mtu3/mtu3_trace.h index a09deae1146f..03d2a9bac27e 100644 --- a/drivers/usb/mtu3/mtu3_trace.h +++ b/drivers/usb/mtu3/mtu3_trace.h @@ -18,18 +18,16 @@ #include "mtu3.h" -#define MTU3_MSG_MAX 256 - TRACE_EVENT(mtu3_log, TP_PROTO(struct device *dev, struct va_format *vaf), TP_ARGS(dev, vaf), TP_STRUCT__entry( __string(name, dev_name(dev)) - __dynamic_array(char, msg, MTU3_MSG_MAX) + __vstring(msg, vaf->fmt, vaf->va) ), TP_fast_assign( __assign_str(name, dev_name(dev)); - vsnprintf(__get_str(msg), MTU3_MSG_MAX, vaf->fmt, *vaf- >va); + __assign_vstr(msg, vaf->fmt, vaf->va); ), TP_printk("%s: %s", __get_str(name), __get_str(msg)) ); > remove below two lines " -#define MTU3_MSG_MAX 256 - " Thanks > -- Steve _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel