All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "chaitra.basappa@broadcom.com" <chaitra.basappa@broadcom.com>,
	"lkp@intel.com" <lkp@intel.com>
Cc: "kbuild-all@01.org" <kbuild-all@01.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"Sathya.Prakash@broadcom.com" <Sathya.Prakash@broadcom.com>,
	"suganath-prabu.subramani@broadcom.com"
	<suganath-prabu.subramani@broadcom.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"jaco@uls.co.za" <jaco@uls.co.za>
Subject: Re: [RFC PATCH] mpt3sas: mpt3sas_scsih_enclosure_find_by_handle can be static
Date: Tue, 27 Mar 2018 18:55:19 +0000	[thread overview]
Message-ID: <289588bbff4dc0d35e519d0c4d4282da78cc6121.camel@wdc.com> (raw)
In-Reply-To: <20180320210652.GA40906@xian>

On Wed, 2018-03-21 at 05:06 +0800, kbuild test robot wrote:
> Fixes: 793a6223beef ("mpt3sas: Cache enclosure pages during enclosure add.")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>  mpt3sas_scsih.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> index c93c5c5..67a43957 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> @@ -1370,7 +1370,7 @@ mpt3sas_scsih_expander_find_by_handle(struct MPT3SAS_ADAPTER *ioc, u16 handle)
>   * This searches for enclosure device based on handle, then returns the
>   * enclosure object.
>   */
> -struct _enclosure_node *
> +static struct _enclosure_node *
>  mpt3sas_scsih_enclosure_find_by_handle(struct MPT3SAS_ADAPTER *ioc, u16 handle)
>  {
>  	struct _enclosure_node *enclosure_dev, *r;

Hello Chaitra,

Are you aware that if the 0-day test infrastructure suggests an improvement
for a patch that the patch that that improvement applies to gets ignored
unless either the patch is reposted with the improvement applied or that it
is explained why the suggested improvement is inappropriate?

Thanks,

Bart.



  reply	other threads:[~2018-03-27 18:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-20 10:15 [PATCH] mpt3sas: Cache enclosure pages during enclosure add Chaitra P B
2018-03-20 21:06 ` kbuild test robot
2018-03-20 21:06   ` kbuild test robot
2018-03-20 21:06 ` [RFC PATCH] mpt3sas: mpt3sas_scsih_enclosure_find_by_handle can be static kbuild test robot
2018-03-20 21:06   ` kbuild test robot
2018-03-27 18:55   ` Bart Van Assche [this message]
2018-03-28 21:54     ` Martin K. Petersen
2018-03-28 21:54       ` Martin K. Petersen
2018-04-05 11:43       ` *** SPAM *** " Jaco Kroon
2018-04-10  7:15       ` Jaco Kroon
2018-04-10 12:46         ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=289588bbff4dc0d35e519d0c4d4282da78cc6121.camel@wdc.com \
    --to=bart.vanassche@wdc.com \
    --cc=Sathya.Prakash@broadcom.com \
    --cc=chaitra.basappa@broadcom.com \
    --cc=jaco@uls.co.za \
    --cc=kbuild-all@01.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=stable@vger.kernel.org \
    --cc=suganath-prabu.subramani@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.