From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guillaume Nault Subject: [PATCH iproute2 1/3] l2tp: drop data_seq Date: Fri, 27 Jul 2018 12:26:30 +0200 Message-ID: <289a916292ee1851593fb59c992a3948be1ed07b.1532685939.git.g.nault@alphalink.fr> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Stephen Hemminger To: netdev@vger.kernel.org Return-path: Received: from zimbra.alphalink.fr ([217.15.80.77]:37846 "EHLO zimbra.alphalink.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729493AbeG0Lru (ORCPT ); Fri, 27 Jul 2018 07:47:50 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: This option can't be set by user and is never printed. Furthermore, L2TP_ATTR_DATA_SEQ has always been a noop in Linux. Signed-off-by: Guillaume Nault --- ip/ipl2tp.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/ip/ipl2tp.c b/ip/ipl2tp.c index 05e96387..aca9912c 100644 --- a/ip/ipl2tp.c +++ b/ip/ipl2tp.c @@ -60,7 +60,6 @@ struct l2tp_parm { unsigned int recv_seq:1; unsigned int send_seq:1; unsigned int lns_mode:1; - unsigned int data_seq:2; unsigned int tunnel:1; unsigned int session:1; int reorder_timeout; @@ -167,8 +166,6 @@ static int create_session(struct l2tp_parm *p) addattr8(&req.n, 1024, L2TP_ATTR_SEND_SEQ, 1); if (p->lns_mode) addattr(&req.n, 1024, L2TP_ATTR_LNS_MODE); - if (p->data_seq) - addattr8(&req.n, 1024, L2TP_ATTR_DATA_SEQ, p->data_seq); if (p->reorder_timeout) addattr64(&req.n, 1024, L2TP_ATTR_RECV_TIMEOUT, p->reorder_timeout); @@ -359,8 +356,6 @@ static int get_response(struct nlmsghdr *n, void *arg) p->pw_type = rta_getattr_u16(attrs[L2TP_ATTR_PW_TYPE]); if (attrs[L2TP_ATTR_ENCAP_TYPE]) p->encap = rta_getattr_u16(attrs[L2TP_ATTR_ENCAP_TYPE]); - if (attrs[L2TP_ATTR_DATA_SEQ]) - p->data_seq = rta_getattr_u16(attrs[L2TP_ATTR_DATA_SEQ]); if (attrs[L2TP_ATTR_CONN_ID]) p->tunnel_id = rta_getattr_u32(attrs[L2TP_ATTR_CONN_ID]); if (attrs[L2TP_ATTR_PEER_CONN_ID]) -- 2.18.0