From: Bart Van Assche <bvanassche@acm.org>
To: j-young.choi@samsung.com, ALIM AKHTAR <alim.akhtar@samsung.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"beanhuo@micron.com" <beanhuo@micron.com>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>
Subject: Re: [PATCH v6 3/6] scsi: ufs: wb: Add explicit flush sysfs attribute
Date: Wed, 3 Aug 2022 10:38:26 -0700 [thread overview]
Message-ID: <28b41877-2697-6bbb-066d-ee0f6e330565@acm.org> (raw)
In-Reply-To: <20220802080740epcms2p3893fd9cfb765d4addbbfe58c68cf5af3@epcms2p3>
On 8/2/22 01:07, Jinyoung CHOI wrote:
> +What: /sys/bus/platform/drivers/ufshcd/*/wb_buf_flush_en
> +What: /sys/bus/platform/devices/*.ufs/wb_buf_flush_en
> +Date: July 2022
> +Contact: Jinyoung Choi <j-young.choi@samsung.com>
> +Description: This entry shows the status of WriteBooster buffer flushing
Can we rename this attribute into something that has a word order that
is grammatically correct, e.g. enable_wb_buf_flush?
> + and it can be used to allow or disallow the flushing.
> + If the flushing is allowed, the device executes the flush
> + operation when the command queue is empty.
The attribute has "enabled" in its name while the above text uses the
verb "allowed". Consider changing "allowed" into "enabled". Please also
change "If the flushing" into "If flushing".
Thanks,
Bart.
next prev parent reply other threads:[~2022-08-03 17:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220802080146epcms2p24b86bfce3d3c09c79b91d861cb3b2cce@epcms2p2>
2022-08-02 8:01 ` [PATCH v6 0/6] scsi: ufs: wb: Add sysfs attribute and cleanup Jinyoung CHOI
[not found] ` <CGME20220802080146epcms2p24b86bfce3d3c09c79b91d861cb3b2cce@epcms2p3>
2022-08-02 8:03 ` [PATCH v6 1/6] scsi: ufs: wb: Change wb_enabled condition test Jinyoung CHOI
2022-08-02 8:07 ` [PATCH v6 3/6] scsi: ufs: wb: Add explicit flush sysfs attribute Jinyoung CHOI
2022-08-03 17:38 ` Bart Van Assche [this message]
[not found] ` <CGME20220802080146epcms2p24b86bfce3d3c09c79b91d861cb3b2cce@epcms2p8>
2022-08-02 8:05 ` [PATCH v6 2/6] scsi: ufs: wb: Change functions name and modify parameter name Jinyoung CHOI
2022-08-03 17:35 ` Bart Van Assche
2022-08-03 4:11 ` RE:(2) [PATCH v6 5/6] scsi: ufs: wb: Modify messages Jinyoung CHOI
2022-08-03 5:34 ` (2) " Stanley Chu
[not found] ` <CGME20220802080146epcms2p24b86bfce3d3c09c79b91d861cb3b2cce@epcms2p4>
2022-08-03 6:07 ` Jinyoung CHOI
[not found] ` <CGME20220802080146epcms2p24b86bfce3d3c09c79b91d861cb3b2cce@epcms2p6>
2022-08-02 8:10 ` [PATCH v6 6/6] scsi: ufs: wb: Move the comment to the right position Jinyoung CHOI
2022-08-02 14:13 ` Stanley Chu
[not found] ` <CGME20220802080146epcms2p24b86bfce3d3c09c79b91d861cb3b2cce@epcms2p1>
2022-08-02 8:09 ` [PATCH v6 5/6] scsi: ufs: wb: Modify messages Jinyoung CHOI
2022-08-02 14:12 ` Stanley Chu
2022-08-04 5:49 ` RE:(2) [PATCH v6 3/6] scsi: ufs: wb: Add explicit flush sysfs attribute Jinyoung CHOI
2022-08-02 8:08 ` [PATCH v6 4/6] scsi: ufs: wb: Add ufshcd_is_wb_buf_flush_allowed() Jinyoung CHOI
2022-08-02 14:12 ` Stanley Chu
2022-08-03 17:39 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28b41877-2697-6bbb-066d-ee0f6e330565@acm.org \
--to=bvanassche@acm.org \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=j-young.choi@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.