From: Hannes Reinecke <hare@suse.de>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH] target: do not overwrite CDB byte 1
Date: Tue, 15 Oct 2019 05:59:06 +0000 [thread overview]
Message-ID: <28c6b43e-2f1c-e58e-2106-a28f941e2ecd@suse.de> (raw)
In-Reply-To: <12498eab-76fd-eaad-1316-c2827badb76a@ts.fujitsu.com>
On 10/14/19 8:29 PM, Bodo Stroesser wrote:
> passthrough_parse_cdb() - used by TCMU and PSCSI - attepts to
> reset the LUN field of SCSI-2 CDBs (bits 5,6,7 of byte 1).
> The current code is wrong, as for newer commands not having the
> LUN field it overwrites relevant command bits (e.g. for SECURITY
> PROTOCOL IN / OUT)
> We think this code was unnecessary from the beginning or at least
> it is no longer useful. So we remove it entirely.
>
> Signed-off-by: Bodo Stroesser <bstroesser@ts.fujitsu.com>
> ---
> drivers/target/target_core_device.c | 21 ---------------------
> 1 file changed, 21 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 247165 (AG München), GF: Felix Imendörffer
next prev parent reply other threads:[~2019-10-15 5:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 18:29 [PATCH] target: do not overwrite CDB byte 1 Bodo Stroesser
2019-10-14 21:51 ` Bart Van Assche
2019-10-15 5:59 ` Hannes Reinecke [this message]
2019-10-18 1:41 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28c6b43e-2f1c-e58e-2106-a28f941e2ecd@suse.de \
--to=hare@suse.de \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.