From: Trond Myklebust <trondmy@hammerspace.com>
To: "chuck.lever@oracle.com" <chuck.lever@oracle.com>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] NFS: Fix memory allocation in rpc_malloc()
Date: Tue, 15 Mar 2022 17:00:07 +0000 [thread overview]
Message-ID: <28c7dd1e84d3011cb2d88c015e65e9bbeab280e9.camel@hammerspace.com> (raw)
In-Reply-To: <74453705-B296-4992-921B-68D287ECA4D1@oracle.com>
On Tue, 2022-03-15 at 16:50 +0000, Chuck Lever III wrote:
>
>
> > On Mar 15, 2022, at 12:20 PM, trondmy@kernel.org wrote:
> >
> > From: Trond Myklebust <trond.myklebust@hammerspace.com>
> >
> > When allocating memory, it should be safe to always use GFP_KERNEL,
> > since both swap tasks and asynchronous tasks will regulate the
> > allocation mode through the struct task flags.
>
> Is a similar change necessary in xprt_rdma_allocate() ?
It looks to me as if that would be a safe change, and we should
probably also change that definition of RPCRDMA_DEF_GFP to match
GFP_KERNEL.
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
next prev parent reply other threads:[~2022-03-15 17:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 16:20 [PATCH] NFS: Fix memory allocation in rpc_malloc() trondmy
2022-03-15 16:50 ` Chuck Lever III
2022-03-15 17:00 ` Trond Myklebust [this message]
2022-03-16 1:53 ` NeilBrown
2022-03-16 13:47 ` Trond Myklebust
2022-03-18 5:04 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28c7dd1e84d3011cb2d88c015e65e9bbeab280e9.camel@hammerspace.com \
--to=trondmy@hammerspace.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.