From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick DELAUNAY Date: Tue, 27 Nov 2018 08:06:36 +0000 Subject: [U-Boot] [PATCH v2 1/2] spl_spi: Read default speed and mode values from DT In-Reply-To: <7828272b-a824-d56f-9e46-159d7d959859@gmail.com> References: <1542648790-21362-1-git-send-email-patrick.delaunay@st.com> <1542648790-21362-2-git-send-email-patrick.delaunay@st.com> <7828272b-a824-d56f-9e46-159d7d959859@gmail.com> Message-ID: <28c7e7892f2a4b09b9ec5f3a4039716e@SFHDAG6NODE3.st.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, > -----Original Message----- > From: Simon Goldschmidt > Sent: lundi 19 novembre 2018 20:09 > > On 19.11.2018 18:33, Patrick Delaunay wrote: > > In case of DT boot, don't read default speed and mode for SPI from > > CONFIG_*, instead read from DT node. > > > > Signed-off-by: Christophe Kerello > > Signed-off-by: Patrick Delaunay > > I was commenting about code duplication, which is better now, so: > > Reviewed-by: Simon Goldschmidt > > I do think it would be nice to invert the logic. That way, we could get completely > rid of those two CONFIG_SF_DEFAULT settings for DM_SPI_FLASH boards (and > eventually for all boards - when's the deadline for that?). > But there are other places that still do it like you do here, so it's probably better > to change them all at once... Agree with you. In fact I hesitate with directly change the header file #ifdef CONFIG_DM_SPI_FLASH /* In DM mode defaults will be taken from DT */ #define CONFIG_SF_DEFAULT_SPEED 0 #define CONFIG_SF_DEFAULT_MODE 0 #endif But I am afraid of the potential impacts (define is used in many boards), but I think it sould be more cleaner way to force the expected behavior. Patrick > Simon >