From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Dooks Subject: Re: [alsa-devel] [Linux-kernel] [PATCH v5 2/7] ASoC: tegra: Allow 24bit and 32bit samples Date: Thu, 23 Jan 2020 19:38:37 +0000 Message-ID: <28cafc56-095b-68c6-638d-270608a2983f@codethink.co.uk> References: <20191018154833.7560-1-ben.dooks@codethink.co.uk> <621fa27d-9259-2949-9cf5-d2eda5cb0677@gmail.com> <449bdc3c-bf82-7cc4-6704-440dd100ca3a@gmail.com> <5d3ae629-5d30-0930-5dd1-15161e64926e@codethink.co.uk> <9daeeb94-2b90-18b8-2e1e-daae5acf079d@gmail.com> <37beb96a-a525-c72f-a7e1-e9ef5d61f3b2@gmail.com> <29db3df4-6f51-7c0f-1eef-90171f1d233a@codethink.co.uk> <9a5447e2-155c-7e6e-b8f1-95523c6f42c6@gmail.com> <680e2dfd-6f4f-5c96-63b7-97520961dc82@gmail.com> <0e0cd260e39ad293edb881da1c565510@codethink.co.uk> <507dcd5a-672b-61ac-aa7f-af5ff01accff@codethink.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-GB Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Osipenko Cc: linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, Liam Girdwood , Takashi Iwai , Mark Brown , Thierry Reding , Edward Cragg , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jon Hunter List-Id: linux-tegra@vger.kernel.org On 07/01/2020 01:39, Dmitry Osipenko wrote: > 06.01.2020 22:00, Ben Dooks пишет: >> On 05/01/2020 10:53, Ben Dooks wrote: >>> >>> >>> On 2020-01-05 01:48, Dmitry Osipenko wrote: >>>> 05.01.2020 03:04, Ben Dooks пишет: >>>>> [snip] >>>>> >>>>> I've just gone through testing. >>>>> >>>>> Some simple data tests show 16 and 32-bits work. >>>>> >>>>> The 24 bit case seems to be weird, it looks like the 24-bit expects >>>>> 24 bit samples in 32 bit words. I can't see any packing options to >>>>> do 24 bit in 24 bit, so we may have to remove 24 bit sample support >>>>> (which is a shame) >>>>> >>>>> My preference is to remove the 24-bit support and keep the 32 bit in. >>>>> >>>> >>>> Interesting.. Jon, could you please confirm that 24bit format isn't >>>> usable on T30? >>> >>> If there is an option of 24 packed into 32, then I think that would work. >>> >>> I can try testing that with raw data on Monday. >> >> I need to check some things, I assumed 24 was 24 packed bits, it looks >> like the default is 24 in 32 bits so we may be ok. However I need to >> re-write my test case which assumed it was 24bits in 3 bytes (S24_3LE). >> >> I'll follow up later, > > Okay, the S24_3LE isn't supported by RT5640 codec in my case. I briefly > looked through the TRM doc and got impression that AHUB could re-pack > data stream into something that codec supports, but maybe it's a wrong > impression. > _________________________________ I did a quick test with the following: sox -n -b 16 -c 2 -r 44100 /tmp/tmp.wav synth sine 500 vol 0.5 sox -n -b 24 -c 2 -r 44100 /tmp/tmp.wav synth sine 500 vol 0.5 sox -n -b 32 -c 2 -r 44100 /tmp/tmp.wav synth sine 500 vol 0.5 The 16 and 32 work fine, the 24 is showing a playback output freq of 440Hz instead of 500Hz... this suggests the clock is off, or there is something else weird going on... -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0B8CC2D0DB for ; Thu, 23 Jan 2020 19:39:48 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 748FD21D7D for ; Thu, 23 Jan 2020 19:39:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="ip0g6jiC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 748FD21D7D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=codethink.co.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C2528166B; Thu, 23 Jan 2020 20:38:56 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C2528166B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1579808386; bh=F2pF/8tM1dCcKUqcndlymlTj/rt5lKP/8EA+RUahqRU=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ip0g6jiCT5aGZjCqDFrGl3vfmpmvSEyc+7bumzVian4l9mHhqfUg/XCIdXRCsLjRG ObiICiVTTwBVsNLvWuov+k0HmWV04AZX20HwX/XCPKcy0TZSYN8lrEXsSsEbWDkIFe vuX+nCWnnJyXhbUm8QgcyzGDPZVj1E9/aX1KCo4w= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 06B18F8015B; Thu, 23 Jan 2020 20:38:56 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 156C5F801D9; Thu, 23 Jan 2020 20:38:55 +0100 (CET) Received: from imap2.colo.codethink.co.uk (imap2.colo.codethink.co.uk [78.40.148.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 61654F80112 for ; Thu, 23 Jan 2020 20:38:51 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 61654F80112 Received: from [167.98.27.226] (helo=[10.35.5.173]) by imap2.colo.codethink.co.uk with esmtpsa (Exim 4.92 #3 (Debian)) id 1iuiJL-0002aX-3C; Thu, 23 Jan 2020 19:38:39 +0000 To: Dmitry Osipenko References: <20191018154833.7560-1-ben.dooks@codethink.co.uk> <621fa27d-9259-2949-9cf5-d2eda5cb0677@gmail.com> <449bdc3c-bf82-7cc4-6704-440dd100ca3a@gmail.com> <5d3ae629-5d30-0930-5dd1-15161e64926e@codethink.co.uk> <9daeeb94-2b90-18b8-2e1e-daae5acf079d@gmail.com> <37beb96a-a525-c72f-a7e1-e9ef5d61f3b2@gmail.com> <29db3df4-6f51-7c0f-1eef-90171f1d233a@codethink.co.uk> <9a5447e2-155c-7e6e-b8f1-95523c6f42c6@gmail.com> <680e2dfd-6f4f-5c96-63b7-97520961dc82@gmail.com> <0e0cd260e39ad293edb881da1c565510@codethink.co.uk> <507dcd5a-672b-61ac-aa7f-af5ff01accff@codethink.co.uk> From: Ben Dooks Organization: Codethink Limited. Message-ID: <28cafc56-095b-68c6-638d-270608a2983f@codethink.co.uk> Date: Thu, 23 Jan 2020 19:38:37 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB Cc: linux-kernel@lists.codethink.co.uk, alsa-devel@alsa-project.org, Liam Girdwood , Takashi Iwai , Mark Brown , Thierry Reding , Edward Cragg , linux-tegra@vger.kernel.org, Jon Hunter Subject: Re: [alsa-devel] [Linux-kernel] [PATCH v5 2/7] ASoC: tegra: Allow 24bit and 32bit samples X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" T24gMDcvMDEvMjAyMCAwMTozOSwgRG1pdHJ5IE9zaXBlbmtvIHdyb3RlOgo+IDA2LjAxLjIwMjAg MjI6MDAsIEJlbiBEb29rcyDQv9C40YjQtdGCOgo+PiBPbiAwNS8wMS8yMDIwIDEwOjUzLCBCZW4g RG9va3Mgd3JvdGU6Cj4+Pgo+Pj4KPj4+IE9uIDIwMjAtMDEtMDUgMDE6NDgsIERtaXRyeSBPc2lw ZW5rbyB3cm90ZToKPj4+PiAwNS4wMS4yMDIwIDAzOjA0LCBCZW4gRG9va3Mg0L/QuNGI0LXRgjoK Pj4+Pj4gW3NuaXBdCj4+Pj4+Cj4+Pj4+IEkndmUganVzdCBnb25lIHRocm91Z2ggdGVzdGluZy4K Pj4+Pj4KPj4+Pj4gU29tZSBzaW1wbGUgZGF0YSB0ZXN0cyBzaG93IDE2IGFuZCAzMi1iaXRzIHdv cmsuCj4+Pj4+Cj4+Pj4+IFRoZSAyNCBiaXQgY2FzZSBzZWVtcyB0byBiZSB3ZWlyZCwgaXQgbG9v a3MgbGlrZSB0aGUgMjQtYml0IGV4cGVjdHMKPj4+Pj4gMjQgYml0IHNhbXBsZXMgaW4gMzIgYml0 IHdvcmRzLiBJIGNhbid0IHNlZSBhbnkgcGFja2luZyBvcHRpb25zIHRvCj4+Pj4+IGRvIDI0IGJp dCBpbiAyNCBiaXQsIHNvIHdlIG1heSBoYXZlIHRvIHJlbW92ZSAyNCBiaXQgc2FtcGxlIHN1cHBv cnQKPj4+Pj4gKHdoaWNoIGlzIGEgc2hhbWUpCj4+Pj4+Cj4+Pj4+IE15IHByZWZlcmVuY2UgaXMg dG8gcmVtb3ZlIHRoZSAyNC1iaXQgc3VwcG9ydCBhbmQga2VlcCB0aGUgMzIgYml0IGluLgo+Pj4+ Pgo+Pj4+Cj4+Pj4gSW50ZXJlc3RpbmcuLiBKb24sIGNvdWxkIHlvdSBwbGVhc2UgY29uZmlybSB0 aGF0IDI0Yml0IGZvcm1hdCBpc24ndAo+Pj4+IHVzYWJsZSBvbiBUMzA/Cj4+Pgo+Pj4gSWYgdGhl cmUgaXMgYW4gb3B0aW9uIG9mIDI0IHBhY2tlZCBpbnRvIDMyLCB0aGVuIEkgdGhpbmsgdGhhdCB3 b3VsZCB3b3JrLgo+Pj4KPj4+IEkgY2FuIHRyeSB0ZXN0aW5nIHRoYXQgd2l0aCByYXcgZGF0YSBv biBNb25kYXkuCj4+Cj4+IEkgbmVlZCB0byBjaGVjayBzb21lIHRoaW5ncywgSSBhc3N1bWVkIDI0 IHdhcyAyNCBwYWNrZWQgYml0cywgaXQgbG9va3MKPj4gbGlrZSB0aGUgZGVmYXVsdCBpcyAyNCBp biAzMiBiaXRzIHNvIHdlIG1heSBiZSBvay4gSG93ZXZlciBJIG5lZWQgdG8KPj4gcmUtd3JpdGUg bXkgdGVzdCBjYXNlIHdoaWNoIGFzc3VtZWQgaXQgd2FzIDI0Yml0cyBpbiAzIGJ5dGVzIChTMjRf M0xFKS4KPj4KPj4gSSdsbCBmb2xsb3cgdXAgbGF0ZXIsCj4gCj4gT2theSwgdGhlIFMyNF8zTEUg aXNuJ3Qgc3VwcG9ydGVkIGJ5IFJUNTY0MCBjb2RlYyBpbiBteSBjYXNlLiBJIGJyaWVmbHkKPiBs b29rZWQgdGhyb3VnaCB0aGUgVFJNIGRvYyBhbmQgZ290IGltcHJlc3Npb24gdGhhdCBBSFVCIGNv dWxkIHJlLXBhY2sKPiBkYXRhIHN0cmVhbSBpbnRvIHNvbWV0aGluZyB0aGF0IGNvZGVjIHN1cHBv cnRzLCBidXQgbWF5YmUgaXQncyBhIHdyb25nCj4gaW1wcmVzc2lvbi4KPiBfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KCkkgZGlkIGEgcXVpY2sgdGVzdCB3aXRoIHRoZSBmb2xsb3dp bmc6CgogIHNveCAtbiAtYiAxNiAtYyAyIC1yIDQ0MTAwIC90bXAvdG1wLndhdiAgc3ludGggc2lu ZSA1MDAgdm9sIDAuNQogIHNveCAtbiAtYiAyNCAtYyAyIC1yIDQ0MTAwIC90bXAvdG1wLndhdiAg c3ludGggc2luZSA1MDAgdm9sIDAuNQogIHNveCAtbiAtYiAzMiAtYyAyIC1yIDQ0MTAwIC90bXAv dG1wLndhdiAgc3ludGggc2luZSA1MDAgdm9sIDAuNQoKVGhlIDE2IGFuZCAzMiB3b3JrIGZpbmUs IHRoZSAyNCBpcyBzaG93aW5nIGEgcGxheWJhY2sgb3V0cHV0IGZyZXEKb2YgNDQwSHogaW5zdGVh ZCBvZiA1MDBIei4uLiB0aGlzIHN1Z2dlc3RzIHRoZSBjbG9jayBpcyBvZmYsIG9yIHRoZXJlCmlz IHNvbWV0aGluZyBlbHNlIHdlaXJkIGdvaW5nIG9uLi4uCgotLSAKQmVuIERvb2tzCQkJCWh0dHA6 Ly93d3cuY29kZXRoaW5rLmNvLnVrLwpTZW5pb3IgRW5naW5lZXIJCQkJQ29kZXRoaW5rIC0gUHJv dmlkaW5nIEdlbml1cwoKaHR0cHM6Ly93d3cuY29kZXRoaW5rLmNvLnVrL3ByaXZhY3kuaHRtbApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBbHNhLWRldmVs IG1haWxpbmcgbGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0cHM6Ly9tYWlsbWFu LmFsc2EtcHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbHNhLWRldmVsCg==