From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12F0FC433EF for ; Thu, 20 Jan 2022 02:40:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232181AbiATCkk (ORCPT ); Wed, 19 Jan 2022 21:40:40 -0500 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]:49084 "EHLO out30-43.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230154AbiATCki (ORCPT ); Wed, 19 Jan 2022 21:40:38 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04407;MF=xueshuai@linux.alibaba.com;NM=1;PH=DS;RN=14;SR=0;TI=SMTPD_---0V2JaG8J_1642646431; Received: from 30.240.112.67(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0V2JaG8J_1642646431) by smtp.aliyun-inc.com(127.0.0.1); Thu, 20 Jan 2022 10:40:33 +0800 Message-ID: <28d484ac-23e2-698b-762b-cd0c8b220570@linux.alibaba.com> Date: Thu, 20 Jan 2022 10:40:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v5] ACPI: Move sdei_init and ghes_init ahead to handle platform errors earlier Content-Language: en-US To: Bjorn Helgaas Cc: "Rafael J. Wysocki" , bp@alien8.de, tony.luck@intel.com, james.morse@arm.com, lenb@kernel.org, rjw@rjwysocki.net, bhelgaas@google.com, zhangliguang@linux.alibaba.com, zhuo.song@linux.alibaba.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org References: <20220119204259.GA962224@bhelgaas> From: Shuai Xue In-Reply-To: <20220119204259.GA962224@bhelgaas> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi, Bjorn, Thank you for your valuable comments. 在 2022/1/20 AM4:42, Bjorn Helgaas 写道: > On Wed, Jan 19, 2022 at 02:40:11PM +0800, Shuai Xue wrote: >> [+to Rafael, question about HEST/GHES/SDEI init] >> >> Hi, Bjorn, >> >> Thank you for your comments and quick reply. >> >> 在 2022/1/19 AM6:49, Bjorn Helgaas 写道: >>> On Sun, Jan 16, 2022 at 04:43:10PM +0800, Shuai Xue wrote: >>>> On an ACPI system, ACPI is initialised very early from a >>>> subsys_initcall(), while SDEI is not ready until a >>>> subsys_initcall_sync(). This patch is to reduce the time before GHES >>>> initialization. >>>> >>>> The SDEI driver provides functions (e.g. apei_sdei_register_ghes(), >>>> apei_sdei_unregister_ghes()) to register or unregister event callback >>>> for dispatcher in firmware. When the GHES driver probing, it registers >>>> the corresponding callback according to the notification type specified >>>> by GHES. If the GHES notification type is SDEI, the GHES driver will >>>> call apei_sdei_register_ghes() to register event call. >>>> >>>> When the firmware emits an event, it migrates the handling of the event >>>> into the kernel at the registered entry-point __sdei_asm_handler. And >>>> finally, the kernel will call the registered event callback and return >>>> status_code to indicate the status of event handling. SDEI_EV_FAILED >>>> indicates that the kernel failed to handle the event. >>>> >>>> Consequently, when an error occurs during kernel booting, the kernel is >>>> unable to handle and report errors until the GHES driver is initialized >>>> by device_initcall(), in which the event callback is registered. For >>>> example, when the kernel booting, the console logs many times from >>>> firmware before GHES drivers init in our platform: >>>> >>>> Trip in MM PCIe RAS handle(Intr:910) >>>> Clean PE[1.1.1] ERR_STS:0x4000100 -> 0 INT_STS:F0000000 >>>> Find RP(98:1.0) >>>> --Walk dev(98:1.0) CE:0 UCE:4000 >>>> ... >>>> ERROR: sdei_dispatch_event(32a) ret:-1 >>>> --handler(910) end >>> >>> If I understand correctly, the firmware noticed an error, tried to >>> report it to the kernel, and is complaining because the kernel isn't >>> ready to handle it yet. And the reason for this patch is to reduce >>> these complaints from the firmware. >> >> My thoughts exactly :) >> >>> That doesn't seem like a very good reason for this patch. There is >>> *always* a window before the kernel is ready to handle events from the >>> firmware. >> >> Yes, there is always a window. But if we could do better in kernel that >> reduces the window by 90% (from 33 seconds to 3 second), why not? >> >>> Why is the firmware noticing these errors in the first place? If >>> you're seeing these complaints regularly, my guess is that either you >>> have some terrible hardware or (more likely) the firmware isn't >>> clearing some expected error condition correctly. For example, maybe >>> the Unsupported Request errors that happen while enumerating PCIe >>> devices are being reported. >>> >>> If you register the callback function, the kernel will now start >>> seeing these error reports. What happens then? Does the kernel log >>> the errors somewhere? Is that better than the current situation where >>> the firmware logs them? >> >> Yep, it is a hardware issue. The firmware only logs in console >> (ttyAMA0) and we can not see it in kernel side. After the kernel >> starts seeing these error reports, we could see EDAC/ghes and >> efi/cper detailed logs in dmesg. We did not notice the problem until >> we check the console log, which inspired us to reduce the window >> when kernel startup, so that we can see the message clearly and >> properly. I think the intuition is to check the log of dmesg, not >> the console. > >>> However, I DO think that: >>> >>> - Removing acpi_hest_init() from acpi_pci_root_init(), and >>> >>> - Converting ghes_init() and sdei_init() from initcalls to explicit >>> calls >>> >>> are very good reasons to do something like this patch because HEST is >>> not PCI-specific, and IMO, explicit calls are better than initcalls >>> because initcall ordering is implicit and not well-defined within a >>> level. >> >> Haha, if the above reasons still don't convince you, I would like to >> accept yours :) Should we do it in one patch or separate it into two >> patches? > > IMO, this can be done in one patch, but this would probably go via > Rafael. Got it, I will send a new patch and cc to Rafael. >>>> -static int __init ghes_init(void) >>>> +void __init ghes_init(void) >>>> { >>>> int rc; >>>> >>>> if (acpi_disabled) >>>> - return -ENODEV; >>>> + return; >>>> >>>> switch (hest_disable) { >>>> case HEST_NOT_FOUND: >>>> - return -ENODEV; >>>> + pr_info(GHES_PFX "HEST is not found!\n"); >>> >>> I don't know whether this "HEST is not found" message is >>> worthwhile or not. I don't think lack of an HEST is an error, and >>> users may be alarmed. But this is an ACPI thing, so up to you and >>> Rafael. >> >> If we explicit call ghes_init(), we can't tell if ghes is >> initialized successfully based on the return value of initcall. So I >> add a info message. > > When ghes_init() is an initcall and you return -ENODEV for the > HEST_NOT_FOUND case, I don't think we log any message about that, do > we? do_one_initcall() will capture and return the -ENODEV, but the > caller (do_initcall_level()) just ignores it. I see, thank you. I will delete it in next version. >>>> @@ -1495,8 +1494,7 @@ static int __init ghes_init(void) >>>> else >>>> pr_info(GHES_PFX "Failed to enable APEI firmware first mode.\n"); >>>> >>>> - return 0; >>>> + return; >>>> err: >>>> - return rc; >>>> + ghes_disable = 1; >>> >>> Why do you set ghes_disable here? As far as I can tell, we will never >>> look at it again. The places we do look at it are: >>> >>> - ghes_init(): earlier in this function, so we've already done that, >>> >>> - acpi_hest_init(): we've already called that, too, and >>> >>> - acpi_bus_osc_negotiate_platform_control(): called from >>> acpi_bus_init(), which we've already called. >> >> I add it for future potential usage. Thank you for pointing it out. >> If you think it is not necessary, I will delete it in next version. > > I think it is not necessary to save information that will never be > used. If you need it in the future, you can add it and the reason > will be obvious. > > Bjorn You are right. I will delete it. Best Regards, Shuai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 130A1C433EF for ; Thu, 20 Jan 2022 02:42:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O/CfoebOS8T9aZJJtg+oQkks43G6x+1o+be2R0s17rs=; b=E9qUOJ50pKDjIi K8y2dAHJuZNkLzmk5bWIjiRbf4irI7dV20IdnqRYfL01cOl1kXHu4oKmZ/xfHf+i+oBopkq3lTxDs RHVopaUmNOw3gX3fZrTUooXUQfWa0gfun7DPFrL8e0QAsqBzGYWWuxx6HK/L57nQxmgqEMbA3J/f5 LE58jGxyEbiHIJ2Pgw8VFFCA+DSyLNUQQdyO65kR5YP76Td1CqUcz7fMDpIn4mkwzJfs6fKwJ2GpG Y5CHs5QYIvstQMdJk3EX7Ei9MRlVmOH36XeZh/jpoAIymCWJZihhufBqkwYcqwzI0AvwUnda6geiA dOMNIntBvQvVPmhjFPMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nANNe-008Kqx-9E; Thu, 20 Jan 2022 02:40:54 +0000 Received: from out4436.biz.mail.alibaba.com ([47.88.44.36]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nANNZ-008KqL-Nh for linux-arm-kernel@lists.infradead.org; Thu, 20 Jan 2022 02:40:52 +0000 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R121e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e04407; MF=xueshuai@linux.alibaba.com; NM=1; PH=DS; RN=14; SR=0; TI=SMTPD_---0V2JaG8J_1642646431; Received: from 30.240.112.67(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0V2JaG8J_1642646431) by smtp.aliyun-inc.com(127.0.0.1); Thu, 20 Jan 2022 10:40:33 +0800 Message-ID: <28d484ac-23e2-698b-762b-cd0c8b220570@linux.alibaba.com> Date: Thu, 20 Jan 2022 10:40:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v5] ACPI: Move sdei_init and ghes_init ahead to handle platform errors earlier Content-Language: en-US To: Bjorn Helgaas Cc: "Rafael J. Wysocki" , bp@alien8.de, tony.luck@intel.com, james.morse@arm.com, lenb@kernel.org, rjw@rjwysocki.net, bhelgaas@google.com, zhangliguang@linux.alibaba.com, zhuo.song@linux.alibaba.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org References: <20220119204259.GA962224@bhelgaas> From: Shuai Xue In-Reply-To: <20220119204259.GA962224@bhelgaas> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220119_184049_950129_8E864D96 X-CRM114-Status: GOOD ( 41.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksIEJqb3JuLAoKVGhhbmsgeW91IGZvciB5b3VyIHZhbHVhYmxlIGNvbW1lbnRzLgoK5ZyoIDIw MjIvMS8yMCBBTTQ6NDIsIEJqb3JuIEhlbGdhYXMg5YaZ6YGTOgo+IE9uIFdlZCwgSmFuIDE5LCAy MDIyIGF0IDAyOjQwOjExUE0gKzA4MDAsIFNodWFpIFh1ZSB3cm90ZToKPj4gWyt0byBSYWZhZWws IHF1ZXN0aW9uIGFib3V0IEhFU1QvR0hFUy9TREVJIGluaXRdCj4+Cj4+IEhpLCBCam9ybiwKPj4K Pj4gVGhhbmsgeW91IGZvciB5b3VyIGNvbW1lbnRzIGFuZCBxdWljayByZXBseS4KPj4KPj4g5Zyo IDIwMjIvMS8xOSBBTTY6NDksIEJqb3JuIEhlbGdhYXMg5YaZ6YGTOgo+Pj4gT24gU3VuLCBKYW4g MTYsIDIwMjIgYXQgMDQ6NDM6MTBQTSArMDgwMCwgU2h1YWkgWHVlIHdyb3RlOgo+Pj4+IE9uIGFu IEFDUEkgc3lzdGVtLCBBQ1BJIGlzIGluaXRpYWxpc2VkIHZlcnkgZWFybHkgZnJvbSBhCj4+Pj4g c3Vic3lzX2luaXRjYWxsKCksIHdoaWxlIFNERUkgaXMgbm90IHJlYWR5IHVudGlsIGEKPj4+PiBz dWJzeXNfaW5pdGNhbGxfc3luYygpLiBUaGlzIHBhdGNoIGlzIHRvIHJlZHVjZSB0aGUgdGltZSBi ZWZvcmUgR0hFUwo+Pj4+IGluaXRpYWxpemF0aW9uLgo+Pj4+Cj4+Pj4gVGhlIFNERUkgZHJpdmVy IHByb3ZpZGVzIGZ1bmN0aW9ucyAoZS5nLiBhcGVpX3NkZWlfcmVnaXN0ZXJfZ2hlcygpLAo+Pj4+ IGFwZWlfc2RlaV91bnJlZ2lzdGVyX2doZXMoKSkgdG8gcmVnaXN0ZXIgb3IgdW5yZWdpc3RlciBl dmVudCBjYWxsYmFjawo+Pj4+IGZvciBkaXNwYXRjaGVyIGluIGZpcm13YXJlLiBXaGVuIHRoZSBH SEVTIGRyaXZlciBwcm9iaW5nLCBpdCByZWdpc3RlcnMKPj4+PiB0aGUgY29ycmVzcG9uZGluZyBj YWxsYmFjayBhY2NvcmRpbmcgdG8gdGhlIG5vdGlmaWNhdGlvbiB0eXBlIHNwZWNpZmllZAo+Pj4+ IGJ5IEdIRVMuIElmIHRoZSBHSEVTIG5vdGlmaWNhdGlvbiB0eXBlIGlzIFNERUksIHRoZSBHSEVT IGRyaXZlciB3aWxsCj4+Pj4gY2FsbCBhcGVpX3NkZWlfcmVnaXN0ZXJfZ2hlcygpIHRvIHJlZ2lz dGVyIGV2ZW50IGNhbGwuCj4+Pj4KPj4+PiBXaGVuIHRoZSBmaXJtd2FyZSBlbWl0cyBhbiBldmVu dCwgaXQgbWlncmF0ZXMgdGhlIGhhbmRsaW5nIG9mIHRoZSBldmVudAo+Pj4+IGludG8gdGhlIGtl cm5lbCBhdCB0aGUgcmVnaXN0ZXJlZCBlbnRyeS1wb2ludCBfX3NkZWlfYXNtX2hhbmRsZXIuIEFu ZAo+Pj4+IGZpbmFsbHksIHRoZSBrZXJuZWwgd2lsbCBjYWxsIHRoZSByZWdpc3RlcmVkIGV2ZW50 IGNhbGxiYWNrIGFuZCByZXR1cm4KPj4+PiBzdGF0dXNfY29kZSB0byBpbmRpY2F0ZSB0aGUgc3Rh dHVzIG9mIGV2ZW50IGhhbmRsaW5nLiBTREVJX0VWX0ZBSUxFRAo+Pj4+IGluZGljYXRlcyB0aGF0 IHRoZSBrZXJuZWwgZmFpbGVkIHRvIGhhbmRsZSB0aGUgZXZlbnQuCj4+Pj4KPj4+PiBDb25zZXF1 ZW50bHksIHdoZW4gYW4gZXJyb3Igb2NjdXJzIGR1cmluZyBrZXJuZWwgYm9vdGluZywgdGhlIGtl cm5lbCBpcwo+Pj4+IHVuYWJsZSB0byBoYW5kbGUgYW5kIHJlcG9ydCBlcnJvcnMgdW50aWwgdGhl IEdIRVMgZHJpdmVyIGlzIGluaXRpYWxpemVkCj4+Pj4gYnkgZGV2aWNlX2luaXRjYWxsKCksIGlu IHdoaWNoIHRoZSBldmVudCBjYWxsYmFjayBpcyByZWdpc3RlcmVkLiAgRm9yCj4+Pj4gZXhhbXBs ZSwgd2hlbiB0aGUga2VybmVsIGJvb3RpbmcsIHRoZSBjb25zb2xlIGxvZ3MgbWFueSB0aW1lcyBm cm9tCj4+Pj4gZmlybXdhcmUgYmVmb3JlIEdIRVMgZHJpdmVycyBpbml0IGluIG91ciBwbGF0Zm9y bToKPj4+Pgo+Pj4+IAlUcmlwIGluIE1NIFBDSWUgUkFTIGhhbmRsZShJbnRyOjkxMCkKPj4+PiAg IAlDbGVhbiBQRVsxLjEuMV0gRVJSX1NUUzoweDQwMDAxMDAgLT4gMCBJTlRfU1RTOkYwMDAwMDAw Cj4+Pj4gCUZpbmQgUlAoOTg6MS4wKQo+Pj4+IAktLVdhbGsgZGV2KDk4OjEuMCkgQ0U6MCBVQ0U6 NDAwMAo+Pj4+IAkuLi4KPj4+PiAJRVJST1I6ICAgc2RlaV9kaXNwYXRjaF9ldmVudCgzMmEpIHJl dDotMQo+Pj4+IAktLWhhbmRsZXIoOTEwKSBlbmQKPj4+Cj4+PiBJZiBJIHVuZGVyc3RhbmQgY29y cmVjdGx5LCB0aGUgZmlybXdhcmUgbm90aWNlZCBhbiBlcnJvciwgdHJpZWQgdG8KPj4+IHJlcG9y dCBpdCB0byB0aGUga2VybmVsLCBhbmQgaXMgY29tcGxhaW5pbmcgYmVjYXVzZSB0aGUga2VybmVs IGlzbid0Cj4+PiByZWFkeSB0byBoYW5kbGUgaXQgeWV0LiAgQW5kIHRoZSByZWFzb24gZm9yIHRo aXMgcGF0Y2ggaXMgdG8gcmVkdWNlCj4+PiB0aGVzZSBjb21wbGFpbnRzIGZyb20gdGhlIGZpcm13 YXJlLgo+Pgo+PiBNeSB0aG91Z2h0cyBleGFjdGx5IDopCj4+Cj4+PiBUaGF0IGRvZXNuJ3Qgc2Vl bSBsaWtlIGEgdmVyeSBnb29kIHJlYXNvbiBmb3IgdGhpcyBwYXRjaC4gIFRoZXJlIGlzCj4+PiAq YWx3YXlzKiBhIHdpbmRvdyBiZWZvcmUgdGhlIGtlcm5lbCBpcyByZWFkeSB0byBoYW5kbGUgZXZl bnRzIGZyb20gdGhlCj4+PiBmaXJtd2FyZS4KPj4KPj4gWWVzLCB0aGVyZSBpcyBhbHdheXMgYSB3 aW5kb3cuIEJ1dCBpZiB3ZSBjb3VsZCBkbyBiZXR0ZXIgaW4ga2VybmVsIHRoYXQKPj4gcmVkdWNl cyB0aGUgd2luZG93IGJ5IDkwJSAoZnJvbSAzMyBzZWNvbmRzIHRvIDMgc2Vjb25kKSwgd2h5IG5v dD8KPj4KPj4+IFdoeSBpcyB0aGUgZmlybXdhcmUgbm90aWNpbmcgdGhlc2UgZXJyb3JzIGluIHRo ZSBmaXJzdCBwbGFjZT8gIElmCj4+PiB5b3UncmUgc2VlaW5nIHRoZXNlIGNvbXBsYWludHMgcmVn dWxhcmx5LCBteSBndWVzcyBpcyB0aGF0IGVpdGhlciB5b3UKPj4+IGhhdmUgc29tZSB0ZXJyaWJs ZSBoYXJkd2FyZSBvciAobW9yZSBsaWtlbHkpIHRoZSBmaXJtd2FyZSBpc24ndAo+Pj4gY2xlYXJp bmcgc29tZSBleHBlY3RlZCBlcnJvciBjb25kaXRpb24gY29ycmVjdGx5LiAgRm9yIGV4YW1wbGUs IG1heWJlCj4+PiB0aGUgVW5zdXBwb3J0ZWQgUmVxdWVzdCBlcnJvcnMgdGhhdCBoYXBwZW4gd2hp bGUgZW51bWVyYXRpbmcgUENJZQo+Pj4gZGV2aWNlcyBhcmUgYmVpbmcgcmVwb3J0ZWQuCj4+Pgo+ Pj4gSWYgeW91IHJlZ2lzdGVyIHRoZSBjYWxsYmFjayBmdW5jdGlvbiwgdGhlIGtlcm5lbCB3aWxs IG5vdyBzdGFydAo+Pj4gc2VlaW5nIHRoZXNlIGVycm9yIHJlcG9ydHMuICBXaGF0IGhhcHBlbnMg dGhlbj8gIERvZXMgdGhlIGtlcm5lbCBsb2cKPj4+IHRoZSBlcnJvcnMgc29tZXdoZXJlPyAgSXMg dGhhdCBiZXR0ZXIgdGhhbiB0aGUgY3VycmVudCBzaXR1YXRpb24gd2hlcmUKPj4+IHRoZSBmaXJt d2FyZSBsb2dzIHRoZW0/Cj4+Cj4+IFllcCwgaXQgaXMgYSBoYXJkd2FyZSBpc3N1ZS4gVGhlIGZp cm13YXJlIG9ubHkgbG9ncyBpbiBjb25zb2xlCj4+ICh0dHlBTUEwKSBhbmQgd2UgY2FuIG5vdCBz ZWUgaXQgaW4ga2VybmVsIHNpZGUuIEFmdGVyIHRoZSBrZXJuZWwKPj4gc3RhcnRzIHNlZWluZyB0 aGVzZSBlcnJvciByZXBvcnRzLCB3ZSBjb3VsZCBzZWUgRURBQy9naGVzIGFuZAo+PiBlZmkvY3Bl ciBkZXRhaWxlZCBsb2dzIGluIGRtZXNnLiBXZSBkaWQgbm90IG5vdGljZSB0aGUgcHJvYmxlbSB1 bnRpbAo+PiB3ZSBjaGVjayB0aGUgY29uc29sZSBsb2csIHdoaWNoIGluc3BpcmVkIHVzIHRvIHJl ZHVjZSB0aGUgd2luZG93Cj4+IHdoZW4ga2VybmVsIHN0YXJ0dXAsIHNvIHRoYXQgd2UgY2FuIHNl ZSB0aGUgbWVzc2FnZSBjbGVhcmx5IGFuZAo+PiBwcm9wZXJseS4gSSB0aGluayB0aGUgaW50dWl0 aW9uIGlzIHRvIGNoZWNrIHRoZSBsb2cgb2YgZG1lc2csIG5vdAo+PiB0aGUgY29uc29sZS4KPiAK Pj4+IEhvd2V2ZXIsIEkgRE8gdGhpbmsgdGhhdDoKPj4+Cj4+PiAgIC0gUmVtb3ZpbmcgYWNwaV9o ZXN0X2luaXQoKSBmcm9tIGFjcGlfcGNpX3Jvb3RfaW5pdCgpLCBhbmQKPj4+Cj4+PiAgIC0gQ29u dmVydGluZyBnaGVzX2luaXQoKSBhbmQgc2RlaV9pbml0KCkgZnJvbSBpbml0Y2FsbHMgdG8gZXhw bGljaXQKPj4+ICAgICBjYWxscwo+Pj4KPj4+IGFyZSB2ZXJ5IGdvb2QgcmVhc29ucyB0byBkbyBz b21ldGhpbmcgbGlrZSB0aGlzIHBhdGNoIGJlY2F1c2UgSEVTVCBpcwo+Pj4gbm90IFBDSS1zcGVj aWZpYywgYW5kIElNTywgZXhwbGljaXQgY2FsbHMgYXJlIGJldHRlciB0aGFuIGluaXRjYWxscwo+ Pj4gYmVjYXVzZSBpbml0Y2FsbCBvcmRlcmluZyBpcyBpbXBsaWNpdCBhbmQgbm90IHdlbGwtZGVm aW5lZCB3aXRoaW4gYQo+Pj4gbGV2ZWwuCj4+Cj4+IEhhaGEsIGlmIHRoZSBhYm92ZSByZWFzb25z IHN0aWxsIGRvbid0IGNvbnZpbmNlIHlvdSwgSSB3b3VsZCBsaWtlIHRvCj4+IGFjY2VwdCB5b3Vy cyA6KSBTaG91bGQgd2UgZG8gaXQgaW4gb25lIHBhdGNoIG9yIHNlcGFyYXRlIGl0IGludG8gdHdv Cj4+IHBhdGNoZXM/Cj4gCj4gSU1PLCB0aGlzIGNhbiBiZSBkb25lIGluIG9uZSBwYXRjaCwgYnV0 IHRoaXMgd291bGQgcHJvYmFibHkgZ28gdmlhCj4gUmFmYWVsLgoKR290IGl0LCBJIHdpbGwgc2Vu ZCBhIG5ldyBwYXRjaCBhbmQgY2MgdG8gUmFmYWVsLgoKPj4+PiAtc3RhdGljIGludCBfX2luaXQg Z2hlc19pbml0KHZvaWQpCj4+Pj4gK3ZvaWQgX19pbml0IGdoZXNfaW5pdCh2b2lkKQo+Pj4+ICB7 Cj4+Pj4gIAlpbnQgcmM7Cj4+Pj4gIAo+Pj4+ICAJaWYgKGFjcGlfZGlzYWJsZWQpCj4+Pj4gLQkJ cmV0dXJuIC1FTk9ERVY7Cj4+Pj4gKwkJcmV0dXJuOwo+Pj4+ICAKPj4+PiAgCXN3aXRjaCAoaGVz dF9kaXNhYmxlKSB7Cj4+Pj4gIAljYXNlIEhFU1RfTk9UX0ZPVU5EOgo+Pj4+IC0JCXJldHVybiAt RU5PREVWOwo+Pj4+ICsJCXByX2luZm8oR0hFU19QRlggIkhFU1QgaXMgbm90IGZvdW5kIVxuIik7 Cj4+Pgo+Pj4gSSBkb24ndCBrbm93IHdoZXRoZXIgdGhpcyAiSEVTVCBpcyBub3QgZm91bmQiIG1l c3NhZ2UgaXMKPj4+IHdvcnRod2hpbGUgb3Igbm90LiAgSSBkb24ndCB0aGluayBsYWNrIG9mIGFu IEhFU1QgaXMgYW4gZXJyb3IsIGFuZAo+Pj4gdXNlcnMgbWF5IGJlIGFsYXJtZWQuICBCdXQgdGhp cyBpcyBhbiBBQ1BJIHRoaW5nLCBzbyB1cCB0byB5b3UgYW5kCj4+PiBSYWZhZWwuCj4+Cj4+IElm IHdlIGV4cGxpY2l0IGNhbGwgZ2hlc19pbml0KCksIHdlIGNhbid0IHRlbGwgaWYgZ2hlcyBpcwo+ PiBpbml0aWFsaXplZCBzdWNjZXNzZnVsbHkgYmFzZWQgb24gdGhlIHJldHVybiB2YWx1ZSBvZiBp bml0Y2FsbC4gU28gSQo+PiBhZGQgYSBpbmZvIG1lc3NhZ2UuCj4gCj4gV2hlbiBnaGVzX2luaXQo KSBpcyBhbiBpbml0Y2FsbCBhbmQgeW91IHJldHVybiAtRU5PREVWIGZvciB0aGUKPiBIRVNUX05P VF9GT1VORCBjYXNlLCBJIGRvbid0IHRoaW5rIHdlIGxvZyBhbnkgbWVzc2FnZSBhYm91dCB0aGF0 LCBkbwo+IHdlPyAgZG9fb25lX2luaXRjYWxsKCkgd2lsbCBjYXB0dXJlIGFuZCByZXR1cm4gdGhl IC1FTk9ERVYsIGJ1dCB0aGUKPiBjYWxsZXIgKGRvX2luaXRjYWxsX2xldmVsKCkpIGp1c3QgaWdu b3JlcyBpdC4KCkkgc2VlLCB0aGFuayB5b3UuIEkgd2lsbCBkZWxldGUgaXQgaW4gbmV4dCB2ZXJz aW9uLgoKPj4+PiBAQCAtMTQ5NSw4ICsxNDk0LDcgQEAgc3RhdGljIGludCBfX2luaXQgZ2hlc19p bml0KHZvaWQpCj4+Pj4gIAllbHNlCj4+Pj4gIAkJcHJfaW5mbyhHSEVTX1BGWCAiRmFpbGVkIHRv IGVuYWJsZSBBUEVJIGZpcm13YXJlIGZpcnN0IG1vZGUuXG4iKTsKPj4+PiAgCj4+Pj4gLQlyZXR1 cm4gMDsKPj4+PiArCXJldHVybjsKPj4+PiAgZXJyOgo+Pj4+IC0JcmV0dXJuIHJjOwo+Pj4+ICsJ Z2hlc19kaXNhYmxlID0gMTsKPj4+Cj4+PiBXaHkgZG8geW91IHNldCBnaGVzX2Rpc2FibGUgaGVy ZT8gIEFzIGZhciBhcyBJIGNhbiB0ZWxsLCB3ZSB3aWxsIG5ldmVyCj4+PiBsb29rIGF0IGl0IGFn YWluLiAgVGhlIHBsYWNlcyB3ZSBkbyBsb29rIGF0IGl0IGFyZToKPj4+Cj4+PiAgIC0gZ2hlc19p bml0KCk6IGVhcmxpZXIgaW4gdGhpcyBmdW5jdGlvbiwgc28gd2UndmUgYWxyZWFkeSBkb25lIHRo YXQsCj4+Pgo+Pj4gICAtIGFjcGlfaGVzdF9pbml0KCk6IHdlJ3ZlIGFscmVhZHkgY2FsbGVkIHRo YXQsIHRvbywgYW5kCj4+Pgo+Pj4gICAtIGFjcGlfYnVzX29zY19uZWdvdGlhdGVfcGxhdGZvcm1f Y29udHJvbCgpOiBjYWxsZWQgZnJvbQo+Pj4gICAgIGFjcGlfYnVzX2luaXQoKSwgd2hpY2ggd2Un dmUgYWxyZWFkeSBjYWxsZWQuCj4+Cj4+IEkgYWRkIGl0IGZvciBmdXR1cmUgcG90ZW50aWFsIHVz YWdlLiBUaGFuayB5b3UgZm9yIHBvaW50aW5nIGl0IG91dC4KPj4gSWYgeW91IHRoaW5rIGl0IGlz IG5vdCBuZWNlc3NhcnksIEkgd2lsbCBkZWxldGUgaXQgaW4gbmV4dCB2ZXJzaW9uLgo+IAo+IEkg dGhpbmsgaXQgaXMgbm90IG5lY2Vzc2FyeSB0byBzYXZlIGluZm9ybWF0aW9uIHRoYXQgd2lsbCBu ZXZlciBiZQo+IHVzZWQuICBJZiB5b3UgbmVlZCBpdCBpbiB0aGUgZnV0dXJlLCB5b3UgY2FuIGFk ZCBpdCBhbmQgdGhlIHJlYXNvbgo+IHdpbGwgYmUgb2J2aW91cy4KPiAKPiBCam9ybgoKWW91IGFy ZSByaWdodC4gSSB3aWxsIGRlbGV0ZSBpdC4KCkJlc3QgUmVnYXJkcywKU2h1YWkKCgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=