From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ruehl Subject: Re: [Regression] net/phy/micrel.c v4.9.94 Date: Thu, 19 Apr 2018 09:21:05 +0800 Message-ID: <28e69b2b-e948-ab0e-d0c4-5f78994cfd98@gtsys.com.hk> References: <3bd29bdd-b5ab-03d5-ea53-292f9150ee4c@gtsys.com.hk> <20180418125601.GF31643@lunn.ch> <20180418130203.GG31643@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: f.fainelli@gmail.com, netdev@vger.kernel.org To: Andrew Lunn Return-path: Received: from sh1.xit.com.hk ([111.91.236.50]:50178 "EHLO sh1.xit.com.hk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752308AbeDSBVP (ORCPT ); Wed, 18 Apr 2018 21:21:15 -0400 In-Reply-To: <20180418130203.GG31643@lunn.ch> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On Wednesday, April 18, 2018 09:02 PM, Andrew Lunn wrote: > On Wed, Apr 18, 2018 at 02:56:01PM +0200, Andrew Lunn wrote: >> On Wed, Apr 18, 2018 at 09:34:16AM +0800, Chris Ruehl wrote: >>> Hello, >>> >>> I like to get your heads up at a regression introduced in 4.9.94 >>> commitment lead to a kernel ops and make the network unusable on my MX6DL >>> customized board. >>> >>> Race condition resume is called on startup and the phy not yet initialized. >> >> Hi Chris >> >> Please could you try >> >> bfe72442578b ("net: phy: micrel: fix crash when statistic requested for KSZ9031 phy") > > I don't think it is a complete fix. I suspect "Micrel KSZ8795", > "Micrel KSZ886X Switch", "Micrel KSZ8061", and "Micrel KS8737" will > still have problems. > > Those four probably need a: > > .probe = kszphy_probe, > > Andrew > Indeed I have the [ 7.385851] Micrel KSZ9031 Gigabit PHY 2188000.ethernet-1:05: attached PHY driver [Micrel KSZ9031 Gigabit PHY] (mii_bus:phy_addr=2188000.ethernet-1:05, irq=-1) first I rollback to a non crashing stable kernel. As "bfe72442578b" gonna fix it I check with the next update and verify its works for me. Thanks Chris