On 07.04.20 14:12, Kevin Wolf wrote: > External callers of blk_co_*() and of the synchronous blk_*() functions > don't currently increase the BlockBackend.in_flight counter, but calls > from blk_aio_*() do, so there is an inconsistency whether the counter > has been increased or not. > > This patch moves the actual operations to static functions that can > later know they will always be called with in_flight increased exactly > once, even for external callers using the blk_co_*() coroutine > interfaces. > > If the public blk_co_*() interface is unused, remove it. > > Signed-off-by: Kevin Wolf > --- > include/sysemu/block-backend.h | 1 - > block/block-backend.c | 103 +++++++++++++++++++++++++-------- > 2 files changed, 80 insertions(+), 24 deletions(-) Thanks! Reviewed-by: Max Reitz