From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D641AC07E96 for ; Thu, 15 Jul 2021 08:03:05 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 076B8610D1 for ; Thu, 15 Jul 2021 08:03:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 076B8610D1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2B26082859; Thu, 15 Jul 2021 10:03:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1626336183; bh=S4lEnBnT3eTJNiwXWROB0cMnh0lKwYORidycPiA4mmk=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=gzpVCqLJijbze2DGu2Wp0ZrYx/4ShLQQfmzlz7EVM9MEMZHTFpuz2tvuU6ZVZ0D86 ePTp903+fvaXCVGdAmmfQSrYKclpkC1kLMTOxBFt266ZoMSwYRWKrSv/FNbAkAffwc B6AkkD6nanC1l1YDF6kadhFqR0Oo0ojPPrme3TKTVTjrX/DQii+rI/C2Ppfg07+oyg IAYgJxGtTmMrWW+jrsUKN+71XAtt1imbEO0A6lDosqeqcOXyr7/8wVEZ58p11W7/6D LQQNhjnR6S3x8x2DplJwCc54roSmGsV6hyTnPAWIaigk5AXdnMXL2hSI0bLph9teBM Ev5K/cJun2i3A== Received: by phobos.denx.de (Postfix, from userid 109) id 0EE2B82903; Thu, 15 Jul 2021 10:03:01 +0200 (CEST) Received: from mout-u-204.mailbox.org (mout-u-204.mailbox.org [91.198.250.253]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EA59C81FC6 for ; Thu, 15 Jul 2021 10:02:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:105:465:1:2:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4GQRgj5zPVzQjrd; Thu, 15 Jul 2021 10:02:57 +0200 (CEST) Received: from smtp2.mailbox.org ([80.241.60.241]) by gerste.heinlein-support.de (gerste.heinlein-support.de [91.198.250.173]) (amavisd-new, port 10030) with ESMTP id D-jzFdzPSQFh; Thu, 15 Jul 2021 10:02:54 +0200 (CEST) Subject: Re: [PATCH 2/3] arm: mvebu: Espressobin: Use function mmc_get_op_cond() for detecting eMMC To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Andre Heider , =?UTF-8?Q?G=c3=a9rald_Kerma?= , Konstantin Porotchkin , Baruch Siach , Fabio Estevam , Peng Fan Cc: u-boot@lists.denx.de References: <20210714143729.2396-1-pali@kernel.org> <20210714143729.2396-2-pali@kernel.org> From: Stefan Roese Message-ID: <29048674-59b8-fcaf-2bcc-c671dfc8dd8b@denx.de> Date: Thu, 15 Jul 2021 10:02:54 +0200 MIME-Version: 1.0 In-Reply-To: <20210714143729.2396-2-pali@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit X-MBO-SPAM-Probability: X-Rspamd-Score: -1.41 / 15.00 / 15.00 X-Rspamd-Queue-Id: F062017FC X-Rspamd-UID: f3a8a8 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 14.07.21 16:37, Pali Rohár wrote: > Use function mmc_get_op_cond() instead of mmc_init() for detecting presence > of eMMC. Documentation for this function says that it could be used to > detect the presence of SD/eMMC when no card detect logic is available. > > This function is also used by mx6cuboxi board for detecting presence of eMMC. > > Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan > --- > board/Marvell/mvebu_armada-37xx/board.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/Marvell/mvebu_armada-37xx/board.c b/board/Marvell/mvebu_armada-37xx/board.c > index 53408d37af9b..6086996b8062 100644 > --- a/board/Marvell/mvebu_armada-37xx/board.c > +++ b/board/Marvell/mvebu_armada-37xx/board.c > @@ -124,7 +124,7 @@ int board_late_init(void) > > /* eMMC is mmc dev num 1 */ > mmc_dev = find_mmc_device(1); > - emmc = (mmc_dev && mmc_init(mmc_dev) == 0); > + emmc = (mmc_dev && mmc_get_op_cond(mmc_dev) == 0); > > /* if eMMC is not present then remove it from DM */ > if (!emmc && mmc_dev) { > Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de