From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 00/40] Introduce NXP DPAA Bus, Mempool and PMD Date: Wed, 05 Jul 2017 08:28:50 +0200 Message-ID: <2911799.zLFx1Cjncp@xps> References: <1497591668-3320-1-git-send-email-shreyansh.jain@nxp.com> <2228750.hDQQI7liEJ@xps> <7a60545f-0853-6db4-342c-575f7d3e93ae@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, ferruh.yigit@intel.com, hemant.agrawal@nxp.com To: Shreyansh Jain Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id BB97F2A58 for ; Wed, 5 Jul 2017 08:28:51 +0200 (CEST) In-Reply-To: <7a60545f-0853-6db4-342c-575f7d3e93ae@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/07/2017 06:38, Shreyansh Jain: > Hello Thomas, > > On Wednesday 05 July 2017 05:43 AM, Thomas Monjalon wrote: > > Hi Shreyansh, > > > > 04/07/2017 16:43, Shreyansh Jain: > >> This patchset introduces the following: > >> 1. DPAA Bus (drivers/bus/dpaa) > >> The core of DPAA bus is implemented using 3 main hardware blocks: QMan, > >> or Queue Manager; BMan, or Buffer Manager and FMan, or Frame Manager. > >> The patches introduce necessary layers to expose the DPAA hardware > >> blocks for interfacing with RTE framework. > >> > >> 2. DPAA Mempool (drivers/mempool/dpaa) > >> BMan, or Buffer Manager, block of DPAA features a hardware offloaded > >> mempool. These patches add support for a driver to manage the BMan > >> block. This driver allows for mempool creation, deletion, buffer > >> acquire and release, as per the RTE APIs. > >> > >> 3. DPAA PMD (drivers/net/dpaa) > >> The Poll Mode Driver for DPAA NIC Interfaces. > > > > There is so much to review in this series! > > (and not much reviews) > > I hope you were not expecting a quick integration. > > I understand this. > Ferruh has been putting in quite an effort - but yes, other than that, lack of external review. > I am just expecting inputs - if there are none, then probably that would be integration point (other than continuous improvements we do internally) or patches might stagnate. > > But just a random thought off my head (which might help me as a reviewer): How does one review integral/infrastructure related code blocks without a deep insight? ethdev/rxtx are relatively much easier/relevant for reviewers - but not low level blocks. In case of DPAA, that (core routines) is a huge chunks. And, if there are not much reviews (because of lack of interest, or whatever reason), what should an author do (besides gently requesting others, and doing some himself/herself). I guess nobody will review the low level. But we can check how it is integrated within the framework. > > Please could you start checking what checkpatch is saying? > > > > I have seen those - and ignored them for a while. They are related to complex statements defined as macros. Unfortunately, at some of the places, I can't avoid it. > Otherwise, there are some which require code-restructuring (deep indentation), which I plan to do shortly. Thanks