All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Cédric Le Goater" <clg@kaod.org>, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Aleksandar Rikalo" <arikalo@wavecomp.com>,
	"Helge Deller" <deller@gmx.de>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Joel Stanley" <joel@jms.id.au>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Artyom Tarasenko" <atar4qemu@gmail.com>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Alistair Francis" <alistair@alistair23.me>,
	qemu-arm@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>,
	"Andrew Jeffery" <andrew@aj.id.au>,
	qemu-ppc@nongnu.org,
	"Aleksandar Markovic" <amarkovic@wavecomp.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [PATCH 11/13] hw: Move Aspeed RTC from hw/timer/ to hw/rtc/ subdirectory
Date: Thu, 3 Oct 2019 12:55:21 +0200	[thread overview]
Message-ID: <29282e84-e8f9-feda-21a4-d8dd202a5638@redhat.com> (raw)
In-Reply-To: <20ec7d30-a8da-9e11-acfc-b8d773a5527d@kaod.org>

On 9/16/19 7:21 PM, Cédric Le Goater wrote:
> On 16/09/2019 17:48, Philippe Mathieu-Daudé wrote:
>> Move RTC devices under the hw/rtc/ subdirectory.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> 
> I suppose the removal of the header files in "aspeed_rtc.h" is OK.

They are not used. It is probably cleaner to do this change in a 
separate patch.

> 
> Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks!

[...]
>> diff --git a/include/hw/timer/aspeed_rtc.h b/include/hw/rtc/aspeed_rtc.h
>> similarity index 92%
>> rename from include/hw/timer/aspeed_rtc.h
>> rename to include/hw/rtc/aspeed_rtc.h
>> index 15ba42912b..156c8faee3 100644
>> --- a/include/hw/timer/aspeed_rtc.h
>> +++ b/include/hw/rtc/aspeed_rtc.h
>> @@ -8,9 +8,6 @@
>>   #ifndef ASPEED_RTC_H
>>   #define ASPEED_RTC_H
>>   
>> -#include <stdint.h>
>> -
>> -#include "hw/irq.h"
>>   #include "hw/sysbus.h"
>>   
>>   typedef struct AspeedRtcState {
>>


  reply	other threads:[~2019-10-03 10:56 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-16 15:48 [Qemu-devel] [PATCH 00/13] hw: Split RTC devices from hw/timer/ to hw/rtc/ Philippe Mathieu-Daudé
2019-09-16 15:48 ` [Qemu-devel] [PATCH 01/13] hw/timer: Compile devices not target-dependent as common object Philippe Mathieu-Daudé
2019-09-16 17:28   ` Alistair Francis
2019-09-17  4:57   ` Thomas Huth
2019-09-16 15:48 ` [Qemu-devel] [PATCH 02/13] hw: Move PL031 device from hw/timer/ to hw/rtc/ subdirectory Philippe Mathieu-Daudé
2019-09-16 18:12   ` Alistair Francis
2019-09-16 15:48 ` [Qemu-devel] [PATCH 03/13] hw: Move MC146818 " Philippe Mathieu-Daudé
2019-09-16 21:22   ` Alistair Francis
2019-09-17  2:23   ` David Gibson
2019-09-17  5:07   ` Thomas Huth
2019-09-17 10:03     ` Philippe Mathieu-Daudé
2019-09-18  7:43       ` Thomas Huth
2019-09-18 11:02         ` Philippe Mathieu-Daudé
2019-09-17 20:32   ` Richard Henderson
2019-09-18 10:52     ` Philippe Mathieu-Daudé
2019-09-16 15:48 ` [Qemu-devel] [PATCH 04/13] hw: Move M48T59 " Philippe Mathieu-Daudé
2019-09-16 21:23   ` Alistair Francis
2019-09-17  2:25   ` David Gibson
2019-09-17 10:08     ` Philippe Mathieu-Daudé
2019-09-16 15:48 ` [Qemu-devel] [PATCH 05/13] hw: Move M41T80 " Philippe Mathieu-Daudé
2019-09-16 21:26   ` Alistair Francis
2019-09-16 15:48 ` [Qemu-devel] [PATCH 06/13] hw: Move sun4v hypervisor RTC " Philippe Mathieu-Daudé
2019-09-16 21:27   ` Alistair Francis
2019-09-16 15:48 ` [Qemu-devel] [PATCH 07/13] hw: Move TWL92230 device " Philippe Mathieu-Daudé
2019-09-16 21:39   ` Alistair Francis
2019-09-16 15:48 ` [Qemu-devel] [PATCH 08/13] hw: Move DS1338 " Philippe Mathieu-Daudé
2019-09-16 21:43   ` Alistair Francis
2019-09-16 15:48 ` [Qemu-devel] [PATCH 09/13] hw: Move Xilinx ZynqMP RTC " Philippe Mathieu-Daudé
2019-09-16 21:44   ` Alistair Francis
2019-09-17 10:28     ` Philippe Mathieu-Daudé
2019-09-17 23:29       ` Alistair Francis
2019-09-16 15:48 ` [Qemu-devel] [PATCH 10/13] hw: Move Exynos4210 " Philippe Mathieu-Daudé
2019-09-16 21:45   ` Alistair Francis
2019-09-16 15:48 ` [Qemu-devel] [PATCH 11/13] hw: Move Aspeed " Philippe Mathieu-Daudé
2019-09-16 17:21   ` Cédric Le Goater
2019-10-03 10:55     ` Philippe Mathieu-Daudé [this message]
2019-09-16 21:46   ` Alistair Francis
2019-09-16 15:48 ` [Qemu-devel] [PATCH 12/13] hw/rtc/mc146818: Include mc146818rtc_regs.h a bit less Philippe Mathieu-Daudé
2019-09-16 21:46   ` Alistair Francis
2019-09-16 15:48 ` [Qemu-devel] [PATCH 13/13] hw/rtc/xlnx-zynqmp-rtc: Remove unused "ptimer.h" include Philippe Mathieu-Daudé
2019-09-16 21:47   ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29282e84-e8f9-feda-21a4-d8dd202a5638@redhat.com \
    --to=philmd@redhat.com \
    --cc=alistair@alistair23.me \
    --cc=amarkovic@wavecomp.com \
    --cc=andrew@aj.id.au \
    --cc=arikalo@wavecomp.com \
    --cc=atar4qemu@gmail.com \
    --cc=aurelien@aurel32.net \
    --cc=clg@kaod.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=deller@gmx.de \
    --cc=edgar.iglesias@gmail.com \
    --cc=ehabkost@redhat.com \
    --cc=hpoussin@reactos.org \
    --cc=imammedo@redhat.com \
    --cc=joel@jms.id.au \
    --cc=lvivier@redhat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.