From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F274C3565A for ; Fri, 21 Feb 2020 17:06:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E9E9222C4 for ; Fri, 21 Feb 2020 17:06:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iyS2WSHz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E9E9222C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5BlF-0006eE-EW for qemu-devel@archiver.kernel.org; Fri, 21 Feb 2020 12:06:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34299) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5BjT-0004jZ-Gn for qemu-devel@nongnu.org; Fri, 21 Feb 2020 12:04:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j5BjS-0003wD-8A for qemu-devel@nongnu.org; Fri, 21 Feb 2020 12:04:55 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:53086 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j5BjR-0003v9-7N for qemu-devel@nongnu.org; Fri, 21 Feb 2020 12:04:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582304692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mCAnlW7fMS7PpOJIXKVM++XeniQ79ph50NcqYHEi3MI=; b=iyS2WSHzmpJx6Z2CXu+JooiE6kjUlZGN/cl+U8q90fV9GhZLEE4FCD/Sg5c3mzX2uGv24e 39+b7hEwrSWr86ZCsr60QUDHp7w0BOU3wUniPcgiuPMOcb+Hwmt9AePSqi6uCpG/grMeqd K67CgAtYGeXlMU7wIj12nMq1wzHHYgw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-363-5D25X0XONZKZf0SOGOCYVQ-1; Fri, 21 Feb 2020 12:04:48 -0500 X-MC-Unique: 5D25X0XONZKZf0SOGOCYVQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CEBFA8017CC; Fri, 21 Feb 2020 17:04:46 +0000 (UTC) Received: from dresden.str.redhat.com (unknown [10.36.118.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5B48C5C1C3; Fri, 21 Feb 2020 17:04:44 +0000 (UTC) Subject: Re: [RFC PATCH v3 27/27] iotests: Add tests for qcow2 images with extended L2 entries To: Alberto Garcia , qemu-devel@nongnu.org References: <9ece987f62e5f05f817c76339bf22ec4810e3205.1577014346.git.berto@igalia.com> From: Max Reitz Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: <292948a0-14f2-f8ee-b05e-fcb898d45ec2@redhat.com> Date: Fri, 21 Feb 2020 18:04:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <9ece987f62e5f05f817c76339bf22ec4810e3205.1577014346.git.berto@igalia.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xsCEyPjcF5fq3o4RDhx6sTtttwOexWILV" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Anton Nefedov , qemu-block@nongnu.org, Vladimir Sementsov-Ogievskiy , "Denis V . Lunev" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xsCEyPjcF5fq3o4RDhx6sTtttwOexWILV Content-Type: multipart/mixed; boundary="90Xev6pu4nBqjdPcTFeoG9btDIjpWwRTe" --90Xev6pu4nBqjdPcTFeoG9btDIjpWwRTe Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 22.12.19 12:37, Alberto Garcia wrote: > Signed-off-by: Alberto Garcia > --- > tests/qemu-iotests/271 | 256 +++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/271.out | 208 ++++++++++++++++++++++++++++++ > tests/qemu-iotests/group | 1 + > 3 files changed, 465 insertions(+) > create mode 100755 tests/qemu-iotests/271 > create mode 100644 tests/qemu-iotests/271.out Currently, you=E2=80=99re using the reference output to verify the results.= I find this rather difficult. Can this not be written in a way that the test itself verifies the results? I realize bit manipulation in bash is hard, which is why I wonder whether Python may be better suited for the job. Or maybe at least there could be some way to produce a hexdump-like result from some more abstract description on what to expect and then compare the strings. I suppose I can live with how it is, but I feel like I=E2=80=99d have to do something in my head that could be better done by a script. Max --90Xev6pu4nBqjdPcTFeoG9btDIjpWwRTe-- --xsCEyPjcF5fq3o4RDhx6sTtttwOexWILV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl5QDaoACgkQ9AfbAGHV z0AdsQf9GoCXadmM3qW1Rvl5f81XKAAgF+fTvXLLG42BL/v0VT9LaKqZr/Zjd9vr y3uAIs5u7giS0trH55qFx4o7oRSgPLV/QEPHNsZZ6+nqZX2DnaiverR/9YB0D4Eu UXJ6/YO/EuDQ1WxAx3/EIvv3IU/GCEQIyfSE8l2aMVe/MTuhSNaa4oPVIbIY8+NP Es6ykMuMySXb7l+hn/gIgleeaX/gDtcjVuBXLVaDRjH9SxkaXMZj5dWsH9SD7pR/ VQzN4fjLmo6RQslUo2Q+t9Qmxde9Y9IjPTxjKt3Z2WYVMa923rF/gMfM44MK59WU smRAMLyIEk3KFbnmrMpQS4oARENizQ== =mngd -----END PGP SIGNATURE----- --xsCEyPjcF5fq3o4RDhx6sTtttwOexWILV--