From: Philipp Zabel <p.zabel@pengutronix.de>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: "Chris Brandt" <chris.brandt@renesas.com>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Jarkko Nikula" <jarkko.nikula@linux.intel.com>,
"Jean Delvare" <jdelvare@suse.de>,
"Khalil Blaiech" <kblaiech@mellanox.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
"Yicong Yang" <yangyicong@hisilicon.com>,
"Bence Csókás" <bence98@sch.bme.hu>,
"Mike Rapoport" <rppt@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-i2c@vger.kernel.org,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Chris Paterson" <Chris.Paterson2@renesas.com>,
"Biju Das" <biju.das@bp.renesas.com>,
"Prabhakar Mahadev Lad" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 2/2] i2c: riic: Add RZ/G2L support
Date: Tue, 15 Jun 2021 09:48:43 +0200 [thread overview]
Message-ID: <2935959198e4c40c49623f2e5f161392e76d6add.camel@pengutronix.de> (raw)
In-Reply-To: <20210614193253.10011-3-biju.das.jz@bp.renesas.com>
On Mon, 2021-06-14 at 20:32 +0100, Biju Das wrote:
> RZ/G2L i2c controller is compatible with RZ/A i2c controller.
> By default IP is in reset state, so need to perform release
> reset before accessing any register.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> v1->v2
> * Changed to devm_reset_control_get_exclusive API for reset_control_get.
> * Updated KCONFIG to enable RESET_CONTROLLER only if it is RZ/G2L SoC.
> * Filled .data for RIIC_RZ_A.
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/i2c/busses/Kconfig | 1 +
> drivers/i2c/busses/i2c-riic.c | 23 ++++++++++++++++++++++-
> 2 files changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 281a65d9b44b..17bd15ad8761 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -941,6 +941,7 @@ config I2C_QUP
> config I2C_RIIC
> tristate "Renesas RIIC adapter"
> depends on ARCH_RENESAS || COMPILE_TEST
> + select RESET_CONTROLLER if ARCH_R9A07G044
I would have expected the select RESET_CONTROLLER to be placed under
config ARCH_R9A07G044. Since this is a pretty architecture specific
driver, I'm ok with this as well.
regards
Philipp
next prev parent reply other threads:[~2021-06-15 7:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 19:32 [PATCH v2 0/2] Add RZ/G2L I2C support Biju Das
2021-06-14 19:32 ` [PATCH v2 1/2] dt-bindings: i2c: renesas,riic: Document RZ/G2L I2C controller Biju Das
2021-06-14 19:32 ` [PATCH v2 2/2] i2c: riic: Add RZ/G2L support Biju Das
2021-06-14 19:43 ` Geert Uytterhoeven
2021-06-15 7:48 ` Philipp Zabel [this message]
2021-06-15 7:55 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2935959198e4c40c49623f2e5f161392e76d6add.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=Chris.Paterson2@renesas.com \
--cc=arnd@arndb.de \
--cc=bence98@sch.bme.hu \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=chris.brandt@renesas.com \
--cc=geert+renesas@glider.be \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=kblaiech@mellanox.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=rppt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa+renesas@sang-engineering.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.