From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8681BC433E0 for ; Sun, 21 Feb 2021 16:39:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2261F64E61 for ; Sun, 21 Feb 2021 16:39:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2261F64E61 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37300 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lDrle-0000T0-5G for qemu-devel@archiver.kernel.org; Sun, 21 Feb 2021 11:39:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDrkD-0008AB-Kl; Sun, 21 Feb 2021 11:38:06 -0500 Received: from mail-il1-x131.google.com ([2607:f8b0:4864:20::131]:46962) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lDrkC-0007vL-1O; Sun, 21 Feb 2021 11:38:05 -0500 Received: by mail-il1-x131.google.com with SMTP id m20so8788930ilj.13; Sun, 21 Feb 2021 08:38:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3YjKPhX0oflBmINtMtknp5iw/TvXXLniGcuPPnFL7vk=; b=AllwdyD6T01TKU/PslJJlx0zlQKerNq25C/FKpxHiEIwBxjo1KalwUuD1vugz6xUWi 9dom/0qewXJM+ybWTw401zDFV/Ohz5P8O1ipNO1vuHsr5j0vODSgMf2qXcRSg+YI3r+H BuBpxowWbFZz8k3TC9ssixhUq6u9I01DfuScQi2eS7EGJtMZ6q44BKjiA68MOYVD8zAl 9vAqZQvAORRTo+pA5bpp0jfaB7fqYtyx+00X1S4D02p3gzhlgLNnzcut9bJUy29mGAYo HMCUMhCVPM5jjf6ov418Hue+N8eR7U5TrO+7V+4FzNL8qvCnjEHYPyOyIsIgobyNmhsf Thig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3YjKPhX0oflBmINtMtknp5iw/TvXXLniGcuPPnFL7vk=; b=Np56EC/Qn4vbRcWnVXeBS9md8vYewXLiSM3CGzEqjiUoFnV+q4t9SLlzE6mLu9/vR9 oqWhFZ5Pd5fbuSucJffZzwhyF/pqwemkL1u5TmlwvykX42BTSU7V58nHvFiWVXmoJnnP zhEk4zsjuObJXTYd8UGSiotIguTIT/JvUV4Kt3CBIiFDjDeQZGZ4uJmrn0vqP1hoa6B6 fgsf/uTHnYtj5ckIy1gdsSYiMPtQX59eClL0pzx+5xqajIXZR8I7sBllM4/v0ObtTWvi OWj4p7KZQt6jK1i5F+F8z36SkCKwgI8eXD4NNUmZKTKurvYohwcXhtq9OlydaXRhKyK6 EC/A== X-Gm-Message-State: AOAM530t03si8I3Sr78YYBngnYVv109GT8WaTERPyJuOORzAP5bv6YJb ZYgBkHPVjHEIbB9+8QRxA3VspXOuD4kOZwnX X-Google-Smtp-Source: ABdhPJzRKJWCc1+2peTPUaRUWcbSKjS41b2H4G+PKgY8RG7aY9oMyCFGWDkBPn2MqnbhAk8E67ErDQ== X-Received: by 2002:a92:c8cd:: with SMTP id c13mr1714662ilq.238.1613925481329; Sun, 21 Feb 2021 08:38:01 -0800 (PST) Received: from [192.168.88.57] (c-67-177-215-41.hsd1.co.comcast.net. [67.177.215.41]) by smtp.gmail.com with ESMTPSA id g11sm11402181iom.23.2021.02.21.08.38.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Feb 2021 08:38:00 -0800 (PST) Subject: Re: [PATCH] hw/char/pl011: fix receiving multiple chars To: Peter Maydell References: <20210221150430.6223-1-zpmarvel@gmail.com> From: Zack Marvel Message-ID: <293978ea-bb78-066e-dbe8-f93b2165d28d@gmail.com> Date: Sun, 21 Feb 2021 09:37:59 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::131; envelope-from=zpmarvel@gmail.com; helo=mail-il1-x131.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Peter, Thanks for the quick review. You're right, I misunderstood the API and the bug is in ui/gtk.c. Thanks, Zack M On 2/21/21 8:19 AM, Peter Maydell wrote: > On Sun, 21 Feb 2021 at 15:04, Zack Marvel wrote: >> >> When using the GTK UI with libvte, multicharacter keystrokes are not >> sent correctly (such as arrow keys). This is not an issue for e.g. the >> SDL UI because qemu_chr_be_write is called with len=1 for each character >> (SDL sends more than once keystroke). >> >> Buglink: https://bugs.launchpad.net/qemu/+bug/1407808 >> >> Signed-off-by: Zack Marvel > >> @@ -300,7 +300,9 @@ static void pl011_put_fifo(void *opaque, uint32_t value) >> >> static void pl011_receive(void *opaque, const uint8_t *buf, int size) >> { >> - pl011_put_fifo(opaque, *buf); >> + for (int i = 0; i < size; i++) { >> + pl011_put_fifo(opaque, buf[i]); >> + } >> } > > I think this is a bug in whatever is on the other end > of the chardev connection. The pl011 can_receive routine > only ever returns 0 or 1, so it is an error for the > code calling its receive function to ever pass a > size that is greater than 1. > > thanks > -- PMM >