From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 0/4] eal/common: introduce rte_memset and related test Date: Tue, 17 Jan 2017 21:14:12 +0100 Message-ID: <2941830.sLC5GUQ46q@xps13> References: <1480926387-63838-2-git-send-email-zhiyong.yang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "Richardson, Bruce" , "Ananyev, Konstantin" , yuanhan.liu@linux.intel.com, "De Lara Guarch, Pablo" , dev@dpdk.org To: "Yang, Zhiyong" Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 5BB6C108F for ; Tue, 17 Jan 2017 21:14:14 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id c206so241142023wme.0 for ; Tue, 17 Jan 2017 12:14:14 -0800 (PST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-01-17 06:24, Yang, Zhiyong: > Hi, Thomas: > Does this patchset have chance to be applied for 1702 release? It could be part of 17.02 but there are some issues: The x86 part did not receive any ack from x86 maintainers. checkpatch reports some warnings, especially about counting elements of an array. Please use RTE_DIM. The file in generic/ is for doxygen only. Please check how it is done for other files. The description is "Functions for vectorised implementation of memset()." Does it mean memset from glibc does not use vector instructions? The functional autotest is not integrated in the basic test suite. I wish this kind of review would be done by someone else. As it has not a big performance impact, this series could wait the next release. By the way, have you tried to work on glibc, as I had suggested?