From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3 1/3] add new xstats API retrieving by id
Date: Tue, 04 Apr 2017 17:03:51 +0200
Message-ID: <2943087.L4hhIMZ3WY@xps13>
References: <1490910640-244285-2-git-send-email-michalx.k.jastrzebski@intel.com>
 <1491221393-10305-1-git-send-email-jacekx.piasecki@intel.com>
 <1491221393-10305-2-git-send-email-jacekx.piasecki@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, harry.van.haaren@intel.com,
 Kuba Kozak <kubax.kozak@intel.com>, Tomasz Kulasek <tomaszx.kulasek@intel.com>
To: Jacek Piasecki <jacekx.piasecki@intel.com>,
 Michal Jastrzebski <michalx.k.jastrzebski@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com
 [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id 74307326C
 for <dev@dpdk.org>; Tue,  4 Apr 2017 17:03:53 +0200 (CEST)
Received: by mail-wr0-f175.google.com with SMTP id w11so215578322wrc.3
 for <dev@dpdk.org>; Tue, 04 Apr 2017 08:03:53 -0700 (PDT)
In-Reply-To: <1491221393-10305-2-git-send-email-jacekx.piasecki@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-04-03 14:09, Jacek Piasecki:
> From: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>
>=20
> Extended xstats API in ethdev library to allow grouping of stats
> logically so they can be retrieved per logical grouping =E2=80=93 man=
aged
> by the application.
> Changed existing functions rte_eth_xstats_get_names and
> rte_eth_xstats_get to use a new list of arguments: array of ids
> and array of values. ABI versioning mechanism was used to
> support backward compatibility.
> Introduced two new functions rte_eth_xstats_get_all and
> rte_eth_xstats_get_names_all which keeps functionality of the
> previous ones (respectively rte_eth_xstats_get and
> rte_eth_xstats_get_names) but use new API inside.

Sorry, I still do not understand why we should complicate the API.
What is not possible with the existing API?

The v1 was submitted in the last days of the proposal deadline,
v2 in the last minutes of integration deadline,
and v3 is submitted after the deadline.

Given it is late and it is still difficult to understand the benefit,
I think it won't make the release 17.05.