From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33451) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blxzD-0007pD-7V for qemu-devel@nongnu.org; Mon, 19 Sep 2016 08:47:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1blxz8-0007rF-9A for qemu-devel@nongnu.org; Mon, 19 Sep 2016 08:47:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42652) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blxz8-0007r7-2h for qemu-devel@nongnu.org; Mon, 19 Sep 2016 08:47:46 -0400 References: <1473841548-26742-1-git-send-email-peterx@redhat.com> From: Paolo Bonzini Message-ID: <29444a1f-4e4d-e2fc-0142-8674c0160286@redhat.com> Date: Mon, 19 Sep 2016 14:47:40 +0200 MIME-Version: 1.0 In-Reply-To: <1473841548-26742-1-git-send-email-peterx@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 0/3] Introduce IOMMUNotifier struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu , qemu-devel@nongnu.org Cc: dgibson@redhat.com, jasowang@redhat.com, mst@redhat.com, cornelia.huck@de.ibm.com, wexu@redhat.com, vkaplans@redhat.com, alex.williamson@redhat.com On 14/09/2016 10:25, Peter Xu wrote: > (Note: we still have pending discussions on how IOMMU notifier > interface should be, assuming that is not a blocker for posting v5 of > this one) > > V5: > - squash spapr_tce_notify_{started|stopped} into > spapr_tce_notify_flag_changed [David] > - in spapr_tce_notify_flag_changed: check flags against "!= > IOMMU_NOTIFIER_NONE", but not "== IOMMU_NOTIFIER_ALL" [David] > - add r-b for David on patch 3 Looks good, thanks. If David doesn't reply further I'll merge this. Paolo > V4: > - change "notifier_caps" into "notifier_flags" [David] > - rename IOMMU_NOTIFIER_{CHANGE|INVALIDATION} with MAP/UNMAP [David] > - introduce IOMMUOps.notify_flag_changed, to replace notify_started > and notify_stopped [David, Paolo] > > V3: > - use QLIST instead of embedding Notifier into IOMMUNotifier [Paolo] > - fix a build error for ppc64-softmmu > > The idea originates from one of Alex's reply: > > https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg00254.html > > But after further discussions, it seems that only adding a simple type > for notifier is not enough. This series introduced IOMMUNotifier > struct to replace the old Notifier interface. Along with it, we can > provide registration for one (or multiple) of the IOMMU notifications: > > - cache invalidations > - entry changes > > This is a support material for Jason's vhost dmar patchset. > > Please read commit messages for detailed information. Thanks, > > Peter Xu (3): > memory: introduce IOMMUNotifier and its caps > memory: introduce IOMMUOps.notify_flag_changed > intel_iommu: allow UNMAP notifiers > > hw/i386/intel_iommu.c | 18 ++++++++----- > hw/ppc/spapr_iommu.c | 18 +++++++------ > hw/vfio/common.c | 3 ++- > include/exec/memory.h | 47 +++++++++++++++++++++++++-------- > include/hw/vfio/vfio-common.h | 2 +- > memory.c | 60 +++++++++++++++++++++++++++++++++---------- > 6 files changed, 107 insertions(+), 41 deletions(-) >