All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>, Simon <horms@verge.net.au>
Subject: Re: [PATCH] ASoC: rsnd: add missing src/dst_addr_width for DMAEngine
Date: Tue, 22 Jul 2014 15:16:53 +0200	[thread overview]
Message-ID: <2950078.WJQuDn5Q4k@avalon> (raw)
In-Reply-To: <87lhrmi0jp.wl%kuninori.morimoto.gx@gmail.com>

Hi Morimoto-san,

On Monday 21 July 2014 19:34:36 Kuninori Morimoto wrote:
> Hi Laurent
> 
> > > > What tree is the patch based on ? It doesn't apply on Takashi's latest
> > > > master branch. I need a bit of context to review it.
> 
> (snip)
> 
> > I've tried to understand the driver and couldn't even find out which DMA
> > controller was used :-/ I suspect it's the audio peri-peri DMAC, but I
> > haven't been able to confirm that from the source code. If the assumption
> > is true the patch looks OK to me, but if you need a formal Acked-by then
> > I'll need you to guide me through the driver I'm afraid.
> 
> Ahh I'm sorry about this confusion.
> It uses audio peri-peri DMAC, and, your rcar-dmac (as audio DMAC)
> The platform side is not upstreamed yet.
> (Because it depends on rcar-dmac)
> 
> But, I posted RFC audio DMAC support patches which
> was based on Ben's DMAC before.
> 
>     http://www.spinics.net/lists/linux-sh/msg32949.html
> 
> I can re-post this patch if all DMAC was ready

No need to, that was enough. Thank you. I've acked the patch.

By the way, I'd like to test cyclic transfers with the rcar-dmac driver. Is 
there an easy (or at least not too difficult) way to do so with your audio 
driver ?

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2014-07-22 13:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-17  6:18 [PATCH] ASoC: rsnd: add missing src/dst_addr_width for DMAEngine Kuninori Morimoto
2014-07-18 12:44 ` Laurent Pinchart
2014-07-21 23:55   ` Kuninori Morimoto
2014-07-22  1:11     ` Laurent Pinchart
2014-07-22  2:34       ` Kuninori Morimoto
2014-07-22 13:16         ` Laurent Pinchart [this message]
2014-07-23  0:44           ` Kuninori Morimoto
2014-07-22 13:15 ` Laurent Pinchart
2014-07-22 22:17 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2950078.WJQuDn5Q4k@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=horms@verge.net.au \
    --cc=kuninori.morimoto.gx@gmail.com \
    --cc=lgirdwood@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.