From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 18/32] net/dpaa2: introducing dpaa2 pmd driver
Date: Tue, 06 Dec 2016 22:08:05 +0100
Message-ID: <2956951.cEfl6HOu1U@xps13>
References: <1480875447-23680-1-git-send-email-hemant.agrawal@nxp.com>
 <1480875447-23680-19-git-send-email-hemant.agrawal@nxp.com>
 <2023a9a6-f342-8986-7ded-3703b3623a70@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, bruce.richardson@intel.com, shreyansh.jain@nxp.com
To: Ferruh Yigit <ferruh.yigit@intel.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id 39FAE2BCD
 for <dev@dpdk.org>; Tue,  6 Dec 2016 22:08:08 +0100 (CET)
Received: by mail-wm0-f43.google.com with SMTP id g23so143408843wme.1
 for <dev@dpdk.org>; Tue, 06 Dec 2016 13:08:08 -0800 (PST)
In-Reply-To: <2023a9a6-f342-8986-7ded-3703b3623a70@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-12-06 19:49, Ferruh Yigit:
> On 12/4/2016 6:17 PM, Hemant Agrawal wrote:
> > +	if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
> > +		eth_dev->data->dev_private = rte_zmalloc(
> > +						"ethdev private structure",
> > +						eth_drv->dev_private_size,
> > +						RTE_CACHE_LINE_SIZE);
> > +		if (eth_dev->data->dev_private == NULL)
> > +			rte_panic("Cannot allocate memzone for private port"
> > +				  " data\n");
> 
> Should this error kill all app, or return an error for this PMD that is
> probed.

It cannot be a question :)
rte_panic() inside libs or drivers is forbidden (and existing ones must
be removed).