From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] io_uring: fixup a few spots where link failure isn't flagged
Date: Wed, 6 Nov 2019 17:03:24 -0700 [thread overview]
Message-ID: <29607ed7-a8a5-0208-b50a-f9feabcaa7fb@kernel.dk> (raw)
In-Reply-To: <ee474592-8e97-eb11-0f95-84607bed033d@gmail.com>
On 11/6/19 11:44 AM, Pavel Begunkov wrote:
> On 06/11/2019 06:32, Jens Axboe wrote:
>> If a request fails, we need to ensure we set REQ_F_FAIL_LINK on it if
>> REQ_F_LINK is set. Any failure in the chain should break the chain.
>>
>> We were missing a few spots where this should be done. It might be nice
>> to generalize this somewhat at some point, as long as we factor in the
>> fact that failure looks different for each request type.
>>
>
> The completion path also starts to get complicated, especially
> non-uniform handling of links there.
>
> i.e. io_put_req() -> io_put_req_find_next() ->
> io_free_req() -> __io_free_req()
> Plus, io_free_req_many(), which can be used only in some cases.
The many case is just for polling, I actually think that one is pretty
clean and self explanatory. But I agree on the proliferation of them
otherwise, at least the patches today cleaned it up a little.
> My compiler didn't even inlined it, so there are 4 CALLs.
> Though, still in TODO list.
Huh, that's odd!
--
Jens Axboe
prev parent reply other threads:[~2019-11-07 0:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 3:32 [PATCH] io_uring: fixup a few spots where link failure isn't flagged Jens Axboe
2019-11-06 18:44 ` Pavel Begunkov
2019-11-07 0:03 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29607ed7-a8a5-0208-b50a-f9feabcaa7fb@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.