* [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Wait for vblank before collecting CRC
@ 2021-05-21 4:08 ` Vidya Srinivas
0 siblings, 0 replies; 20+ messages in thread
From: Vidya Srinivas @ 2021-05-21 4:08 UTC (permalink / raw)
To: intel-gfx, dri-devel, igt-dev; +Cc: Charlton.Lin
Without wait for vblank, CRC mismatch is seen
between big and small CRC on few systems
Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
tests/kms_big_fb.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index b2027b6b9d1b..7d78ff829d41 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -254,6 +254,7 @@ static void unset_lut(data_t *data)
static bool test_plane(data_t *data)
{
igt_plane_t *plane = data->plane;
+ igt_display_t *display = &data->display;
struct igt_fb *small_fb = &data->small_fb;
struct igt_fb *big_fb = &data->big_fb;
int w = data->big_fb_width - small_fb->width;
@@ -337,16 +338,17 @@ static bool test_plane(data_t *data)
igt_display_commit2(&data->display, data->display.is_atomic ?
COMMIT_ATOMIC : COMMIT_UNIVERSAL);
-
+ igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
igt_plane_set_fb(plane, big_fb);
igt_fb_set_position(big_fb, plane, x, y);
igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height);
+
igt_plane_set_size(plane, data->width, data->height);
igt_display_commit2(&data->display, data->display.is_atomic ?
COMMIT_ATOMIC : COMMIT_UNIVERSAL);
-
+ igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
igt_plane_set_fb(plane, NULL);
--
2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 20+ messages in thread* [Intel-gfx] [PATCH i-g-t] tests/kms_big_fb: Wait for vblank before collecting CRC
@ 2021-05-21 4:08 ` Vidya Srinivas
0 siblings, 0 replies; 20+ messages in thread
From: Vidya Srinivas @ 2021-05-21 4:08 UTC (permalink / raw)
To: intel-gfx, dri-devel, igt-dev; +Cc: markyacoub, Charlton.Lin
Without wait for vblank, CRC mismatch is seen
between big and small CRC on few systems
Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
tests/kms_big_fb.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index b2027b6b9d1b..7d78ff829d41 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -254,6 +254,7 @@ static void unset_lut(data_t *data)
static bool test_plane(data_t *data)
{
igt_plane_t *plane = data->plane;
+ igt_display_t *display = &data->display;
struct igt_fb *small_fb = &data->small_fb;
struct igt_fb *big_fb = &data->big_fb;
int w = data->big_fb_width - small_fb->width;
@@ -337,16 +338,17 @@ static bool test_plane(data_t *data)
igt_display_commit2(&data->display, data->display.is_atomic ?
COMMIT_ATOMIC : COMMIT_UNIVERSAL);
-
+ igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
igt_plane_set_fb(plane, big_fb);
igt_fb_set_position(big_fb, plane, x, y);
igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height);
+
igt_plane_set_size(plane, data->width, data->height);
igt_display_commit2(&data->display, data->display.is_atomic ?
COMMIT_ATOMIC : COMMIT_UNIVERSAL);
-
+ igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
igt_plane_set_fb(plane, NULL);
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 20+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_big_fb: Wait for vblank before collecting CRC
2021-05-21 4:08 ` [Intel-gfx] " Vidya Srinivas
(?)
(?)
@ 2021-05-21 5:25 ` Patchwork
-1 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2021-05-21 5:25 UTC (permalink / raw)
To: Vidya Srinivas; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 5596 bytes --]
== Series Details ==
Series: tests/kms_big_fb: Wait for vblank before collecting CRC
URL : https://patchwork.freedesktop.org/series/90389/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10117 -> IGTPW_5829
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_5829:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_selftest@live@coherency:
- {fi-tgl-dsi}: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/fi-tgl-dsi/igt@i915_selftest@live@coherency.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/fi-tgl-dsi/igt@i915_selftest@live@coherency.html
Known issues
------------
Here are the changes found in IGTPW_5829 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload:
- fi-kbl-soraka: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/fi-kbl-soraka/igt@i915_module_load@reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/fi-kbl-soraka/igt@i915_module_load@reload.html
#### Warnings ####
* igt@i915_selftest@live@execlists:
- fi-cfl-8109u: [INCOMPLETE][5] ([i915#3462]) -> [DMESG-FAIL][6] ([i915#3462])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/fi-cfl-8109u/igt@i915_selftest@live@execlists.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/fi-cfl-8109u/igt@i915_selftest@live@execlists.html
- fi-bsw-kefka: [INCOMPLETE][7] ([i915#2782] / [i915#2940] / [i915#3462]) -> [DMESG-FAIL][8] ([i915#3462])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
* igt@runner@aborted:
- fi-skl-6600u: [FAIL][9] ([i915#1436] / [i915#3363]) -> [FAIL][10] ([i915#1436] / [i915#2426] / [i915#3363])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/fi-skl-6600u/igt@runner@aborted.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/fi-skl-6600u/igt@runner@aborted.html
- fi-cfl-8109u: [FAIL][11] ([i915#3363]) -> [FAIL][12] ([i915#2426] / [i915#3363])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/fi-cfl-8109u/igt@runner@aborted.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/fi-cfl-8109u/igt@runner@aborted.html
- fi-icl-u2: [FAIL][13] ([i915#2782] / [i915#3363]) -> [FAIL][14] ([i915#2426] / [i915#2782] / [i915#3363])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/fi-icl-u2/igt@runner@aborted.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/fi-icl-u2/igt@runner@aborted.html
- fi-bdw-5557u: [FAIL][15] ([i915#3462]) -> [FAIL][16] ([i915#1602] / [i915#2029])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/fi-bdw-5557u/igt@runner@aborted.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/fi-bdw-5557u/igt@runner@aborted.html
- fi-kbl-guc: [FAIL][17] ([i915#1436] / [i915#2426] / [i915#3363]) -> [FAIL][18] ([i915#1436] / [i915#3363])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/fi-kbl-guc/igt@runner@aborted.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/fi-kbl-guc/igt@runner@aborted.html
- fi-kbl-7567u: [FAIL][19] ([i915#1436] / [i915#2426] / [i915#3363]) -> [FAIL][20] ([i915#1436] / [i915#3363])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/fi-kbl-7567u/igt@runner@aborted.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/fi-kbl-7567u/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#2932]: https://gitlab.freedesktop.org/drm/intel/issues/2932
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#2966]: https://gitlab.freedesktop.org/drm/intel/issues/2966
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3462]: https://gitlab.freedesktop.org/drm/intel/issues/3462
Participating hosts (42 -> 38)
------------------------------
Missing (4): fi-dg1-1 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6090 -> IGTPW_5829
CI-20190529: 20190529
CI_DRM_10117: fd556c7e62d67a051bd6e288344470982b14cafe @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5829: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/index.html
IGT_6090: 8eeb9c130e75d4063d0dc2ed69c8acde66b6b5d0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/index.html
[-- Attachment #1.2: Type: text/html, Size: 7789 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Wait for vblank before collecting CRC
2021-05-21 4:08 ` [Intel-gfx] " Vidya Srinivas
@ 2021-05-21 11:29 ` Juha-Pekka Heikkila
-1 siblings, 0 replies; 20+ messages in thread
From: Juha-Pekka Heikkila @ 2021-05-21 11:29 UTC (permalink / raw)
To: Vidya Srinivas, intel-gfx, dri-devel, igt-dev; +Cc: Charlton.Lin
Hi Vidya,
on which machines this would help? I see there's many vblanks already
being waited. There's igt_display_commit2 which probably will block and
even if it didn't there's igt_pipe_crc_collect_crc(..) where crc
calculation is started after flip and then get one crc before disabling
crc counting again.
/Juha-Pekka
On 21.5.2021 7.08, Vidya Srinivas wrote:
> Without wait for vblank, CRC mismatch is seen
> between big and small CRC on few systems
>
> Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_big_fb.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
> index b2027b6b9d1b..7d78ff829d41 100644
> --- a/tests/kms_big_fb.c
> +++ b/tests/kms_big_fb.c
> @@ -254,6 +254,7 @@ static void unset_lut(data_t *data)
> static bool test_plane(data_t *data)
> {
> igt_plane_t *plane = data->plane;
> + igt_display_t *display = &data->display;
> struct igt_fb *small_fb = &data->small_fb;
> struct igt_fb *big_fb = &data->big_fb;
> int w = data->big_fb_width - small_fb->width;
> @@ -337,16 +338,17 @@ static bool test_plane(data_t *data)
> igt_display_commit2(&data->display, data->display.is_atomic ?
> COMMIT_ATOMIC : COMMIT_UNIVERSAL);
>
> -
> + igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
> igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
>
> igt_plane_set_fb(plane, big_fb);
> igt_fb_set_position(big_fb, plane, x, y);
> igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height);
> +
> igt_plane_set_size(plane, data->width, data->height);
> igt_display_commit2(&data->display, data->display.is_atomic ?
> COMMIT_ATOMIC : COMMIT_UNIVERSAL);
> -
> + igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
> igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
>
> igt_plane_set_fb(plane, NULL);
>
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Wait for vblank before collecting CRC
@ 2021-05-21 11:29 ` Juha-Pekka Heikkila
0 siblings, 0 replies; 20+ messages in thread
From: Juha-Pekka Heikkila @ 2021-05-21 11:29 UTC (permalink / raw)
To: Vidya Srinivas, intel-gfx, dri-devel, igt-dev; +Cc: Charlton.Lin
Hi Vidya,
on which machines this would help? I see there's many vblanks already
being waited. There's igt_display_commit2 which probably will block and
even if it didn't there's igt_pipe_crc_collect_crc(..) where crc
calculation is started after flip and then get one crc before disabling
crc counting again.
/Juha-Pekka
On 21.5.2021 7.08, Vidya Srinivas wrote:
> Without wait for vblank, CRC mismatch is seen
> between big and small CRC on few systems
>
> Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_big_fb.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
> index b2027b6b9d1b..7d78ff829d41 100644
> --- a/tests/kms_big_fb.c
> +++ b/tests/kms_big_fb.c
> @@ -254,6 +254,7 @@ static void unset_lut(data_t *data)
> static bool test_plane(data_t *data)
> {
> igt_plane_t *plane = data->plane;
> + igt_display_t *display = &data->display;
> struct igt_fb *small_fb = &data->small_fb;
> struct igt_fb *big_fb = &data->big_fb;
> int w = data->big_fb_width - small_fb->width;
> @@ -337,16 +338,17 @@ static bool test_plane(data_t *data)
> igt_display_commit2(&data->display, data->display.is_atomic ?
> COMMIT_ATOMIC : COMMIT_UNIVERSAL);
>
> -
> + igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
> igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
>
> igt_plane_set_fb(plane, big_fb);
> igt_fb_set_position(big_fb, plane, x, y);
> igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height);
> +
> igt_plane_set_size(plane, data->width, data->height);
> igt_display_commit2(&data->display, data->display.is_atomic ?
> COMMIT_ATOMIC : COMMIT_UNIVERSAL);
> -
> + igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
> igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
>
> igt_plane_set_fb(plane, NULL);
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread* RE: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Wait for vblank before collecting CRC
2021-05-21 11:29 ` [Intel-gfx] " Juha-Pekka Heikkila
(?)
@ 2021-05-21 14:22 ` Srinivas, Vidya
-1 siblings, 0 replies; 20+ messages in thread
From: Srinivas, Vidya @ 2021-05-21 14:22 UTC (permalink / raw)
To: juhapekka.heikkila, intel-gfx, dri-devel, igt-dev; +Cc: Lin, Charlton
Hello Juha-Pekka
We are seeing the CRC failures on Jasperlake systems. Sometimes the test passes and sometimes it fails throwing CRC error.
Regards
Vidya
-----Original Message-----
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Sent: Friday, May 21, 2021 5:00 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Cc: Lin, Charlton <charlton.lin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Wait for vblank before collecting CRC
Hi Vidya,
on which machines this would help? I see there's many vblanks already being waited. There's igt_display_commit2 which probably will block and even if it didn't there's igt_pipe_crc_collect_crc(..) where crc calculation is started after flip and then get one crc before disabling crc counting again.
/Juha-Pekka
On 21.5.2021 7.08, Vidya Srinivas wrote:
> Without wait for vblank, CRC mismatch is seen between big and small
> CRC on few systems
>
> Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_big_fb.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c index
> b2027b6b9d1b..7d78ff829d41 100644
> --- a/tests/kms_big_fb.c
> +++ b/tests/kms_big_fb.c
> @@ -254,6 +254,7 @@ static void unset_lut(data_t *data)
> static bool test_plane(data_t *data)
> {
> igt_plane_t *plane = data->plane;
> + igt_display_t *display = &data->display;
> struct igt_fb *small_fb = &data->small_fb;
> struct igt_fb *big_fb = &data->big_fb;
> int w = data->big_fb_width - small_fb->width; @@ -337,16 +338,17 @@
> static bool test_plane(data_t *data)
> igt_display_commit2(&data->display, data->display.is_atomic ?
> COMMIT_ATOMIC : COMMIT_UNIVERSAL);
>
> -
> + igt_wait_for_vblank(data->drm_fd,
> +display->pipes[data->pipe].crtc_offset);
> igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
>
> igt_plane_set_fb(plane, big_fb);
> igt_fb_set_position(big_fb, plane, x, y);
> igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height);
> +
> igt_plane_set_size(plane, data->width, data->height);
> igt_display_commit2(&data->display, data->display.is_atomic ?
> COMMIT_ATOMIC : COMMIT_UNIVERSAL);
> -
> + igt_wait_for_vblank(data->drm_fd,
> +display->pipes[data->pipe].crtc_offset);
> igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
>
> igt_plane_set_fb(plane, NULL);
>
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Wait for vblank before collecting CRC
@ 2021-05-21 14:22 ` Srinivas, Vidya
0 siblings, 0 replies; 20+ messages in thread
From: Srinivas, Vidya @ 2021-05-21 14:22 UTC (permalink / raw)
To: juhapekka.heikkila, intel-gfx, dri-devel, igt-dev; +Cc: Lin, Charlton
Hello Juha-Pekka
We are seeing the CRC failures on Jasperlake systems. Sometimes the test passes and sometimes it fails throwing CRC error.
Regards
Vidya
-----Original Message-----
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Sent: Friday, May 21, 2021 5:00 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Cc: Lin, Charlton <charlton.lin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Wait for vblank before collecting CRC
Hi Vidya,
on which machines this would help? I see there's many vblanks already being waited. There's igt_display_commit2 which probably will block and even if it didn't there's igt_pipe_crc_collect_crc(..) where crc calculation is started after flip and then get one crc before disabling crc counting again.
/Juha-Pekka
On 21.5.2021 7.08, Vidya Srinivas wrote:
> Without wait for vblank, CRC mismatch is seen between big and small
> CRC on few systems
>
> Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_big_fb.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c index
> b2027b6b9d1b..7d78ff829d41 100644
> --- a/tests/kms_big_fb.c
> +++ b/tests/kms_big_fb.c
> @@ -254,6 +254,7 @@ static void unset_lut(data_t *data)
> static bool test_plane(data_t *data)
> {
> igt_plane_t *plane = data->plane;
> + igt_display_t *display = &data->display;
> struct igt_fb *small_fb = &data->small_fb;
> struct igt_fb *big_fb = &data->big_fb;
> int w = data->big_fb_width - small_fb->width; @@ -337,16 +338,17 @@
> static bool test_plane(data_t *data)
> igt_display_commit2(&data->display, data->display.is_atomic ?
> COMMIT_ATOMIC : COMMIT_UNIVERSAL);
>
> -
> + igt_wait_for_vblank(data->drm_fd,
> +display->pipes[data->pipe].crtc_offset);
> igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
>
> igt_plane_set_fb(plane, big_fb);
> igt_fb_set_position(big_fb, plane, x, y);
> igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height);
> +
> igt_plane_set_size(plane, data->width, data->height);
> igt_display_commit2(&data->display, data->display.is_atomic ?
> COMMIT_ATOMIC : COMMIT_UNIVERSAL);
> -
> + igt_wait_for_vblank(data->drm_fd,
> +display->pipes[data->pipe].crtc_offset);
> igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
>
> igt_plane_set_fb(plane, NULL);
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Wait for vblank before collecting CRC
@ 2021-05-21 14:22 ` Srinivas, Vidya
0 siblings, 0 replies; 20+ messages in thread
From: Srinivas, Vidya @ 2021-05-21 14:22 UTC (permalink / raw)
To: juhapekka.heikkila, intel-gfx, dri-devel, igt-dev; +Cc: Lin, Charlton
Hello Juha-Pekka
We are seeing the CRC failures on Jasperlake systems. Sometimes the test passes and sometimes it fails throwing CRC error.
Regards
Vidya
-----Original Message-----
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Sent: Friday, May 21, 2021 5:00 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Cc: Lin, Charlton <charlton.lin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Wait for vblank before collecting CRC
Hi Vidya,
on which machines this would help? I see there's many vblanks already being waited. There's igt_display_commit2 which probably will block and even if it didn't there's igt_pipe_crc_collect_crc(..) where crc calculation is started after flip and then get one crc before disabling crc counting again.
/Juha-Pekka
On 21.5.2021 7.08, Vidya Srinivas wrote:
> Without wait for vblank, CRC mismatch is seen between big and small
> CRC on few systems
>
> Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_big_fb.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c index
> b2027b6b9d1b..7d78ff829d41 100644
> --- a/tests/kms_big_fb.c
> +++ b/tests/kms_big_fb.c
> @@ -254,6 +254,7 @@ static void unset_lut(data_t *data)
> static bool test_plane(data_t *data)
> {
> igt_plane_t *plane = data->plane;
> + igt_display_t *display = &data->display;
> struct igt_fb *small_fb = &data->small_fb;
> struct igt_fb *big_fb = &data->big_fb;
> int w = data->big_fb_width - small_fb->width; @@ -337,16 +338,17 @@
> static bool test_plane(data_t *data)
> igt_display_commit2(&data->display, data->display.is_atomic ?
> COMMIT_ATOMIC : COMMIT_UNIVERSAL);
>
> -
> + igt_wait_for_vblank(data->drm_fd,
> +display->pipes[data->pipe].crtc_offset);
> igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
>
> igt_plane_set_fb(plane, big_fb);
> igt_fb_set_position(big_fb, plane, x, y);
> igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height);
> +
> igt_plane_set_size(plane, data->width, data->height);
> igt_display_commit2(&data->display, data->display.is_atomic ?
> COMMIT_ATOMIC : COMMIT_UNIVERSAL);
> -
> + igt_wait_for_vblank(data->drm_fd,
> +display->pipes[data->pipe].crtc_offset);
> igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
>
> igt_plane_set_fb(plane, NULL);
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_big_fb: Wait for vblank before collecting CRC
2021-05-21 4:08 ` [Intel-gfx] " Vidya Srinivas
` (3 preceding siblings ...)
(?)
@ 2021-05-22 16:15 ` Patchwork
-1 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2021-05-22 16:15 UTC (permalink / raw)
To: Srinivas, Vidya; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 30273 bytes --]
== Series Details ==
Series: tests/kms_big_fb: Wait for vblank before collecting CRC
URL : https://patchwork.freedesktop.org/series/90389/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10117_full -> IGTPW_5829_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_5829_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_5829_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_5829_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-kbl: [PASS][1] -> [TIMEOUT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/shard-kbl7/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-kbl1/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
- shard-apl: NOTRUN -> [TIMEOUT][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-apl7/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
* igt@kms_vblank@pipe-a-ts-continuation-idle:
- shard-tglb: [PASS][4] -> [INCOMPLETE][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/shard-tglb5/igt@kms_vblank@pipe-a-ts-continuation-idle.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb6/igt@kms_vblank@pipe-a-ts-continuation-idle.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes}:
- shard-kbl: [PASS][6] -> [INCOMPLETE][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
Known issues
------------
Here are the changes found in IGTPW_5829_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@legacy-engines-queued:
- shard-snb: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#1099]) +10 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-snb6/igt@gem_ctx_persistence@legacy-engines-queued.html
* igt@gem_ctx_persistence@many-contexts:
- shard-tglb: [PASS][9] -> [FAIL][10] ([i915#2410])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/shard-tglb2/igt@gem_ctx_persistence@many-contexts.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb8/igt@gem_ctx_persistence@many-contexts.html
* igt@gem_eio@unwedge-stress:
- shard-tglb: [PASS][11] -> [TIMEOUT][12] ([i915#2369] / [i915#3063])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/shard-tglb7/igt@gem_eio@unwedge-stress.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb5/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-deadline:
- shard-apl: NOTRUN -> [FAIL][13] ([i915#2846])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-apl7/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: NOTRUN -> [FAIL][14] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb5/igt@gem_exec_fair@basic-none-rrul@rcs0.html
- shard-glk: NOTRUN -> [FAIL][15] ([i915#2842])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-glk2/igt@gem_exec_fair@basic-none-rrul@rcs0.html
- shard-tglb: NOTRUN -> [FAIL][16] ([i915#2842])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb6/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-none@rcs0:
- shard-glk: [PASS][17] -> [FAIL][18] ([i915#2842])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/shard-glk5/igt@gem_exec_fair@basic-none@rcs0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-glk3/igt@gem_exec_fair@basic-none@rcs0.html
* igt@gem_exec_params@sol-reset-not-gen7:
- shard-glk: [PASS][19] -> [DMESG-WARN][20] ([i915#118] / [i915#95]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/shard-glk3/igt@gem_exec_params@sol-reset-not-gen7.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-glk3/igt@gem_exec_params@sol-reset-not-gen7.html
* igt@gem_exec_reloc@basic-wide-active@bcs0:
- shard-apl: NOTRUN -> [FAIL][21] ([i915#2389]) +3 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-apl3/igt@gem_exec_reloc@basic-wide-active@bcs0.html
- shard-glk: NOTRUN -> [FAIL][22] ([i915#2389]) +3 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-glk3/igt@gem_exec_reloc@basic-wide-active@bcs0.html
- shard-tglb: NOTRUN -> [FAIL][23] ([i915#2389]) +4 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb8/igt@gem_exec_reloc@basic-wide-active@bcs0.html
* igt@gem_exec_reloc@basic-wide-active@rcs0:
- shard-snb: NOTRUN -> [FAIL][24] ([i915#2389]) +2 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-snb5/igt@gem_exec_reloc@basic-wide-active@rcs0.html
- shard-iclb: NOTRUN -> [FAIL][25] ([i915#2389]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb5/igt@gem_exec_reloc@basic-wide-active@rcs0.html
- shard-kbl: NOTRUN -> [FAIL][26] ([i915#2389]) +4 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-kbl3/igt@gem_exec_reloc@basic-wide-active@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#2190])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-apl8/igt@gem_huc_copy@huc-copy.html
* igt@gem_mmap_gtt@cpuset-basic-small-copy-odd:
- shard-apl: [PASS][28] -> [INCOMPLETE][29] ([i915#3468])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/shard-apl8/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-apl2/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html
* igt@gem_mmap_gtt@cpuset-basic-small-copy-xy:
- shard-apl: NOTRUN -> [INCOMPLETE][30] ([i915#3468])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-apl6/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html
* igt@gem_mmap_gtt@fault-concurrent-x:
- shard-kbl: NOTRUN -> [INCOMPLETE][31] ([i915#3468])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-kbl4/igt@gem_mmap_gtt@fault-concurrent-x.html
* igt@gem_mmap_gtt@medium-copy-xy:
- shard-apl: NOTRUN -> [INCOMPLETE][32] ([i915#2502] / [i915#3468])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-apl6/igt@gem_mmap_gtt@medium-copy-xy.html
* igt@gem_pread@exhaustion:
- shard-tglb: NOTRUN -> [WARN][33] ([i915#2658])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb2/igt@gem_pread@exhaustion.html
- shard-glk: NOTRUN -> [WARN][34] ([i915#2658])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-glk1/igt@gem_pread@exhaustion.html
- shard-apl: NOTRUN -> [WARN][35] ([i915#2658])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-apl1/igt@gem_pread@exhaustion.html
- shard-iclb: NOTRUN -> [WARN][36] ([i915#2658])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb3/igt@gem_pread@exhaustion.html
- shard-kbl: NOTRUN -> [WARN][37] ([i915#2658])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-kbl7/igt@gem_pread@exhaustion.html
* igt@gem_pwrite@basic-exhaustion:
- shard-snb: NOTRUN -> [WARN][38] ([i915#2658])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-snb7/igt@gem_pwrite@basic-exhaustion.html
* igt@gem_render_copy@x-tiled-to-vebox-y-tiled:
- shard-iclb: NOTRUN -> [SKIP][39] ([i915#768])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb3/igt@gem_render_copy@x-tiled-to-vebox-y-tiled.html
* igt@gem_userptr_blits@access-control:
- shard-tglb: NOTRUN -> [SKIP][40] ([i915#3297]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb3/igt@gem_userptr_blits@access-control.html
- shard-iclb: NOTRUN -> [SKIP][41] ([i915#3297])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb1/igt@gem_userptr_blits@access-control.html
* igt@gem_userptr_blits@coherency-sync:
- shard-tglb: NOTRUN -> [SKIP][42] ([fdo#110542])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb1/igt@gem_userptr_blits@coherency-sync.html
- shard-iclb: NOTRUN -> [SKIP][43] ([fdo#109290])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb3/igt@gem_userptr_blits@coherency-sync.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-kbl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#3323])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-kbl3/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@vma-merge:
- shard-snb: NOTRUN -> [FAIL][45] ([i915#2724])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-snb6/igt@gem_userptr_blits@vma-merge.html
* igt@gen7_exec_parse@batch-without-end:
- shard-iclb: NOTRUN -> [SKIP][46] ([fdo#109289])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb5/igt@gen7_exec_parse@batch-without-end.html
- shard-tglb: NOTRUN -> [SKIP][47] ([fdo#109289])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb8/igt@gen7_exec_parse@batch-without-end.html
* igt@gen9_exec_parse@basic-rejected-ctx-param:
- shard-tglb: NOTRUN -> [SKIP][48] ([fdo#112306]) +2 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb3/igt@gen9_exec_parse@basic-rejected-ctx-param.html
* igt@gen9_exec_parse@batch-zero-length:
- shard-iclb: NOTRUN -> [SKIP][49] ([fdo#112306]) +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb3/igt@gen9_exec_parse@batch-zero-length.html
* igt@gen9_exec_parse@bb-large:
- shard-kbl: NOTRUN -> [FAIL][50] ([i915#3296])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-kbl7/igt@gen9_exec_parse@bb-large.html
* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-iclb: NOTRUN -> [SKIP][51] ([fdo#109293] / [fdo#109506]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb5/igt@i915_pm_rpm@gem-execbuf-stress-pc8.html
* igt@i915_pm_rpm@modeset-pc8-residency-stress:
- shard-tglb: NOTRUN -> [SKIP][52] ([fdo#109506] / [i915#2411]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb3/igt@i915_pm_rpm@modeset-pc8-residency-stress.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: NOTRUN -> [INCOMPLETE][53] ([i915#2782])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-snb5/igt@i915_selftest@live@hangcheck.html
* igt@i915_suspend@forcewake:
- shard-kbl: [PASS][54] -> [DMESG-WARN][55] ([i915#180]) +2 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/shard-kbl2/igt@i915_suspend@forcewake.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-kbl2/igt@i915_suspend@forcewake.html
* igt@kms_big_fb@x-tiled-64bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][56] ([fdo#110725] / [fdo#111614]) +2 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb6/igt@kms_big_fb@x-tiled-64bpp-rotate-270.html
- shard-tglb: NOTRUN -> [SKIP][57] ([fdo#111614])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb5/igt@kms_big_fb@x-tiled-64bpp-rotate-270.html
* igt@kms_big_fb@yf-tiled-8bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][58] ([fdo#110723])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb5/igt@kms_big_fb@yf-tiled-8bpp-rotate-270.html
* igt@kms_ccs@pipe-d-bad-rotation-90:
- shard-iclb: NOTRUN -> [SKIP][59] ([fdo#109278]) +21 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb3/igt@kms_ccs@pipe-d-bad-rotation-90.html
* igt@kms_chamelium@hdmi-aspect-ratio:
- shard-glk: NOTRUN -> [SKIP][60] ([fdo#109271] / [fdo#111827]) +9 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-glk3/igt@kms_chamelium@hdmi-aspect-ratio.html
* igt@kms_chamelium@vga-hpd:
- shard-apl: NOTRUN -> [SKIP][61] ([fdo#109271] / [fdo#111827]) +22 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-apl7/igt@kms_chamelium@vga-hpd.html
* igt@kms_chamelium@vga-hpd-with-enabled-mode:
- shard-iclb: NOTRUN -> [SKIP][62] ([fdo#109284] / [fdo#111827]) +10 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb3/igt@kms_chamelium@vga-hpd-with-enabled-mode.html
* igt@kms_chamelium@vga-hpd-without-ddc:
- shard-snb: NOTRUN -> [SKIP][63] ([fdo#109271] / [fdo#111827]) +36 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-snb6/igt@kms_chamelium@vga-hpd-without-ddc.html
* igt@kms_color_chamelium@pipe-b-ctm-0-75:
- shard-tglb: NOTRUN -> [SKIP][64] ([fdo#109284] / [fdo#111827]) +10 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb1/igt@kms_color_chamelium@pipe-b-ctm-0-75.html
* igt@kms_color_chamelium@pipe-d-ctm-limited-range:
- shard-iclb: NOTRUN -> [SKIP][65] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb5/igt@kms_color_chamelium@pipe-d-ctm-limited-range.html
* igt@kms_color_chamelium@pipe-invalid-gamma-lut-sizes:
- shard-kbl: NOTRUN -> [SKIP][66] ([fdo#109271] / [fdo#111827]) +15 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-kbl2/igt@kms_color_chamelium@pipe-invalid-gamma-lut-sizes.html
* igt@kms_content_protection@atomic:
- shard-kbl: NOTRUN -> [TIMEOUT][67] ([i915#1319]) +3 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-kbl4/igt@kms_content_protection@atomic.html
* igt@kms_content_protection@legacy:
- shard-iclb: NOTRUN -> [SKIP][68] ([fdo#109300] / [fdo#111066]) +2 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb1/igt@kms_content_protection@legacy.html
- shard-apl: NOTRUN -> [TIMEOUT][69] ([i915#1319])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-apl2/igt@kms_content_protection@legacy.html
* igt@kms_content_protection@srm:
- shard-tglb: NOTRUN -> [SKIP][70] ([fdo#111828]) +2 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb1/igt@kms_content_protection@srm.html
* igt@kms_cursor_crc@pipe-b-cursor-512x512-sliding:
- shard-iclb: NOTRUN -> [SKIP][71] ([fdo#109278] / [fdo#109279]) +2 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb3/igt@kms_cursor_crc@pipe-b-cursor-512x512-sliding.html
- shard-tglb: NOTRUN -> [SKIP][72] ([fdo#109279] / [i915#3359])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb1/igt@kms_cursor_crc@pipe-b-cursor-512x512-sliding.html
* igt@kms_cursor_crc@pipe-c-cursor-32x32-offscreen:
- shard-tglb: NOTRUN -> [SKIP][73] ([i915#3319]) +3 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb3/igt@kms_cursor_crc@pipe-c-cursor-32x32-offscreen.html
* igt@kms_cursor_crc@pipe-c-cursor-max-size-offscreen:
- shard-tglb: NOTRUN -> [SKIP][74] ([i915#3359]) +3 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb3/igt@kms_cursor_crc@pipe-c-cursor-max-size-offscreen.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-iclb: NOTRUN -> [SKIP][75] ([fdo#109274] / [fdo#109278]) +4 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb6/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
* igt@kms_dp_dsc@basic-dsc-enable-dp:
- shard-tglb: NOTRUN -> [SKIP][76] ([fdo#109349])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb5/igt@kms_dp_dsc@basic-dsc-enable-dp.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: NOTRUN -> [SKIP][77] ([fdo#109349]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb3/igt@kms_dp_dsc@basic-dsc-enable-edp.html
* igt@kms_flip@2x-plain-flip-ts-check:
- shard-tglb: NOTRUN -> [SKIP][78] ([fdo#111825]) +29 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb3/igt@kms_flip@2x-plain-flip-ts-check.html
- shard-iclb: NOTRUN -> [SKIP][79] ([fdo#109274]) +5 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb1/igt@kms_flip@2x-plain-flip-ts-check.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
- shard-apl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#2672])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-apl3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-apl: NOTRUN -> [FAIL][81] ([i915#49])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-apl8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-blt:
- shard-kbl: NOTRUN -> [SKIP][82] ([fdo#109271]) +147 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbc-2p-shrfb-fliptrack-mmap-gtt:
- shard-iclb: NOTRUN -> [SKIP][83] ([fdo#109280]) +21 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-2p-shrfb-fliptrack-mmap-gtt.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][84] ([i915#180]) +9 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-kbl2/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_invalid_dotclock:
- shard-iclb: NOTRUN -> [SKIP][85] ([fdo#109310])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb3/igt@kms_invalid_dotclock.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- shard-apl: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#533])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-apl7/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][87] ([fdo#108145] / [i915#265]) +4 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-apl7/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][88] ([fdo#108145] / [i915#265]) +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-kbl2/igt@kms_plane_alpha_blend@pipe-b-alpha-7efc.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-glk: NOTRUN -> [FAIL][89] ([fdo#108145] / [i915#265])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-glk3/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][90] ([i915#265])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-apl1/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-d-alpha-opaque-fb:
- shard-glk: NOTRUN -> [SKIP][91] ([fdo#109271]) +81 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-glk5/igt@kms_plane_alpha_blend@pipe-d-alpha-opaque-fb.html
* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][92] ([fdo#111615]) +2 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb5/igt@kms_plane_multiple@atomic-pipe-b-tiling-yf.html
* igt@kms_plane_multiple@atomic-pipe-d-tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][93] ([fdo#112054])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb6/igt@kms_plane_multiple@atomic-pipe-d-tiling-yf.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-kbl: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#2733])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-kbl2/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-kbl: NOTRUN -> [SKIP][95] ([fdo#109271] / [i915#658]) +3 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-kbl7/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-2:
- shard-apl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#658]) +4 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-apl6/igt@kms_psr2_sf@plane-move-sf-dmg-area-2.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-iclb: NOTRUN -> [SKIP][97] ([i915#658]) +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb3/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
- shard-glk: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#658]) +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-glk7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3:
- shard-tglb: NOTRUN -> [SKIP][99] ([i915#2920]) +1 similar issue
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb8/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: NOTRUN -> [SKIP][100] ([fdo#109441]) +3 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb6/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-tglb: NOTRUN -> [FAIL][101] ([i915#132] / [i915#3467]) +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb5/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_setmode@basic:
- shard-snb: NOTRUN -> [FAIL][102] ([i915#31])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-snb7/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-d-query-forked-hang:
- shard-snb: NOTRUN -> [SKIP][103] ([fdo#109271]) +628 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-snb6/igt@kms_vblank@pipe-d-query-forked-hang.html
* igt@kms_vblank@pipe-d-ts-continuation-idle:
- shard-apl: NOTRUN -> [SKIP][104] ([fdo#109271]) +242 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-apl1/igt@kms_vblank@pipe-d-ts-continuation-idle.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-kbl: NOTRUN -> [SKIP][105] ([fdo#109271] / [i915#533])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-kbl1/igt@kms_vblank@pipe-d-wait-idle.html
- shard-glk: NOTRUN -> [SKIP][106] ([fdo#109271] / [i915#533])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-glk6/igt@kms_vblank@pipe-d-wait-idle.html
* igt@kms_vrr@flip-suspend:
- shard-iclb: NOTRUN -> [SKIP][107] ([fdo#109502]) +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb6/igt@kms_vrr@flip-suspend.html
* igt@kms_vrr@flipline:
- shard-tglb: NOTRUN -> [SKIP][108] ([fdo#109502]) +1 similar issue
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb6/igt@kms_vrr@flipline.html
* igt@kms_writeback@writeback-fb-id:
- shard-kbl: NOTRUN -> [SKIP][109] ([fdo#109271] / [i915#2437])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-kbl2/igt@kms_writeback@writeback-fb-id.html
* igt@nouveau_crc@pipe-c-source-outp-complete:
- shard-tglb: NOTRUN -> [SKIP][110] ([i915#2530]) +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb7/igt@nouveau_crc@pipe-c-source-outp-complete.html
- shard-iclb: NOTRUN -> [SKIP][111] ([i915#2530]) +1 similar issue
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb6/igt@nouveau_crc@pipe-c-source-outp-complete.html
* igt@perf_pmu@event-wait@rcs0:
- shard-iclb: NOTRUN -> [SKIP][112] ([fdo#112283])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb5/igt@perf_pmu@event-wait@rcs0.html
- shard-tglb: NOTRUN -> [SKIP][113] ([fdo#112283])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb3/igt@perf_pmu@event-wait@rcs0.html
* igt@prime_nv_api@i915_nv_import_vs_close:
- shard-tglb: NOTRUN -> [SKIP][114] ([fdo#109291])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb3/igt@prime_nv_api@i915_nv_import_vs_close.html
* igt@prime_nv_test@nv_write_i915_gtt_mmap_read:
- shard-iclb: NOTRUN -> [SKIP][115] ([fdo#109291]) +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb1/igt@prime_nv_test@nv_write_i915_gtt_mmap_read.html
* igt@prime_vgem@fence-flip-hang:
- shard-iclb: NOTRUN -> [SKIP][116] ([fdo#109295])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb6/igt@prime_vgem@fence-flip-hang.html
- shard-tglb: NOTRUN -> [SKIP][117] ([fdo#109295])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb7/igt@prime_vgem@fence-flip-hang.html
* igt@sysfs_clients@fair-0:
- shard-tglb: NOTRUN -> [SKIP][118] ([i915#2994])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb2/igt@sysfs_clients@fair-0.html
- shard-glk: NOTRUN -> [SKIP][119] ([fdo#109271] / [i915#2994])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-glk1/igt@sysfs_clients@fair-0.html
* igt@sysfs_clients@recycle-many:
- shard-kbl: NOTRUN -> [SKIP][120] ([fdo#109271] / [i915#2994])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-kbl2/igt@sysfs_clients@recycle-many.html
* igt@sysfs_clients@sema-10:
- shard-apl: NOTRUN -> [SKIP][121] ([fdo#109271] / [i915#2994]) +3 similar issues
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-apl3/igt@sysfs_clients@sema-10.html
#### Possible fixes ####
* igt@gem_exec_fair@basic-none@vecs0:
- shard-kbl: [FAIL][122] ([i915#2842]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/shard-kbl7/igt@gem_exec_fair@basic-none@vecs0.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-kbl7/igt@gem_exec_fair@basic-none@vecs0.html
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-tglb: [FAIL][124] ([i915#2842]) -> [PASS][125] +1 similar issue
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/shard-tglb3/igt@gem_exec_fair@basic-pace@bcs0.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb3/igt@gem_exec_fair@basic-pace@bcs0.html
* igt@gem_exec_suspend@basic-s3:
- shard-apl: [DMESG-WARN][126] ([i915#180]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/shard-apl1/igt@gem_exec_suspend@basic-s3.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-apl2/igt@gem_exec_suspend@basic-s3.html
* igt@gem_mmap_gtt@cpuset-basic-small-copy:
- shard-glk: [INCOMPLETE][128] ([i915#2055] / [i915#3468]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/shard-glk4/igt@gem_mmap_gtt@cpuset-basic-small-copy.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-glk1/igt@gem_mmap_gtt@cpuset-basic-small-copy.html
- shard-tglb: [INCOMPLETE][130] ([i915#3468]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/shard-tglb5/igt@gem_mmap_gtt@cpuset-basic-small-copy.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-tglb2/igt@gem_mmap_gtt@cpuset-basic-small-copy.html
* igt@gem_mmap_gtt@cpuset-basic-small-copy-xy:
- shard-iclb: [INCOMPLETE][132] ([i915#3468]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10117/shard-iclb6/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/shard-iclb3/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html
* igt@gem_mmap_gtt@cpuset-medium-copy-xy:
- shard-kbl: [INCOMPLETE][134] ([i915#3468]) -> [PASS][135]
[134]:
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5829/index.html
[-- Attachment #1.2: Type: text/html, Size: 34029 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 20+ messages in thread* [Intel-gfx] [PATCH 4/4] [RFC] tests/kms_big_fb: Wait for vblank before collecting CRC
2021-05-21 4:08 ` [Intel-gfx] " Vidya Srinivas
@ 2021-05-27 14:31 ` Vidya Srinivas
-1 siblings, 0 replies; 20+ messages in thread
From: Vidya Srinivas @ 2021-05-27 14:31 UTC (permalink / raw)
To: intel-gfx, igt-dev; +Cc: markyacoub, charlton.lin
Without wait for vblank, CRC mismatch is seen
between big and small CRC on some intel Gen11 platforms.
Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
tests/kms_big_fb.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index b2027b6b9d1b..da682593429b 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -254,6 +254,7 @@ static void unset_lut(data_t *data)
static bool test_plane(data_t *data)
{
igt_plane_t *plane = data->plane;
+ igt_display_t *display = &data->display;
struct igt_fb *small_fb = &data->small_fb;
struct igt_fb *big_fb = &data->big_fb;
int w = data->big_fb_width - small_fb->width;
@@ -269,6 +270,7 @@ static bool test_plane(data_t *data)
{ w / 3, h * 3 / 4, },
{ w, h, },
};
+ bool check_platform_intel = is_i915_device(data->drm_fd);
if (!igt_plane_has_format_mod(plane, data->format, data->modifier))
return false;
@@ -336,17 +338,19 @@ static bool test_plane(data_t *data)
igt_display_commit2(&data->display, data->display.is_atomic ?
COMMIT_ATOMIC : COMMIT_UNIVERSAL);
-
-
+ if (check_platform_intel)
+ igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
igt_plane_set_fb(plane, big_fb);
igt_fb_set_position(big_fb, plane, x, y);
igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height);
+
igt_plane_set_size(plane, data->width, data->height);
igt_display_commit2(&data->display, data->display.is_atomic ?
COMMIT_ATOMIC : COMMIT_UNIVERSAL);
-
+ if (check_platform_intel)
+ igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
igt_plane_set_fb(plane, NULL);
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 20+ messages in thread* [igt-dev] [PATCH 4/4] [RFC] tests/kms_big_fb: Wait for vblank before collecting CRC
@ 2021-05-27 14:31 ` Vidya Srinivas
0 siblings, 0 replies; 20+ messages in thread
From: Vidya Srinivas @ 2021-05-27 14:31 UTC (permalink / raw)
To: intel-gfx, igt-dev; +Cc: charlton.lin
Without wait for vblank, CRC mismatch is seen
between big and small CRC on some intel Gen11 platforms.
Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
tests/kms_big_fb.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index b2027b6b9d1b..da682593429b 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -254,6 +254,7 @@ static void unset_lut(data_t *data)
static bool test_plane(data_t *data)
{
igt_plane_t *plane = data->plane;
+ igt_display_t *display = &data->display;
struct igt_fb *small_fb = &data->small_fb;
struct igt_fb *big_fb = &data->big_fb;
int w = data->big_fb_width - small_fb->width;
@@ -269,6 +270,7 @@ static bool test_plane(data_t *data)
{ w / 3, h * 3 / 4, },
{ w, h, },
};
+ bool check_platform_intel = is_i915_device(data->drm_fd);
if (!igt_plane_has_format_mod(plane, data->format, data->modifier))
return false;
@@ -336,17 +338,19 @@ static bool test_plane(data_t *data)
igt_display_commit2(&data->display, data->display.is_atomic ?
COMMIT_ATOMIC : COMMIT_UNIVERSAL);
-
-
+ if (check_platform_intel)
+ igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
igt_plane_set_fb(plane, big_fb);
igt_fb_set_position(big_fb, plane, x, y);
igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height);
+
igt_plane_set_size(plane, data->width, data->height);
igt_display_commit2(&data->display, data->display.is_atomic ?
COMMIT_ATOMIC : COMMIT_UNIVERSAL);
-
+ if (check_platform_intel)
+ igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
igt_plane_set_fb(plane, NULL);
--
2.26.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 20+ messages in thread* [Intel-gfx] [PATCH] [RFC] tests/kms_big_fb: Wait for vblank before collecting CRC
2021-05-27 14:31 ` [igt-dev] " Vidya Srinivas
@ 2021-05-27 15:09 ` Vidya Srinivas
-1 siblings, 0 replies; 20+ messages in thread
From: Vidya Srinivas @ 2021-05-27 15:09 UTC (permalink / raw)
To: intel-gfx, igt-dev; +Cc: markyacoub, charlton.lin
Without wait for vblank, CRC mismatch is seen between
big and small CRC on some Gen11 systems
Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
tests/kms_big_fb.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index b2027b6b9d1b..7d78ff829d41 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -254,6 +254,7 @@ static void unset_lut(data_t *data)
static bool test_plane(data_t *data)
{
igt_plane_t *plane = data->plane;
+ igt_display_t *display = &data->display;
struct igt_fb *small_fb = &data->small_fb;
struct igt_fb *big_fb = &data->big_fb;
int w = data->big_fb_width - small_fb->width;
@@ -337,16 +338,17 @@ static bool test_plane(data_t *data)
igt_display_commit2(&data->display, data->display.is_atomic ?
COMMIT_ATOMIC : COMMIT_UNIVERSAL);
-
+ igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
igt_plane_set_fb(plane, big_fb);
igt_fb_set_position(big_fb, plane, x, y);
igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height);
+
igt_plane_set_size(plane, data->width, data->height);
igt_display_commit2(&data->display, data->display.is_atomic ?
COMMIT_ATOMIC : COMMIT_UNIVERSAL);
-
+ igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
igt_plane_set_fb(plane, NULL);
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 20+ messages in thread* [igt-dev] [PATCH] [RFC] tests/kms_big_fb: Wait for vblank before collecting CRC
@ 2021-05-27 15:09 ` Vidya Srinivas
0 siblings, 0 replies; 20+ messages in thread
From: Vidya Srinivas @ 2021-05-27 15:09 UTC (permalink / raw)
To: intel-gfx, igt-dev; +Cc: charlton.lin
Without wait for vblank, CRC mismatch is seen between
big and small CRC on some Gen11 systems
Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
tests/kms_big_fb.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index b2027b6b9d1b..7d78ff829d41 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -254,6 +254,7 @@ static void unset_lut(data_t *data)
static bool test_plane(data_t *data)
{
igt_plane_t *plane = data->plane;
+ igt_display_t *display = &data->display;
struct igt_fb *small_fb = &data->small_fb;
struct igt_fb *big_fb = &data->big_fb;
int w = data->big_fb_width - small_fb->width;
@@ -337,16 +338,17 @@ static bool test_plane(data_t *data)
igt_display_commit2(&data->display, data->display.is_atomic ?
COMMIT_ATOMIC : COMMIT_UNIVERSAL);
-
+ igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
igt_plane_set_fb(plane, big_fb);
igt_fb_set_position(big_fb, plane, x, y);
igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height);
+
igt_plane_set_size(plane, data->width, data->height);
igt_display_commit2(&data->display, data->display.is_atomic ?
COMMIT_ATOMIC : COMMIT_UNIVERSAL);
-
+ igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
igt_plane_set_fb(plane, NULL);
--
2.26.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 20+ messages in thread* [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_big_fb: Wait for vblank before collecting CRC
2021-05-27 15:09 ` [igt-dev] " Vidya Srinivas
@ 2021-05-27 15:23 ` Vidya Srinivas
-1 siblings, 0 replies; 20+ messages in thread
From: Vidya Srinivas @ 2021-05-27 15:23 UTC (permalink / raw)
To: intel-gfx, igt-dev; +Cc: markyacoub, charlton.lin
Without wait for vblank, CRC mismatch is seen
between big and small CRC on few Gen11 systems.
Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
tests/kms_big_fb.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index b2027b6b9d1b..7d78ff829d41 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -254,6 +254,7 @@ static void unset_lut(data_t *data)
static bool test_plane(data_t *data)
{
igt_plane_t *plane = data->plane;
+ igt_display_t *display = &data->display;
struct igt_fb *small_fb = &data->small_fb;
struct igt_fb *big_fb = &data->big_fb;
int w = data->big_fb_width - small_fb->width;
@@ -337,16 +338,17 @@ static bool test_plane(data_t *data)
igt_display_commit2(&data->display, data->display.is_atomic ?
COMMIT_ATOMIC : COMMIT_UNIVERSAL);
-
+ igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
igt_plane_set_fb(plane, big_fb);
igt_fb_set_position(big_fb, plane, x, y);
igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height);
+
igt_plane_set_size(plane, data->width, data->height);
igt_display_commit2(&data->display, data->display.is_atomic ?
COMMIT_ATOMIC : COMMIT_UNIVERSAL);
-
+ igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
igt_plane_set_fb(plane, NULL);
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 20+ messages in thread* [igt-dev] [PATCH i-g-t] [RFC] tests/kms_big_fb: Wait for vblank before collecting CRC
@ 2021-05-27 15:23 ` Vidya Srinivas
0 siblings, 0 replies; 20+ messages in thread
From: Vidya Srinivas @ 2021-05-27 15:23 UTC (permalink / raw)
To: intel-gfx, igt-dev; +Cc: charlton.lin
Without wait for vblank, CRC mismatch is seen
between big and small CRC on few Gen11 systems.
Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
tests/kms_big_fb.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index b2027b6b9d1b..7d78ff829d41 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -254,6 +254,7 @@ static void unset_lut(data_t *data)
static bool test_plane(data_t *data)
{
igt_plane_t *plane = data->plane;
+ igt_display_t *display = &data->display;
struct igt_fb *small_fb = &data->small_fb;
struct igt_fb *big_fb = &data->big_fb;
int w = data->big_fb_width - small_fb->width;
@@ -337,16 +338,17 @@ static bool test_plane(data_t *data)
igt_display_commit2(&data->display, data->display.is_atomic ?
COMMIT_ATOMIC : COMMIT_UNIVERSAL);
-
+ igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
igt_plane_set_fb(plane, big_fb);
igt_fb_set_position(big_fb, plane, x, y);
igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height);
+
igt_plane_set_size(plane, data->width, data->height);
igt_display_commit2(&data->display, data->display.is_atomic ?
COMMIT_ATOMIC : COMMIT_UNIVERSAL);
-
+ igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
igt_plane_set_fb(plane, NULL);
--
2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [igt-dev] [PATCH 4/4] [RFC] tests/kms_big_fb: Wait for vblank before collecting CRC
2021-05-27 14:31 ` [igt-dev] " Vidya Srinivas
@ 2021-05-27 15:09 ` Juha-Pekka Heikkila
-1 siblings, 0 replies; 20+ messages in thread
From: Juha-Pekka Heikkila @ 2021-05-27 15:09 UTC (permalink / raw)
To: Vidya Srinivas, intel-gfx, igt-dev; +Cc: charlton.lin
On 27.5.2021 17.31, Vidya Srinivas wrote:
> Without wait for vblank, CRC mismatch is seen
> between big and small CRC on some intel Gen11 platforms.
>
> Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_big_fb.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
> index b2027b6b9d1b..da682593429b 100644
> --- a/tests/kms_big_fb.c
> +++ b/tests/kms_big_fb.c
> @@ -254,6 +254,7 @@ static void unset_lut(data_t *data)
> static bool test_plane(data_t *data)
> {
> igt_plane_t *plane = data->plane;
> + igt_display_t *display = &data->display;
> struct igt_fb *small_fb = &data->small_fb;
> struct igt_fb *big_fb = &data->big_fb;
> int w = data->big_fb_width - small_fb->width;
> @@ -269,6 +270,7 @@ static bool test_plane(data_t *data)
> { w / 3, h * 3 / 4, },
> { w, h, },
> };
> + bool check_platform_intel = is_i915_device(data->drm_fd);
You will not need to do this. This test start with
drm_open_driver_master(DRIVER_INTEL)
hence will always be only on intel device.
>
> if (!igt_plane_has_format_mod(plane, data->format, data->modifier))
> return false;
> @@ -336,17 +338,19 @@ static bool test_plane(data_t *data)
>
> igt_display_commit2(&data->display, data->display.is_atomic ?
> COMMIT_ATOMIC : COMMIT_UNIVERSAL);
> -
> -
> + if (check_platform_intel)
> + igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
Above this line there's flip to different framebuffer and below this
line there's restart of crc collection before get any crc. If there's
need to wait a vblank at this place to get matching crcs the actual bug
is somewhere else.
> igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
>
> igt_plane_set_fb(plane, big_fb);
> igt_fb_set_position(big_fb, plane, x, y);
> igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height);
> +
> igt_plane_set_size(plane, data->width, data->height);
> igt_display_commit2(&data->display, data->display.is_atomic ?
> COMMIT_ATOMIC : COMMIT_UNIVERSAL);
> -
> + if (check_platform_intel)
> + igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
Here it's the same story as above.
> igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
>
> igt_plane_set_fb(plane, NULL);
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [igt-dev] [PATCH 4/4] [RFC] tests/kms_big_fb: Wait for vblank before collecting CRC
@ 2021-05-27 15:09 ` Juha-Pekka Heikkila
0 siblings, 0 replies; 20+ messages in thread
From: Juha-Pekka Heikkila @ 2021-05-27 15:09 UTC (permalink / raw)
To: Vidya Srinivas, intel-gfx, igt-dev; +Cc: charlton.lin
On 27.5.2021 17.31, Vidya Srinivas wrote:
> Without wait for vblank, CRC mismatch is seen
> between big and small CRC on some intel Gen11 platforms.
>
> Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_big_fb.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
> index b2027b6b9d1b..da682593429b 100644
> --- a/tests/kms_big_fb.c
> +++ b/tests/kms_big_fb.c
> @@ -254,6 +254,7 @@ static void unset_lut(data_t *data)
> static bool test_plane(data_t *data)
> {
> igt_plane_t *plane = data->plane;
> + igt_display_t *display = &data->display;
> struct igt_fb *small_fb = &data->small_fb;
> struct igt_fb *big_fb = &data->big_fb;
> int w = data->big_fb_width - small_fb->width;
> @@ -269,6 +270,7 @@ static bool test_plane(data_t *data)
> { w / 3, h * 3 / 4, },
> { w, h, },
> };
> + bool check_platform_intel = is_i915_device(data->drm_fd);
You will not need to do this. This test start with
drm_open_driver_master(DRIVER_INTEL)
hence will always be only on intel device.
>
> if (!igt_plane_has_format_mod(plane, data->format, data->modifier))
> return false;
> @@ -336,17 +338,19 @@ static bool test_plane(data_t *data)
>
> igt_display_commit2(&data->display, data->display.is_atomic ?
> COMMIT_ATOMIC : COMMIT_UNIVERSAL);
> -
> -
> + if (check_platform_intel)
> + igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
Above this line there's flip to different framebuffer and below this
line there's restart of crc collection before get any crc. If there's
need to wait a vblank at this place to get matching crcs the actual bug
is somewhere else.
> igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
>
> igt_plane_set_fb(plane, big_fb);
> igt_fb_set_position(big_fb, plane, x, y);
> igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height);
> +
> igt_plane_set_size(plane, data->width, data->height);
> igt_display_commit2(&data->display, data->display.is_atomic ?
> COMMIT_ATOMIC : COMMIT_UNIVERSAL);
> -
> + if (check_platform_intel)
> + igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
Here it's the same story as above.
> igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
>
> igt_plane_set_fb(plane, NULL);
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [Intel-gfx] [igt-dev] [PATCH 4/4] [RFC] tests/kms_big_fb: Wait for vblank before collecting CRC
2021-05-27 15:09 ` Juha-Pekka Heikkila
@ 2021-05-27 15:13 ` Srinivas, Vidya
-1 siblings, 0 replies; 20+ messages in thread
From: Srinivas, Vidya @ 2021-05-27 15:13 UTC (permalink / raw)
To: juhapekka.heikkila, intel-gfx, igt-dev; +Cc: Lin, Charlton
Hello Juha-Pekka,
I am sorry, this is not needed.
Thank you so much.
Regards
Vidya
-----Original Message-----
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Sent: Thursday, May 27, 2021 8:40 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Cc: Lin, Charlton <charlton.lin@intel.com>
Subject: Re: [igt-dev] [PATCH 4/4] [RFC] tests/kms_big_fb: Wait for vblank before collecting CRC
On 27.5.2021 17.31, Vidya Srinivas wrote:
> Without wait for vblank, CRC mismatch is seen between big and small
> CRC on some intel Gen11 platforms.
>
> Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_big_fb.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c index
> b2027b6b9d1b..da682593429b 100644
> --- a/tests/kms_big_fb.c
> +++ b/tests/kms_big_fb.c
> @@ -254,6 +254,7 @@ static void unset_lut(data_t *data)
> static bool test_plane(data_t *data)
> {
> igt_plane_t *plane = data->plane;
> + igt_display_t *display = &data->display;
> struct igt_fb *small_fb = &data->small_fb;
> struct igt_fb *big_fb = &data->big_fb;
> int w = data->big_fb_width - small_fb->width; @@ -269,6 +270,7 @@
> static bool test_plane(data_t *data)
> { w / 3, h * 3 / 4, },
> { w, h, },
> };
> + bool check_platform_intel = is_i915_device(data->drm_fd);
You will not need to do this. This test start with
drm_open_driver_master(DRIVER_INTEL)
hence will always be only on intel device.
>
> if (!igt_plane_has_format_mod(plane, data->format, data->modifier))
> return false;
> @@ -336,17 +338,19 @@ static bool test_plane(data_t *data)
>
> igt_display_commit2(&data->display, data->display.is_atomic ?
> COMMIT_ATOMIC : COMMIT_UNIVERSAL);
> -
> -
> + if (check_platform_intel)
> + igt_wait_for_vblank(data->drm_fd,
> +display->pipes[data->pipe].crtc_offset);
Above this line there's flip to different framebuffer and below this line there's restart of crc collection before get any crc. If there's need to wait a vblank at this place to get matching crcs the actual bug is somewhere else.
> igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
>
> igt_plane_set_fb(plane, big_fb);
> igt_fb_set_position(big_fb, plane, x, y);
> igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height);
> +
> igt_plane_set_size(plane, data->width, data->height);
> igt_display_commit2(&data->display, data->display.is_atomic ?
> COMMIT_ATOMIC : COMMIT_UNIVERSAL);
> -
> + if (check_platform_intel)
> + igt_wait_for_vblank(data->drm_fd,
> +display->pipes[data->pipe].crtc_offset);
Here it's the same story as above.
> igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
>
> igt_plane_set_fb(plane, NULL);
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [igt-dev] [PATCH 4/4] [RFC] tests/kms_big_fb: Wait for vblank before collecting CRC
@ 2021-05-27 15:13 ` Srinivas, Vidya
0 siblings, 0 replies; 20+ messages in thread
From: Srinivas, Vidya @ 2021-05-27 15:13 UTC (permalink / raw)
To: juhapekka.heikkila, intel-gfx, igt-dev; +Cc: Lin, Charlton
Hello Juha-Pekka,
I am sorry, this is not needed.
Thank you so much.
Regards
Vidya
-----Original Message-----
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Sent: Thursday, May 27, 2021 8:40 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Cc: Lin, Charlton <charlton.lin@intel.com>
Subject: Re: [igt-dev] [PATCH 4/4] [RFC] tests/kms_big_fb: Wait for vblank before collecting CRC
On 27.5.2021 17.31, Vidya Srinivas wrote:
> Without wait for vblank, CRC mismatch is seen between big and small
> CRC on some intel Gen11 platforms.
>
> Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_big_fb.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c index
> b2027b6b9d1b..da682593429b 100644
> --- a/tests/kms_big_fb.c
> +++ b/tests/kms_big_fb.c
> @@ -254,6 +254,7 @@ static void unset_lut(data_t *data)
> static bool test_plane(data_t *data)
> {
> igt_plane_t *plane = data->plane;
> + igt_display_t *display = &data->display;
> struct igt_fb *small_fb = &data->small_fb;
> struct igt_fb *big_fb = &data->big_fb;
> int w = data->big_fb_width - small_fb->width; @@ -269,6 +270,7 @@
> static bool test_plane(data_t *data)
> { w / 3, h * 3 / 4, },
> { w, h, },
> };
> + bool check_platform_intel = is_i915_device(data->drm_fd);
You will not need to do this. This test start with
drm_open_driver_master(DRIVER_INTEL)
hence will always be only on intel device.
>
> if (!igt_plane_has_format_mod(plane, data->format, data->modifier))
> return false;
> @@ -336,17 +338,19 @@ static bool test_plane(data_t *data)
>
> igt_display_commit2(&data->display, data->display.is_atomic ?
> COMMIT_ATOMIC : COMMIT_UNIVERSAL);
> -
> -
> + if (check_platform_intel)
> + igt_wait_for_vblank(data->drm_fd,
> +display->pipes[data->pipe].crtc_offset);
Above this line there's flip to different framebuffer and below this line there's restart of crc collection before get any crc. If there's need to wait a vblank at this place to get matching crcs the actual bug is somewhere else.
> igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
>
> igt_plane_set_fb(plane, big_fb);
> igt_fb_set_position(big_fb, plane, x, y);
> igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height);
> +
> igt_plane_set_size(plane, data->width, data->height);
> igt_display_commit2(&data->display, data->display.is_atomic ?
> COMMIT_ATOMIC : COMMIT_UNIVERSAL);
> -
> + if (check_platform_intel)
> + igt_wait_for_vblank(data->drm_fd,
> +display->pipes[data->pipe].crtc_offset);
Here it's the same story as above.
> igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
>
> igt_plane_set_fb(plane, NULL);
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 20+ messages in thread