From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v6 8/8] build: meson changes to build on
	windows
Date: Thu, 28 Mar 2019 16:10:04 +0100
Message-ID: <2972503.EZJb3jvalo@xps>
References: <20190306041634.12976-1-anand.rawat@intel.com>
 <20190328022115.4660-1-anand.rawat@intel.com>
 <20190328022115.4660-9-anand.rawat@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, jeffrey.b.shaw@intel.com
To: Anand Rawat <anand.rawat@intel.com>, pallavi.kadam@intel.com,
 ranjit.menon@intel.com, bruce.richardson@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 755983772
 for <dev@dpdk.org>; Thu, 28 Mar 2019 16:10:09 +0100 (CET)
In-Reply-To: <20190328022115.4660-9-anand.rawat@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

28/03/2019 03:21, Anand Rawat:
> Added meson workarounds to build helloworld on windows.
> Windows currently only supports kvargs and eal libraries.
> This change restricts the build flow to supported libraries
> only.

It is OK to merge few limited workarounds in the master branch,
in order to start compiling something on Windows,
and regularly check that the work done is not broken
by other patches coming in.
It will be especially useful if we manage to have a CI for Windows.

> --- a/lib/librte_eal/common/meson.build
> +++ b/lib/librte_eal/common/meson.build
>  common_objs = []
> +common_sources = files(
> +		'eal_common_errno.c',
> +		'eal_common_launch.c',
> +		'eal_common_lcore.c',
> +		'eal_common_log.c'
> +	)
> +if host_machine.system() != 'windows'
>  common_sources = files(
>  	'eal_common_bus.c',
>  	'eal_common_cpuflags.c',
>  	'eal_common_class.c',
>  	'eal_common_devargs.c',
>  	'eal_common_dev.c',
> -	'eal_common_errno.c',
>  	'eal_common_fbarray.c',
>  	'eal_common_hexdump.c',
>  	'eal_common_hypervisor.c',
> -	'eal_common_launch.c',
> -	'eal_common_lcore.c',
> -	'eal_common_log.c',
>  	'eal_common_memalloc.c',
>  	'eal_common_memory.c',
>  	'eal_common_memzone.c',
> @@ -38,6 +41,7 @@ common_sources = files(
>  	'rte_reciprocal.c',
>  	'rte_service.c'
>  )
> +endif

As discussed over the phone, it would be better to overwrite this list
and keep the original one as is.

Thanks