From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752339AbcAGKjL (ORCPT ); Thu, 7 Jan 2016 05:39:11 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:58940 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751193AbcAGKjH (ORCPT ); Thu, 7 Jan 2016 05:39:07 -0500 From: Arnd Bergmann To: Guenter Roeck Cc: Greg Kroah-Hartman , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] serial: 8250: Fix serial port driver for OF platform devices Date: Thu, 07 Jan 2016 11:38:19 +0100 Message-ID: <2974067.q2HTWq3S3v@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1452126221-1253-1-git-send-email-linux@roeck-us.net> References: <1452126221-1253-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:MjPse5BT78DCEe9sVhrHo9QHesffHX+0Ish/uAUmod/D7y+AEII /QSQ2ybJ2+EG9qhVPu7c0vZ0PhvIHxYRcenugnNg141H9R9hS+vCYO1pk3BDDTHA3IVHQ+o flX4FeoBfljBn3MHNlkp61QaumXdlCs+uvORiHMSMz6Pq3/dnl/HY96ni3dTp3nNeibydWP QvdI1zrfnCgpfuckUuq1Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:55rYrRZAfWY=:NJoxb113NwiQ9ThOJkDA92 0I2sEzMEbgTbYGMKInaJjGEzRYuiItdN5/K0D12TOKOXWXkdQE0Tf0MjHAk2ArSZfVuqP0x+n mVwyXbKjlgKwQkryi548FtX/7ueQo+CTLg8scR8yaNo79xGcWYOoeFviFNHmjg7u7CyadMhOu q5zJ98j8Qw2/HFOLPjxcIJ7nDyuwURxjWdfHewKWUHgBrr9hcWaT2JCUcgtEHyIFX3DcL3CAW 9v1vdo8k/f79nk+DuFdhWKrQNO5YxrxdSwgRksgrX7SYghA/zTwE0IYtTcRhQnWvsvFLB2Voz M9Kq8lrfjo+Q/Wuj4qMu9/+GLQJ64N8wWqw/kbgcL6SMHCNZ5g8OAQaPuc90wjzGtxM1wDuKK +v8hxOqqfIBTgh1coeQvfDvUjq7sG/+SYGzF1FnnyPtoqffdjv5o4UKD1US0BJ8YNKuLH0HaV X2Sw9aEOw0XprLRX0vE6omxmRWqc/Wh7qi5mDjCu+K+VHK0zs0SWqHInjVseAufFiekXi38OV bEPgEjT3zruqb3+S2zCrPQ30zRlKno6apvAmGlXqlLdS6xxVNJzSW5s4klBkt8AZfantB8Vz3 uCbwONp8KtvmbpNq+j4RSomWklHvVn1wU/HRTnfyzC/7FxbEQ0Ty+aW0hhUSpTIgYOpkjc/4E TUFJAB5lgyPqpHAT8UEsKmO8nMGuEdMTblBdI3p0zBlrI38bk8ngYZhfAb2SN4HOouElsylQl Tmqv2fa/eq0EKVeJ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 06 January 2016 16:23:41 Guenter Roeck wrote: > Commit afd7f88f1577 ("serial: 8250: move of_serial code to 8250 directory") > moved the serial port driver for Open Firmware platform devices from one > directory to another, but a mixup in Kconfig options resulted in the driver > never being built. This results in runtime failures for some xtensa, > openrisc, and powerpc configurations. > > Fixes: afd7f88f1577 ("serial: 8250: move of_serial code to 8250 directory") > Cc: Arnd Bergmann > Signed-off-by: Guenter Roeck > --- > It might make sense to merge this patch with the commit introducing the problem. Acked-by: Arnd Bergmann > > drivers/tty/serial/8250/8250_of.c | 3 +-- > drivers/tty/serial/8250/Kconfig | 5 +++++ > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_of.c b/drivers/tty/serial/8250/8250_of.c > index d66fd24f87cf..33021c1f7d55 100644 > --- a/drivers/tty/serial/8250/8250_of.c > +++ b/drivers/tty/serial/8250/8250_of.c > @@ -18,10 +18,9 @@ > #include > #include > #include > -#include > #include > > -#include "8250/8250.h" > +#include "8250.h" > > struct of_serial_info { > struct clk *clk; > diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig > index b03cb5175113..e5ab94e381fb 100644 > --- a/drivers/tty/serial/8250/Kconfig > +++ b/drivers/tty/serial/8250/Kconfig > @@ -378,9 +378,14 @@ config SERIAL_8250_MID > present on the UART found on Intel Medfield SOC and various other > Intel platforms. > > +config SERIAL_8250_OF > + tristate > + depends on SERIAL_8250 && OF > + > config SERIAL_OF_PLATFORM > tristate "Devicetree based probing for 8250 ports" > depends on SERIAL_8250 && OF > + select SERIAL_8250_OF > help > This option is used for all 8250 compatible serial ports that > are probed through devicetree, including Open Firmware based >