All of lore.kernel.org
 help / color / mirror / Atom feed
From: YueHaibing <yuehaibing@huawei.com>
To: Eric Dumazet <eric.dumazet@gmail.com>, <ast@kernel.org>,
	<daniel@iogearbox.net>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] bpf: check NULL for sk_to_full_sk()
Date: Tue, 22 May 2018 11:29:47 +0800	[thread overview]
Message-ID: <297885c2-2132-b4a7-e53f-85c82caee95a@huawei.com> (raw)
In-Reply-To: <5490b571-7881-c5eb-6acf-8f45634cd2b1@gmail.com>

On 2018/5/21 23:17, Eric Dumazet wrote:
> 
> 
> On 05/21/2018 12:55 AM, YueHaibing wrote:
>> like commit df39a9f106d5 ("bpf: check NULL for sk_to_full_sk() return value"),
>> we should check sk_to_full_sk return value against NULL.
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>>  include/linux/bpf-cgroup.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/bpf-cgroup.h b/include/linux/bpf-cgroup.h
>> index 30d15e6..fd3fbeb 100644
>> --- a/include/linux/bpf-cgroup.h
>> +++ b/include/linux/bpf-cgroup.h
>> @@ -91,7 +91,7 @@ int __cgroup_bpf_check_dev_permission(short dev_type, u32 major, u32 minor,
>>  	int __ret = 0;							       \
>>  	if (cgroup_bpf_enabled && sk && sk == skb->sk) {		       \
>>  		typeof(sk) __sk = sk_to_full_sk(sk);			       \
>> -		if (sk_fullsock(__sk))					       \
>> +		if (__sk && sk_fullsock(__sk))				       \
>>  			__ret = __cgroup_bpf_run_filter_skb(__sk, skb,	       \
>>  						      BPF_CGROUP_INET_EGRESS); \
>>  	}								       \
>>
> 
> Why is this needed ???

BPF_CGROUP_RUN_PROG_INET_EGRESS is called in ip_output

I just misunderstood, sorry for noise.
> 
> 

      reply	other threads:[~2018-05-22  3:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-21  7:55 [PATCH] bpf: check NULL for sk_to_full_sk() YueHaibing
2018-05-21 15:17 ` Eric Dumazet
2018-05-22  3:29   ` YueHaibing [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=297885c2-2132-b4a7-e53f-85c82caee95a@huawei.com \
    --to=yuehaibing@huawei.com \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.