From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964951AbdDSUUi (ORCPT ); Wed, 19 Apr 2017 16:20:38 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:39792 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936908AbdDSUUf (ORCPT ); Wed, 19 Apr 2017 16:20:35 -0400 From: Laurent Pinchart To: Arnd Bergmann Cc: Tomi Valkeinen , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] drm/omap: displays: panel-dpi: add backlight dependency Date: Wed, 19 Apr 2017 23:21:35 +0300 Message-ID: <2979804.i6EKSW6ohY@avalon> User-Agent: KMail/4.14.10 (Linux/4.9.16-gentoo; KDE/4.14.29; x86_64; ; ) In-Reply-To: <20170419175939.189098-1-arnd@arndb.de> References: <20170419175939.189098-1-arnd@arndb.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, Thank you for the patch. On Wednesday 19 Apr 2017 19:59:17 Arnd Bergmann wrote: > The panel driver gained support for backlight but fails to link now > when that is disabled: > > drivers/gpu/drm/omapdrm/displays/panel-dpi.o: In function > `panel_dpi_probe_of': panel-dpi.c:(.text.panel_dpi_probe_of+0xe8): > undefined reference to `of_find_backlight_by_node' > > This adds a dependency like we have for the other panel drivers. I believe the dependency should be made optional. DPI panels that don't need backlight control should be supported by a kernel that has backlight support compiled out. How about something like >>From 07a98ab23b2080c79abbf8b5e7479123c50e6be7 Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Wed, 19 Apr 2017 23:13:43 +0300 Subject: [PATCH] backlight: Define API stub when backlight support is disabled The of_find_backlight_by_node() function has a stubbed when CONFIG_OF is disabled, but drivers that use backlights optionally will still fail to link if backlight support is disabled. Fix it by defining the stub when CONFIG_BACKLIGHT_CLASS_DEVICE is disabled. Signed-off-by: Laurent Pinchart --- include/linux/backlight.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/backlight.h b/include/linux/backlight.h index 5f2fd61ef4fb..fae0b189f7b4 100644 --- a/include/linux/backlight.h +++ b/include/linux/backlight.h @@ -162,7 +162,7 @@ struct generic_bl_info { void (*kick_battery)(void); }; -#ifdef CONFIG_OF +#if IS_ENABLED(CONFIG_OF) && IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) struct backlight_device *of_find_backlight_by_node(struct device_node *node); #else static inline struct backlight_device * We might need to create stubs for backlight_force_update() and backlight_device_set_brightness() too. > Fixes: 39135a305a0f ("drm/omap: displays: panel-dpi: Support for handling > backlight devices") > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/drm/omapdrm/displays/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/omapdrm/displays/Kconfig > b/drivers/gpu/drm/omapdrm/displays/Kconfig index c226da145fb3..a349cb61961e > 100644 > --- a/drivers/gpu/drm/omapdrm/displays/Kconfig > +++ b/drivers/gpu/drm/omapdrm/displays/Kconfig > @@ -35,6 +35,7 @@ config DRM_OMAP_CONNECTOR_ANALOG_TV > > config DRM_OMAP_PANEL_DPI > tristate "Generic DPI panel" > + depends on BACKLIGHT_CLASS_DEVICE > help > Driver for generic DPI panels. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 1/3] drm/omap: displays: panel-dpi: add backlight dependency Date: Wed, 19 Apr 2017 23:21:35 +0300 Message-ID: <2979804.i6EKSW6ohY@avalon> References: <20170419175939.189098-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id C0EFD89CD8 for ; Wed, 19 Apr 2017 20:20:34 +0000 (UTC) In-Reply-To: <20170419175939.189098-1-arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Arnd Bergmann Cc: Tomi Valkeinen , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgQXJuZCwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gV2VkbmVzZGF5IDE5IEFwciAy MDE3IDE5OjU5OjE3IEFybmQgQmVyZ21hbm4gd3JvdGU6Cj4gVGhlIHBhbmVsIGRyaXZlciBnYWlu ZWQgc3VwcG9ydCBmb3IgYmFja2xpZ2h0IGJ1dCBmYWlscyB0byBsaW5rIG5vdwo+IHdoZW4gdGhh dCBpcyBkaXNhYmxlZDoKPiAKPiBkcml2ZXJzL2dwdS9kcm0vb21hcGRybS9kaXNwbGF5cy9wYW5l bC1kcGkubzogSW4gZnVuY3Rpb24KPiBgcGFuZWxfZHBpX3Byb2JlX29mJzogcGFuZWwtZHBpLmM6 KC50ZXh0LnBhbmVsX2RwaV9wcm9iZV9vZisweGU4KToKPiB1bmRlZmluZWQgcmVmZXJlbmNlIHRv IGBvZl9maW5kX2JhY2tsaWdodF9ieV9ub2RlJwo+IAo+IFRoaXMgYWRkcyBhIGRlcGVuZGVuY3kg bGlrZSB3ZSBoYXZlIGZvciB0aGUgb3RoZXIgcGFuZWwgZHJpdmVycy4KCkkgYmVsaWV2ZSB0aGUg ZGVwZW5kZW5jeSBzaG91bGQgYmUgbWFkZSBvcHRpb25hbC4gRFBJIHBhbmVscyB0aGF0IGRvbid0 IG5lZWQgCmJhY2tsaWdodCBjb250cm9sIHNob3VsZCBiZSBzdXBwb3J0ZWQgYnkgYSBrZXJuZWwg dGhhdCBoYXMgYmFja2xpZ2h0IHN1cHBvcnQgCmNvbXBpbGVkIG91dC4gSG93IGFib3V0IHNvbWV0 aGluZyBsaWtlCgpGcm9tIDA3YTk4YWIyM2IyMDgwYzc5YWJiZjhiNWU3NDc5MTIzYzUwZTZiZTcg TW9uIFNlcCAxNyAwMDowMDowMCAyMDAxCkZyb206IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQu cGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KRGF0ZTogV2VkLCAxOSBBcHIgMjAxNyAyMzoxMzo0 MyArMDMwMApTdWJqZWN0OiBbUEFUQ0hdIGJhY2tsaWdodDogRGVmaW5lIEFQSSBzdHViIHdoZW4g YmFja2xpZ2h0IHN1cHBvcnQgaXMgZGlzYWJsZWQKClRoZSBvZl9maW5kX2JhY2tsaWdodF9ieV9u b2RlKCkgZnVuY3Rpb24gaGFzIGEgc3R1YmJlZCB3aGVuIENPTkZJR19PRiBpcwpkaXNhYmxlZCwg YnV0IGRyaXZlcnMgdGhhdCB1c2UgYmFja2xpZ2h0cyBvcHRpb25hbGx5IHdpbGwgc3RpbGwgZmFp bCB0bwpsaW5rIGlmIGJhY2tsaWdodCBzdXBwb3J0IGlzIGRpc2FibGVkLiBGaXggaXQgYnkgZGVm aW5pbmcgdGhlIHN0dWIgd2hlbgpDT05GSUdfQkFDS0xJR0hUX0NMQVNTX0RFVklDRSBpcyBkaXNh YmxlZC4KClNpZ25lZC1vZmYtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRA aWRlYXNvbmJvYXJkLmNvbT4KLS0tCiBpbmNsdWRlL2xpbnV4L2JhY2tsaWdodC5oIHwgMiArLQog MSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0 IGEvaW5jbHVkZS9saW51eC9iYWNrbGlnaHQuaCBiL2luY2x1ZGUvbGludXgvYmFja2xpZ2h0LmgK aW5kZXggNWYyZmQ2MWVmNGZiLi5mYWUwYjE4OWY3YjQgMTAwNjQ0Ci0tLSBhL2luY2x1ZGUvbGlu dXgvYmFja2xpZ2h0LmgKKysrIGIvaW5jbHVkZS9saW51eC9iYWNrbGlnaHQuaApAQCAtMTYyLDcg KzE2Miw3IEBAIHN0cnVjdCBnZW5lcmljX2JsX2luZm8gewogCXZvaWQgKCpraWNrX2JhdHRlcnkp KHZvaWQpOwogfTsKIAotI2lmZGVmIENPTkZJR19PRgorI2lmIElTX0VOQUJMRUQoQ09ORklHX09G KSAmJiBJU19FTkFCTEVEKENPTkZJR19CQUNLTElHSFRfQ0xBU1NfREVWSUNFKQogc3RydWN0IGJh Y2tsaWdodF9kZXZpY2UgKm9mX2ZpbmRfYmFja2xpZ2h0X2J5X25vZGUoc3RydWN0IGRldmljZV9u b2RlICpub2RlKTsKICNlbHNlCiBzdGF0aWMgaW5saW5lIHN0cnVjdCBiYWNrbGlnaHRfZGV2aWNl ICoKCgpXZSBtaWdodCBuZWVkIHRvIGNyZWF0ZSBzdHVicyBmb3IgYmFja2xpZ2h0X2ZvcmNlX3Vw ZGF0ZSgpIGFuZCAKYmFja2xpZ2h0X2RldmljZV9zZXRfYnJpZ2h0bmVzcygpIHRvby4KCj4gRml4 ZXM6IDM5MTM1YTMwNWEwZiAoImRybS9vbWFwOiBkaXNwbGF5czogcGFuZWwtZHBpOiBTdXBwb3J0 IGZvciBoYW5kbGluZwo+IGJhY2tsaWdodCBkZXZpY2VzIikKPiBTaWduZWQtb2ZmLWJ5OiBBcm5k IEJlcmdtYW5uIDxhcm5kQGFybmRiLmRlPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vb21hcGRy bS9kaXNwbGF5cy9LY29uZmlnIHwgMSArCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigr KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9kaXNwbGF5cy9LY29u ZmlnCj4gYi9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9kaXNwbGF5cy9LY29uZmlnIGluZGV4IGMy MjZkYTE0NWZiMy4uYTM0OWNiNjE5NjFlCj4gMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L29tYXBkcm0vZGlzcGxheXMvS2NvbmZpZwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJt L2Rpc3BsYXlzL0tjb25maWcKPiBAQCAtMzUsNiArMzUsNyBAQCBjb25maWcgRFJNX09NQVBfQ09O TkVDVE9SX0FOQUxPR19UVgo+IAo+ICBjb25maWcgRFJNX09NQVBfUEFORUxfRFBJCj4gIAl0cmlz dGF0ZSAiR2VuZXJpYyBEUEkgcGFuZWwiCj4gKwlkZXBlbmRzIG9uIEJBQ0tMSUdIVF9DTEFTU19E RVZJQ0UKPiAgCWhlbHAKPiAgCSAgRHJpdmVyIGZvciBnZW5lcmljIERQSSBwYW5lbHMuCgotLSAK UmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo=