From mboxrd@z Thu Jan 1 00:00:00 1970 From: Akhil Goyal Subject: Re: [PATCH 1/2] drivers: fix shared build error for DPAA crypto Date: Thu, 26 Oct 2017 19:40:15 +0530 Message-ID: <297afe1c-65dd-a597-b28c-5697a3b14bf8@nxp.com> References: <20171026140906.10347-1-shreyansh.jain@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: , , To: Shreyansh Jain , Return-path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0050.outbound.protection.outlook.com [104.47.41.50]) by dpdk.org (Postfix) with ESMTP id 37FB11B78C for ; Thu, 26 Oct 2017 16:10:20 +0200 (CEST) In-Reply-To: <20171026140906.10347-1-shreyansh.jain@nxp.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/26/2017 7:39 PM, Shreyansh Jain wrote: > Various symbols are being used by DPAA Crypto driver which were not exposed > from DPAA bus during initial version. This breaks the shared build. > > This patch also adds the LDLIBS line required after (cbc12b0a9) patch. > > Fixes: c3e85bdcc6e6 ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform") > Cc: akhil.goyal@nxp.com > > Signed-off-by: Shreyansh Jain > --- > drivers/bus/dpaa/rte_bus_dpaa_version.map | 9 +++++++++ > drivers/crypto/dpaa_sec/Makefile | 2 ++ > 2 files changed, 11 insertions(+) > > diff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map b/drivers/bus/dpaa/rte_bus_dpaa_version.map > index 64a05a9..fb9d532 100644 > --- a/drivers/bus/dpaa/rte_bus_dpaa_version.map > +++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map > @@ -40,14 +40,23 @@ DPDK_17.11 { > fman_ip_rev; > netcfg_acquire; > netcfg_release; > + of_find_compatible_node; > + of_get_property; > + qm_channel_caam; > qman_create_fq; > qman_dequeue; > qman_dqrr_consume; > + qman_enqueue; > qman_enqueue_multi; > + qman_fq_fqid; > + qman_fq_state; > qman_global_init; > qman_init_fq; > + qman_poll_dqrr; > + qman_query_fq_np; > qman_set_vdq; > qman_reserve_fqid_range; > + qman_volatile_dequeue; > rte_dpaa_driver_register; > rte_dpaa_driver_unregister; > rte_dpaa_mem_ptov; > diff --git a/drivers/crypto/dpaa_sec/Makefile b/drivers/crypto/dpaa_sec/Makefile > index 9a061b4..17bc79c 100644 > --- a/drivers/crypto/dpaa_sec/Makefile > +++ b/drivers/crypto/dpaa_sec/Makefile > @@ -53,6 +53,8 @@ CFLAGS += -I$(RTE_SDK)/drivers/crypto/dpaa_sec/ > CFLAGS += -I$(RTE_SDK)/drivers/crypto/dpaa2_sec/ > CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common/include > CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linuxapp/eal > +LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring > +LDLIBS += -lrte_cryptodev > > # versioning export map > EXPORT_MAP := rte_pmd_dpaa_sec_version.map > Acked-by: Akhil Goyal