Re: [RFC PATCH v3 2/5] ppc64: Fix semihosting on ppc64le

From: Leandro Lupori <leandro.lupori@eldorado.org.br>
To: Richard Henderson <richard.henderson@linaro.org>,
	qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: danielhb413@gmail.com, groug@kaod.org, clg@kaod.org,
	pbonzini@redhat.com, alex.bennee@linaro.org,
	david@gibson.dropbear.id.au
Subject: Re: [RFC PATCH v3 2/5] ppc64: Fix semihosting on ppc64le
Date: Wed, 20 Apr 2022 15:42:37 -0300	[thread overview]
Message-ID: <298119a5-c25d-27b6-904a-152398b27fe8@eldorado.org.br> (raw)
In-Reply-To: <bbf99e06-9faf-b1c9-0b1e-7e1fbf992f4a@linaro.org>

On 4/18/22 20:36, Richard Henderson wrote:
> [E-MAIL EXTERNO] Não clique em links ou abra anexos, a menos que você 
> possa confirmar o remetente e saber que o conteúdo é seguro. Em caso de 
> e-mail suspeito entre imediatamente em contato com o DTI.
> 
> On 4/18/22 12:10, Leandro Lupori wrote:
>> +static inline uint64_t sh_swap64(CPUArchState *env, uint64_t val)
>> +{
>> +    return msr_le ? val : tswap64(val);
>> +}
>> +
>> +static inline uint32_t sh_swap32(CPUArchState *env, uint32_t val)
>> +{
>> +    return msr_le ? val : tswap32(val);
>> +}
> 
> That doesn't work -- tswap itself is conditional.
> 
> You want
> 
>    return msr_le ? le32_to_cpu(x) : be32_to_cpu(x);
> 
> etc.  One of them will be a nop, and the other will bswap.
> 

Right, I'll make this change.

Thanks,
Leandro

> 
> r~