From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v4 3/6] cfgfile: add support for configurable
	comment character
Date: Fri, 31 Mar 2017 12:08:22 +0200
Message-ID: <298208360.8PDEFbKV4o@xps13>
References: <20170328164431.12475-1-allain.legacy@windriver.com>
 <20170330185407.61220-1-allain.legacy@windriver.com>
 <20170330185407.61220-4-allain.legacy@windriver.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: cristian.dumitrescu@intel.com, bruce.richardson@intel.com, dev@dpdk.org,
 yuanhan.liu@linux.intel.com
To: Allain Legacy <allain.legacy@windriver.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com
 [209.85.128.180]) by dpdk.org (Postfix) with ESMTP id 6A9D3108D
 for <dev@dpdk.org>; Fri, 31 Mar 2017 12:08:23 +0200 (CEST)
Received: by mail-wr0-f180.google.com with SMTP id k6so93189260wre.2
 for <dev@dpdk.org>; Fri, 31 Mar 2017 03:08:23 -0700 (PDT)
In-Reply-To: <20170330185407.61220-4-allain.legacy@windriver.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

2017-03-30 14:54, Allain Legacy:
>  /**
> + * Open config file with specified optional parameters.
> + *
> + * @param filename
> + *   Config file name
> + * @param flags
> + *   Config file flags
> + * @param params
> + *   Additional configuration attributes.  Must be configured with desired
> + *   values prior to invoking this API.
> + * @return
> + *   Handle to configuration file on success, NULL otherwise
> + * @param

This @param should be removed.

> + *
> + */
> +struct rte_cfgfile *rte_cfgfile_load_with_params(const char *filename,
> +       int flags, const struct rte_cfgfile_parameters *params);
> 

The new public function must be exported in the map file
in a 17.05 section.
Otherwise link with the .so fails:
	undefined reference to `rte_cfgfile_load_with_params'