From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758610AbcIMPN4 (ORCPT ); Tue, 13 Sep 2016 11:13:56 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:61419 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753562AbcIMPNw (ORCPT ); Tue, 13 Sep 2016 11:13:52 -0400 From: Arnd Bergmann To: Deepa Dinamani Cc: Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, y2038@lists.linaro.org Subject: Re: [PATCH 4/4] input: serio: Replace timeval by timespec64 Date: Tue, 13 Sep 2016 17:13:48 +0200 Message-ID: <2982423.lGps9KTD1c@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1473775805-2242-5-git-send-email-deepa.kernel@gmail.com> References: <1473775805-2242-1-git-send-email-deepa.kernel@gmail.com> <1473775805-2242-5-git-send-email-deepa.kernel@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:frUtqq1OBUGKeSmTgRk2kZz+uagqkIab88BVcLseFWW2dw3soj9 jNot0z8AGYh7l1tLJNQCLINR5Pskd1FxC3SLsgHRAly/NNVyQHpvqGfCRXSM8YFwnowss8w YvobNkFpzWpmlycyNLJy3CF2T8+rHso1SdtXXkAHmMIpQbitH2sC6sG+gPQbbCYSRswlGxh v/7WWQehU1zzGdDDu4Mnw== X-UI-Out-Filterresults: notjunk:1;V01:K0:kn46Aw47RrM=:r+W1ydhISMdP4wTSKX1xNB Y7FMz3KwJAGAHRB6mzQZAs4hamBmHihFX1Yr1VuW5Q80wcsg2gW/I3oGzYgXQAvjP46a2lfQ2 h89g7BXmw+I6tpYNZiKMJPAEfW6SGhIh6ask3lbDFK4xGcljP0d4/0LI3eq+J2N7WuoNWcsvL tcCmvv9buQR+cfzyWq1xlia3Xhw2OauGVjmYDhHQDNJxo/e/dNjM1muVVVwxc4An+7OSwFT9c +YIym4fLQcPfFn87F0k9GYi6yc66eJph1fvNisgsNNjn6qE+VyVaIbNB5//Lic7wOd4TtulJ7 Vf+pogCI66hd2UNt+T7AGUB+jAc7QIsLBqg3TjDfKvU3H+Rq5bYzymfygZGxz7Hy4OAI+fA4J wRSESOQ4yzF75z1Qz6smft3VB+5HE/AO/gvjpjbl5Nho4ksuFBHXy7010I7iiNLpfZ+KOH4/7 6SLLcFJKW3QBYS6c2nyAxNha0+9TAwwfl8h7ObvVJxlBF8nUs+EqbRwcenxTcc7PeEqxyQx7R PSRdfFJOsLR+wvPX/xsBdFLy+oHAqDCViauFYzCMuK/keh1m03LUsiqBcYzWaYJ6t4AJWej1y mK932mJIPSe519mHxPvDCYEYesFj8VwephoOh6m2IuBul+HPmA55JMAxvVHc7Bx8Rv7Q9PK2n dbmn9E1JjtxpPJtfE+Aqy42kfiiiW3c8hn4r+HGclOgE+WhkLfjwv/nWIWTY6/CWJceX91chp iFeVvdnf1URvJZg9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, September 13, 2016 7:10:05 AM CEST Deepa Dinamani wrote: > struct timeval is not y2038 safe. > All references to timeval will be deleted from the > kernel to make it y2038 safe. > Replace its uses by y2038 safe struct timespec64. > > The timestamps changed here only keep track of delta > times. These timestamps are also internal to kernel. > Hence, monotonic times are sufficient here. > The unit of the delta times is also changed in certain > cases to nanoseconds rather than microseconds. This is > in line with timespec64 which keeps time in nanoseconds. > > Signed-off-by: Deepa Dinamani > Looks all correct to me, Acked-by: Arnd Bergmann I think it could be done a little nicer using ktime_get() instead of ktime_get_ts64(), but probably nobody cares with this driver. Arnd