From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757654AbcCCMPv (ORCPT ); Thu, 3 Mar 2016 07:15:51 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:52607 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751270AbcCCMPt (ORCPT ); Thu, 3 Mar 2016 07:15:49 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Neil Armstrong , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux@arm.linux.org.uk Subject: Re: [PATCH 14/17] arm: boot: dts: Add PLX Technology OX810SE dtsi Date: Thu, 03 Mar 2016 13:15:20 +0100 Message-ID: <2983013.zAxmIfv4bz@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1457005210-18485-15-git-send-email-narmstrong@baylibre.com> References: <1457005210-18485-1-git-send-email-narmstrong@baylibre.com> <1457005210-18485-15-git-send-email-narmstrong@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:rjTkRqNVvsHTAOSdRYv+Cddj3BYOo5sJodCROA40cWHKKt2Hzaa 9gUkpU8oJaloC4mEJlK8AEEi5uB5znfylCgDnDlpNsBMlzuFxASHBcDJeoOIx0qzRO0JsH0 Dpx7lAhsC/mMAe44ZNHRf6LXSeYMV/6YMwZc/g5ow1qgUFzJqAax99hX5od7DafWBYvgqfI /+4c9ilJZv1EGTauXCEaA== X-UI-Out-Filterresults: notjunk:1;V01:K0:ge23DHBD7yE=:E0hTD3AcVh8nokYzJeLBMx WFRmsLycAZSd31qwG7IIiRkzDqPV7r4x7LN+nZtd0dKwwnFkFc1o46a2mB+jOJzXfleDWLpNu dNQ1O+Pm7mo7xubDerJztnX01VppS3TAjKaM+CI7nEaQRm7t8hNYczVxuhf1DgoRlqpbxWH+6 Q7x7QnqHOlQqJE6/miCx9oC9D+a8XNF4ffZ/2cOMslowc6mFd8SEvAV+f44UK44ZwaPz0f5yL 0fs7ftx6m3ZAO+aUhzbCAdLZwtX4e0ZliUFslfjpI8AAB3pV6ZrbOcsipf8k50pbAR6X24W2L vKpU5Sk54M90hJll8lU4aRjq1Oa9rPMnAszGF8U21Hge50h5muJ0jpas+GkoM98/S5Yr0dRyM waG8R3XkvUkm3X+xoBwlRAlkzieDlAubgDuxTOLtrJLWRfiqfhsFGfm04bEmim30l5PPdrdmV 2KrURnO0ZpeJA0UIKZEOXY1uKEcqUyNXHmr4dYVYfd0Yq5y9cFAP7YbTXpObKpKKnsy+Thhvk R01auZR+m3eE55Wi4Le/tc0UDJZU43J8793+nv4STs4wumYZeoIPmHwyE22MAOWvb1SPgCk8X vt4R/HxixpSvt9da/gI3t3WzmnVbD6iYlZGrrXoqXpGE0t4pB1eKhlmsSTLP2oZkLQ1WXlfX+ 1pJGKX07ZBKD69PaWjNIunC+A+KNctI6I9E/PJA3tpxOjAXA6s8za4q5tjr+tWE+Yw19rRN/g DSHq/Ii8dv/3A+/l Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 03 March 2016 12:40:07 Neil Armstrong wrote: > + > + aliases { > + serial0 = &uart0; > + serial1 = &uart1; > + serial2 = &uart2; > + serial3 = &uart3; > + gpio0 = &gpio0; > + gpio1 = &gpio1; > + }; > Please put the aliases in the per-board file and list only the devices that are actually connected (in case of uart) > + uart0: uart@200000 { Make this serial@200000, to follow the standard naming convention > + > + reset: reset-controller { > + compatible = "plxtech,nas782x-reset"; > + #reset-cells = <1>; > + }; > + > + stdclk: stdclk { > + compatible = "plxtech,ox810se-stdclk", "plxtech,nas782x-stdclk"; > + #clock-cells = <1>; > + }; > + }; Please change the compatible strings to have no 'x' wildcards in them, but instead use a specific model. Regarding the vendor prefixes, my understanding is that "ox810se" was the name of the chip from Oxford Semiconductor, while nas7820 is a product name from PLX. I think it would be logical to use "oxford" as the vendor prefix for anything with a ox810se or ox820 ID in it rather than plxtech. Note that both of them are now historic, as PLX itself got bought by Avago and they seem to be discontinuing both the PLX and Oxfor brand names. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Thu, 03 Mar 2016 13:15:20 +0100 Subject: [PATCH 14/17] arm: boot: dts: Add PLX Technology OX810SE dtsi In-Reply-To: <1457005210-18485-15-git-send-email-narmstrong@baylibre.com> References: <1457005210-18485-1-git-send-email-narmstrong@baylibre.com> <1457005210-18485-15-git-send-email-narmstrong@baylibre.com> Message-ID: <2983013.zAxmIfv4bz@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday 03 March 2016 12:40:07 Neil Armstrong wrote: > + > + aliases { > + serial0 = &uart0; > + serial1 = &uart1; > + serial2 = &uart2; > + serial3 = &uart3; > + gpio0 = &gpio0; > + gpio1 = &gpio1; > + }; > Please put the aliases in the per-board file and list only the devices that are actually connected (in case of uart) > + uart0: uart at 200000 { Make this serial at 200000, to follow the standard naming convention > + > + reset: reset-controller { > + compatible = "plxtech,nas782x-reset"; > + #reset-cells = <1>; > + }; > + > + stdclk: stdclk { > + compatible = "plxtech,ox810se-stdclk", "plxtech,nas782x-stdclk"; > + #clock-cells = <1>; > + }; > + }; Please change the compatible strings to have no 'x' wildcards in them, but instead use a specific model. Regarding the vendor prefixes, my understanding is that "ox810se" was the name of the chip from Oxford Semiconductor, while nas7820 is a product name from PLX. I think it would be logical to use "oxford" as the vendor prefix for anything with a ox810se or ox820 ID in it rather than plxtech. Note that both of them are now historic, as PLX itself got bought by Avago and they seem to be discontinuing both the PLX and Oxfor brand names. Arnd