From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Mon, 04 Aug 2014 14:01:42 +0000 Subject: Re: [PATCH 4/6] dmaengine: rcar-dmac: Add device tree bindings documentation Message-Id: <2984491.bHCssUOyYu@avalon> List-Id: References: <3dc5d31428846326bf122a2a9b402a2a80e97681.1406766014.git.horms+renesas@verge.net.au> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven Cc: Simon Horman , Vinod Koul , dmaengine@vger.kernel.org, Linux-sh list , Magnus Damm , Laurent Pinchart , "devicetree@vger.kernel.org" Hi Geert, Thank you for the review. On Monday 04 August 2014 10:05:49 Geert Uytterhoeven wrote: > On Thu, Jul 31, 2014 at 2:34 AM, Simon Horman wrote: > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt > > @@ -0,0 +1,98 @@ > > +* Renesas R-Car DMA Controller Device Tree bindings > > + > > +Renesas R-Car Generation 2 SoCs have have multiple multi-channel DMA > > +controller instances named DMAC capable of serving multiple clients. > > Channels +can be dedicated to specific clients or shared between a large > > number of +clients. > > + > > +DMA clients are connected to the DMAC ports referenced by an 8-bit > > identifier +called MID/RID. > > I think the above sentence can be removed, as it's superseded by the first > sentence of the successive paragraph: I've probably just forgotten to remove the sentence while reworking the documentation. Thanks for reporting it, I'll fix that in the next version. > > + > > +Each DMA client is connected to one dedicated port of the DMAC, > > identified by +an 8-bit port number called the MID/RID. A DMA controller > > can thus serve up to +256 clients in total. When the number of hardware > > channels is lower than the +number of clients to be served, channels must > > be shared between multiple DMA +clients. The association of DMA clients > > to DMAC channels is fully dynamic and +not described in these device tree > > bindings. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 4/6] dmaengine: rcar-dmac: Add device tree bindings documentation Date: Mon, 04 Aug 2014 16:01:42 +0200 Message-ID: <2984491.bHCssUOyYu@avalon> References: <3dc5d31428846326bf122a2a9b402a2a80e97681.1406766014.git.horms+renesas@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-sh-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Simon Horman , Vinod Koul , dmaengine@vger.kernel.org, Linux-sh list , Magnus Damm , Laurent Pinchart , "devicetree@vger.kernel.org" List-Id: devicetree@vger.kernel.org Hi Geert, Thank you for the review. On Monday 04 August 2014 10:05:49 Geert Uytterhoeven wrote: > On Thu, Jul 31, 2014 at 2:34 AM, Simon Horman wrote: > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt > > @@ -0,0 +1,98 @@ > > +* Renesas R-Car DMA Controller Device Tree bindings > > + > > +Renesas R-Car Generation 2 SoCs have have multiple multi-channel DMA > > +controller instances named DMAC capable of serving multiple clients. > > Channels +can be dedicated to specific clients or shared between a large > > number of +clients. > > + > > +DMA clients are connected to the DMAC ports referenced by an 8-bit > > identifier +called MID/RID. > > I think the above sentence can be removed, as it's superseded by the first > sentence of the successive paragraph: I've probably just forgotten to remove the sentence while reworking the documentation. Thanks for reporting it, I'll fix that in the next version. > > + > > +Each DMA client is connected to one dedicated port of the DMAC, > > identified by +an 8-bit port number called the MID/RID. A DMA controller > > can thus serve up to +256 clients in total. When the number of hardware > > channels is lower than the +number of clients to be served, channels must > > be shared between multiple DMA +clients. The association of DMA clients > > to DMAC channels is fully dynamic and +not described in these device tree > > bindings. -- Regards, Laurent Pinchart