From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753094AbcFFO5T (ORCPT <rfc822;w@1wt.eu>);
	Mon, 6 Jun 2016 10:57:19 -0400
Received: from ausc60pc101.us.dell.com ([143.166.85.206]:7066 "EHLO
	ausc60pc101.us.dell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751738AbcFFO5R convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 6 Jun 2016 10:57:17 -0400
DomainKey-Signature: s=smtpout; d=dell.com; c=nofws; q=dns;
  h=X-LoopCount0:X-IronPort-AV:From:To:CC:Subject:
   Thread-Topic:Thread-Index:Date:Message-ID:References:
   In-Reply-To:Accept-Language:Content-Language:
   X-MS-Has-Attach:X-MS-TNEF-Correlator:
   x-ms-exchange-transport-fromentityheader:x-originating-ip:
   Content-Type:Content-Transfer-Encoding:MIME-Version:
   Return-Path;
  b=g0V2x+qaSq/BUSPznGWFjSItCgqJ7iznPZea2vpuTSxwWXBd1poi7uBb
   KD1E9knHP49aXHDUnhsGqiq6nE7q4xcX5avcunegynO4jnxuQqT+oCODJ
   151OvpiUsnilbLHRuaVqjTkRJ2xTV0JoHoj/uKJvTsJOiLGpkW22vnVRT
   g=;
X-LoopCount0: from 10.175.216.250
X-IronPort-AV: E=Sophos;i="5.26,427,1459832400"; 
   d="scan'208";a="942077574"
From: <Mario_Limonciello@Dell.com>
To: <andrew@lunn.ch>
CC: <hayeswang@realtek.com>, <linux-kernel@vger.kernel.org>,
        <netdev@vger.kernel.org>, <linux-usb@vger.kernel.org>,
        <pali.rohar@gmail.com>, <anthony.wong@canonical.com>,
        <gregkh@linuxfoundation.org>
Subject: RE: [PATCH v3] r8152: Add support for setting pass through MAC
 address on RTL8153-AD
Thread-Topic: [PATCH v3] r8152: Add support for setting pass through MAC
 address on RTL8153-AD
Thread-Index: AQHRv/3ntC5RJsCNs0GplFP1kSdYIZ/cz42AgAAHDgD//7CnMA==
Date: Mon, 6 Jun 2016 14:57:06 +0000
Message-ID: <29950f6ff4a74058bbc5c756d1085cd4@ausx13mpc124.AMER.DELL.COM>
References: <1465222521-7217-1-git-send-email-mario_limonciello@dell.com>
 <1465222521-7217-2-git-send-email-mario_limonciello@dell.com>
 <20160606144036.GA30948@lunn.ch>
In-Reply-To: <20160606144036.GA30948@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.11.181.4]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Andrew Lunn [mailto:andrew@lunn.ch]
> Sent: Monday, June 6, 2016 9:41 AM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: hayeswang@realtek.com; LKML <linux-kernel@vger.kernel.org>; Netdev
> <netdev@vger.kernel.org>; Linux USB <linux-usb@vger.kernel.org>;
> pali.rohar@gmail.com; anthony.wong@canonical.com; Greg KH
> <gregkh@linuxfoundation.org>
> Subject: Re: [PATCH v3] r8152: Add support for setting pass through MAC
> address on RTL8153-AD
> 
> > +	/* returns _AUXMAC_#AABBCCDDEEFF# */
> > +	status = acpi_evaluate_object(NULL, "\\_SB.AMAC", NULL, &buffer);
> > +	obj = (union acpi_object *)buffer.pointer;
> > +	if (ACPI_SUCCESS(status)) {
> > +		if (obj->type != ACPI_TYPE_BUFFER ||
> > +		    obj->string.length != 0x17) {
> > +			pr_warn("r8152: get_passthru_addr: Invalid buffer");
> 
> Please don't use pr_warn() when you can use the better alternatives
> like dev_warn().
> 
>      Andrew

OK thanks, I'll adjust that to use a different warn.