From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932342AbdBHQla (ORCPT ); Wed, 8 Feb 2017 11:41:30 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:39621 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753281AbdBHQlC (ORCPT ); Wed, 8 Feb 2017 11:41:02 -0500 X-AuditID: b6c32a58-f79746d0000012a9-7b-589b422ee7f5 From: Bartlomiej Zolnierkiewicz To: cailiwei Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, guodong.xu@linaro.org, suzhuangluan@hisilicon.com, dengqingshan@hisilicon.com, xuhongtao8@hisilicon.com, zhengwanchun@hisilicon.com, shizongxuan@huawei.com Subject: Re: [PATCH 1/8] fb: hisilicon: Add framebuffer driver for hi3660 SoC Date: Wed, 08 Feb 2017 17:07:07 +0100 Message-id: <2996648.XhUWzz1aup@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170207023559.79455-1-cailiwei@hisilicon.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGKsWRmVeSWpSXmKPExsWy7bCmpq6e0+wIg7lTuSxOzVnIZjF1fh+T xf87PawWJ/o+sFpc3jWHzeL6goVMFt0/7Sy+fOthszjx6ROTA6fH47kb2T1ajrxl9bhzbQ+b x+dNcgEsUVw2Kak5mWWpRfp2CVwZOzZuYiqYqVyx4xZ7A+MjmS5GTg4JAROJBZf6WSBsMYkL 99azdTFycQgJLGWUWH11FlhCSKCdSWLd91KYhrkvdrJCFC1nlDh/fzk7hPOVUWLjjz/MIFVs AlYSE9tXMYLYIgKqEmv+LAMbyyzwgFFi4bWpYGOFBfwlZux6zwRiswAV7fzZA9bAK6Ap8WfO bnYQW1TAS2LLvnawGk4BG4lPFzZC1QhK/Jh8D2wOs4C8xL79U1khbB2Js8fWMYIskxBYxi7x /tZKIIcDyJGV2HSAGcJ0kZjcnwPxjbDEq+Nb2CFsaYm/S28xQtjTGSW2/5aAGLOZUWLV7glQ RdYSh49fhNrFJ9H7+wkTxExeiY42IYgSD4l9qxexQtiOEofubGGEBFA/o8TujzNZJzDKz0Ly wiwkL8xC8sICRuZVjGKpBcW56anFpgUmesWJucWleel6yfm5mxjBqUUrYgfjvxlBhxgFOBiV eHgvWM+OEGJNLCuuzD3EKMHBrCTCO8sRKMSbklhZlVqUH19UmpNafIhRmoNFSZw3ymBihJBA emJJanZqakFqEUyWiYNTqoFxj57KKok7ZrfOLM7IVFOPn33lgyeL47Pa4gfHeoGazweIGEdd 6WrfudJ/a/ZMe52Q/aIpkbMPsh9dNXFF1PbG//dWS7mIbbyjPkehaOpqroXN5hbPPx6ST1lU lzH/7eZ9GhfLpKdufi1xODBJ3jJS7LX/5nTtqRET7ogZT96U8jXGM6t6h5YSS3FGoqEWc1Fx IgCMEbpZKQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJIsWRmVeSWpSXmKPExsVy+t9jAV1dp9kRBtteG1ucmrOQzWLq/D4m i/93elgtTvR9YLW4vGsOm8X1BQuZLLp/2ll8+dbDZnHi0ycmB06Px3M3snu0HHnL6nHn2h42 j8+b5AJYotxsMlITU1KLFFLzkvNTMvPSbZVCQ9x0LZQU8hJzU22VInR9Q4KUFMoSc0qBPCMD NODgHOAerKRvl+CWsWPjJqaCmcoVO26xNzA+kuli5OSQEDCRmPtiJyuELSZx4d56ti5GLg4h gaWMEo9bLrFCOF8ZJTZcamYBqWITsJKY2L6KEcQWEVCVWPNnGRuIzSxwj1Fi9TlVEFtYwFdi 94rd7CA2C1DNzp89YPW8ApoSf+ZAxEUFvCS27GtnArE5BWwkPl3YyAixbCKjxNc3k5kgGgQl fky+xwKxQF5i3/6prBC2lsT6nceZJjAKzEJSNgtJ2SwkZQsYmVcxSqQWJBcUJ6XnGuWllusV J+YWl+al6yXn525iBEfbM+kdjId3uR9iFOBgVOLhrbCcHSHEmlhWXJl7iFGCg1lJhPeJDVCI NyWxsiq1KD++qDQntfgQoynQhxOZpUST84GJIK8k3tDE3MTc2MDC3NLSxEhJnLdx9rNwIYH0 xJLU7NTUgtQimD4mDk6pBkbLKHHDi1bWAQ4F9TU+p8o4u3MKuJi/Vvf4NzyW5ND32DDZq+is s5X+ce6yMN3HrnrWkTJyE2+KMjTen7VmzvuZwU9nb3f8uN7uoex+vrBFs90rA+WWmX27VTit qTg7fXmLjHGi1NuLbtfkDh+PnxQz7/+zeU9n7LtzouqxhdqEedaJ9ZHC/5VYijMSDbWYi4oT AbOWQ5jMAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170208160709epcas5p2e43b2c30d733d4b1288e68c83f6bc2c3 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170207024027epcas5p2528e797ee0c34cb60d97f0b659f4acbf X-RootMTR: 20170207024027epcas5p2528e797ee0c34cb60d97f0b659f4acbf References: <20170207023559.79455-1-cailiwei@hisilicon.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I cannot merge this upstream as it was collectively decided that there should be no new fbdev drivers (DRM subsystem should be used instead). [ You may consider submitting this driver to staging subsystem to make hardware usable by kernel while proper DRM driver is being developed. ] Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics On Tuesday, February 07, 2017 10:35:52 AM cailiwei wrote: > From: Levy-Cai > > Add framebuffer driver for hi3660 SoC, this driver include lcd > driver & Hdmi adv7533/adv7535 driver, support lcd display at > 1080p@60 and hdmi display at 1080p@60. > > Signed-off-by: cailiwei > --- > drivers/video/fbdev/Kconfig | 11 ++++++++++ > drivers/video/fbdev/Makefile | 1 + > drivers/video/fbdev/hisi/Kconfig | 6 +++++ > drivers/video/fbdev/hisi/dss/Makefile | 41 +++++++++++++++++++++++++++++++++++ > 4 files changed, 59 insertions(+) > mode change 100644 => 100755 drivers/video/fbdev/Kconfig > mode change 100644 => 100755 drivers/video/fbdev/Makefile > create mode 100755 drivers/video/fbdev/hisi/Kconfig > create mode 100755 drivers/video/fbdev/hisi/dss/Makefile > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > old mode 100644 > new mode 100755 > index 5d3b0db5ce0a..85c46cc75908 > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -2429,6 +2429,16 @@ config FB_HYPERV > help > This framebuffer driver supports Microsoft Hyper-V Synthetic Video. > > +config FB_HISI > + tristate "Hisilicon Framebuffer support" > + depends on FB > + select FB_CFB_FILLRECT > + select FB_CFB_COPYAREA > + select FB_CFB_IMAGEBLIT > + select REGMAP > + help > + This framebuffer driver supports Hisilicon FB. > + > config FB_SIMPLE > bool "Simple framebuffer support" > depends on (FB = y) > @@ -2448,6 +2458,7 @@ config FB_SIMPLE > source "drivers/video/fbdev/omap/Kconfig" > source "drivers/video/fbdev/omap2/Kconfig" > source "drivers/video/fbdev/mmp/Kconfig" > +source "drivers/video/fbdev/hisi/Kconfig" > > config FB_SH_MOBILE_MERAM > tristate "SuperH Mobile MERAM read ahead support" > diff --git a/drivers/video/fbdev/Makefile b/drivers/video/fbdev/Makefile > old mode 100644 > new mode 100755 > index ee8c81405a7f..a10d3d2793e3 > --- a/drivers/video/fbdev/Makefile > +++ b/drivers/video/fbdev/Makefile > @@ -23,6 +23,7 @@ obj-$(CONFIG_FB_I740) += i740fb.o > obj-$(CONFIG_FB_MATROX) += matrox/ > obj-$(CONFIG_FB_RIVA) += riva/ > obj-$(CONFIG_FB_NVIDIA) += nvidia/ > +obj-$(CONFIG_FB_HISI) += hisi/dss/ > obj-$(CONFIG_FB_ATY) += aty/ macmodes.o > obj-$(CONFIG_FB_ATY128) += aty/ macmodes.o > obj-$(CONFIG_FB_RADEON) += aty/ > diff --git a/drivers/video/fbdev/hisi/Kconfig b/drivers/video/fbdev/hisi/Kconfig > new file mode 100755 > index 000000000000..c30747d52a38 > --- /dev/null > +++ b/drivers/video/fbdev/hisi/Kconfig > @@ -0,0 +1,6 @@ > +config HISI_FB_KIRIN960 > + tristate "HISI FB KIRIN960 Framebuffer support" > + depends on FB_HISI > + > + help > + This framebuffer driver supports KIRIN960 FB. > diff --git a/drivers/video/fbdev/hisi/dss/Makefile b/drivers/video/fbdev/hisi/dss/Makefile > new file mode 100755 > index 000000000000..60004880dd80 > --- /dev/null > +++ b/drivers/video/fbdev/hisi/dss/Makefile > @@ -0,0 +1,41 @@ > +ifeq ($(CONFIG_HISI_FB_KIRIN960),y) > +obj-$(CONFIG_HISI_FB_KIRIN960) := hisifb.o > +endif > + > +hisifb-objs := \ > + hisi_mipi_dsi_host.o \ > + hisi_mipi_dsi.o \ > + hisi_dpe.o \ > + hisi_fb_panel.o \ > + hisi_fb_isr.o \ > + hisi_fb_vsync.o \ > + hisi_fb_buf_sync.o \ > + hisi_fb_bl.o \ > + hisi_fb_utils.o \ > + hisi_fb.o \ > + hisi_overlay_utils.o \ > + hisi_block_algorithm.o \ > + hisi_overlay_online.o \ > + hisi_overlay_cmdlist_utils.o > + > +ifeq ($(CONFIG_HISI_FB_KIRIN960),y) > +hisifb-objs += \ > + hisi_dpe_utils_hi3660.o \ > + hisi_overlay_utils_hi3660.o \ > + panel/mipi_hikey_nte300nts.o \ > + hdmi/adv75xx.o \ > + hdmi/mipi_adi_hdmi.o > +endif > + > +EXTRA_CFLAGS += -Idrivers/video/hisi/dss \ > + -Idrivers/video/hisi/panel \ > + -Idrivers/video/hisi \ > + -Iinclude \ > + -Idrivers/staging/android > + > +ifeq ($(CONFIG_HISI_PERIDVFS),y) > +EXTRA_CFLAGS += -Idrivers/clk/hisi/peri_dvfs > +endif > + > +clean: > + rm *.o .*cmd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Wed, 08 Feb 2017 16:07:07 +0000 Subject: Re: [PATCH 1/8] fb: hisilicon: Add framebuffer driver for hi3660 SoC Message-Id: <2996648.XhUWzz1aup@amdc3058> List-Id: References: <20170207023559.79455-1-cailiwei@hisilicon.com> In-Reply-To: <20170207023559.79455-1-cailiwei@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: cailiwei Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, guodong.xu@linaro.org, suzhuangluan@hisilicon.com, dengqingshan@hisilicon.com, xuhongtao8@hisilicon.com, zhengwanchun@hisilicon.com, shizongxuan@huawei.com Hi, I cannot merge this upstream as it was collectively decided that there should be no new fbdev drivers (DRM subsystem should be used instead). [ You may consider submitting this driver to staging subsystem to make hardware usable by kernel while proper DRM driver is being developed. ] Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics On Tuesday, February 07, 2017 10:35:52 AM cailiwei wrote: > From: Levy-Cai > > Add framebuffer driver for hi3660 SoC, this driver include lcd > driver & Hdmi adv7533/adv7535 driver, support lcd display at > 1080p@60 and hdmi display at 1080p@60. > > Signed-off-by: cailiwei > --- > drivers/video/fbdev/Kconfig | 11 ++++++++++ > drivers/video/fbdev/Makefile | 1 + > drivers/video/fbdev/hisi/Kconfig | 6 +++++ > drivers/video/fbdev/hisi/dss/Makefile | 41 +++++++++++++++++++++++++++++++++++ > 4 files changed, 59 insertions(+) > mode change 100644 => 100755 drivers/video/fbdev/Kconfig > mode change 100644 => 100755 drivers/video/fbdev/Makefile > create mode 100755 drivers/video/fbdev/hisi/Kconfig > create mode 100755 drivers/video/fbdev/hisi/dss/Makefile > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > old mode 100644 > new mode 100755 > index 5d3b0db5ce0a..85c46cc75908 > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -2429,6 +2429,16 @@ config FB_HYPERV > help > This framebuffer driver supports Microsoft Hyper-V Synthetic Video. > > +config FB_HISI > + tristate "Hisilicon Framebuffer support" > + depends on FB > + select FB_CFB_FILLRECT > + select FB_CFB_COPYAREA > + select FB_CFB_IMAGEBLIT > + select REGMAP > + help > + This framebuffer driver supports Hisilicon FB. > + > config FB_SIMPLE > bool "Simple framebuffer support" > depends on (FB = y) > @@ -2448,6 +2458,7 @@ config FB_SIMPLE > source "drivers/video/fbdev/omap/Kconfig" > source "drivers/video/fbdev/omap2/Kconfig" > source "drivers/video/fbdev/mmp/Kconfig" > +source "drivers/video/fbdev/hisi/Kconfig" > > config FB_SH_MOBILE_MERAM > tristate "SuperH Mobile MERAM read ahead support" > diff --git a/drivers/video/fbdev/Makefile b/drivers/video/fbdev/Makefile > old mode 100644 > new mode 100755 > index ee8c81405a7f..a10d3d2793e3 > --- a/drivers/video/fbdev/Makefile > +++ b/drivers/video/fbdev/Makefile > @@ -23,6 +23,7 @@ obj-$(CONFIG_FB_I740) += i740fb.o > obj-$(CONFIG_FB_MATROX) += matrox/ > obj-$(CONFIG_FB_RIVA) += riva/ > obj-$(CONFIG_FB_NVIDIA) += nvidia/ > +obj-$(CONFIG_FB_HISI) += hisi/dss/ > obj-$(CONFIG_FB_ATY) += aty/ macmodes.o > obj-$(CONFIG_FB_ATY128) += aty/ macmodes.o > obj-$(CONFIG_FB_RADEON) += aty/ > diff --git a/drivers/video/fbdev/hisi/Kconfig b/drivers/video/fbdev/hisi/Kconfig > new file mode 100755 > index 000000000000..c30747d52a38 > --- /dev/null > +++ b/drivers/video/fbdev/hisi/Kconfig > @@ -0,0 +1,6 @@ > +config HISI_FB_KIRIN960 > + tristate "HISI FB KIRIN960 Framebuffer support" > + depends on FB_HISI > + > + help > + This framebuffer driver supports KIRIN960 FB. > diff --git a/drivers/video/fbdev/hisi/dss/Makefile b/drivers/video/fbdev/hisi/dss/Makefile > new file mode 100755 > index 000000000000..60004880dd80 > --- /dev/null > +++ b/drivers/video/fbdev/hisi/dss/Makefile > @@ -0,0 +1,41 @@ > +ifeq ($(CONFIG_HISI_FB_KIRIN960),y) > +obj-$(CONFIG_HISI_FB_KIRIN960) := hisifb.o > +endif > + > +hisifb-objs := \ > + hisi_mipi_dsi_host.o \ > + hisi_mipi_dsi.o \ > + hisi_dpe.o \ > + hisi_fb_panel.o \ > + hisi_fb_isr.o \ > + hisi_fb_vsync.o \ > + hisi_fb_buf_sync.o \ > + hisi_fb_bl.o \ > + hisi_fb_utils.o \ > + hisi_fb.o \ > + hisi_overlay_utils.o \ > + hisi_block_algorithm.o \ > + hisi_overlay_online.o \ > + hisi_overlay_cmdlist_utils.o > + > +ifeq ($(CONFIG_HISI_FB_KIRIN960),y) > +hisifb-objs += \ > + hisi_dpe_utils_hi3660.o \ > + hisi_overlay_utils_hi3660.o \ > + panel/mipi_hikey_nte300nts.o \ > + hdmi/adv75xx.o \ > + hdmi/mipi_adi_hdmi.o > +endif > + > +EXTRA_CFLAGS += -Idrivers/video/hisi/dss \ > + -Idrivers/video/hisi/panel \ > + -Idrivers/video/hisi \ > + -Iinclude \ > + -Idrivers/staging/android > + > +ifeq ($(CONFIG_HISI_PERIDVFS),y) > +EXTRA_CFLAGS += -Idrivers/clk/hisi/peri_dvfs > +endif > + > +clean: > + rm *.o .*cmd