From: Himanshu Madhani <himanshu.madhani@oracle.com>
To: James Smart <james.smart@broadcom.com>
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-fc: soften messages logged by error_recovery
Date: Fri, 11 Sep 2020 16:50:26 -0500 [thread overview]
Message-ID: <29E6AB12-E105-4AC1-BBE2-6676FE0855A6@oracle.com> (raw)
In-Reply-To: <20200911200254.111005-1-james.smart@broadcom.com>
> On Sep 11, 2020, at 3:02 PM, James Smart <james.smart@broadcom.com> wrote:
>
> Several of the messages logged vi nvme_fc_error_recovery() come across
> as rather strong events due to the use of the word "error". This is
> causing some interpretations to be overly worried.
>
> Soften the wording of the messages.
>
> Signed-off-by: James Smart <james.smart@broadcom.com>
> ---
> drivers/nvme/host/fc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
> index e8ef42b9d50c..bc4e1af587cc 100644
> --- a/drivers/nvme/host/fc.c
> +++ b/drivers/nvme/host/fc.c
> @@ -2433,7 +2433,7 @@ nvme_fc_error_recovery(struct nvme_fc_ctrl *ctrl, char *errmsg)
> return;
>
> dev_warn(ctrl->ctrl.device,
> - "NVME-FC{%d}: transport association error detected: %s\n",
> + "NVME-FC{%d}: transport association event: %s\n",
> ctrl->cnum, errmsg);
> dev_warn(ctrl->ctrl.device,
> "NVME-FC{%d}: resetting controller\n", ctrl->cnum);
> @@ -2454,7 +2454,7 @@ nvme_fc_timeout(struct request *rq, bool reserved)
> * the host/io stack, terminate the association on the link,
> * and recreate an association on the link.
> */
> - nvme_fc_error_recovery(ctrl, "io timeout error");
> + nvme_fc_error_recovery(ctrl, "io timeout");
>
> /*
> * the io abort has been initiated. Have the reset timer
> --
> 2.26.2
>
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
Looks Good.
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-09-11 21:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 20:02 [PATCH] nvme-fc: soften messages logged by error_recovery James Smart
2020-09-11 21:50 ` Himanshu Madhani [this message]
2020-10-22 13:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29E6AB12-E105-4AC1-BBE2-6676FE0855A6@oracle.com \
--to=himanshu.madhani@oracle.com \
--cc=james.smart@broadcom.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.