From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1193EC432C3 for ; Fri, 15 Nov 2019 07:54:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB86A2073C for ; Fri, 15 Nov 2019 07:54:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="Tj7gXOnq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727274AbfKOHy2 (ORCPT ); Fri, 15 Nov 2019 02:54:28 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:41282 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725829AbfKOHy2 (ORCPT ); Fri, 15 Nov 2019 02:54:28 -0500 Received: by mail-lj1-f193.google.com with SMTP id m4so4709126ljj.8 for ; Thu, 14 Nov 2019 23:54:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+C6UFetkkOkabjlrx29bRj2f/pHq6ZunDxUzZ7B8oJI=; b=Tj7gXOnqtuG0wJhNZbvfhuhFF7Ajj+d/fkSs7BOhJuk6zYcUK3pqsPz4KlpJ5C6cZu CQ9MRWf2wM06ny9O2bnOKcTBNvY1ewmlHc0/L/nIx34DK3gZJOIMBOt6MJMcRJUnM6lj Sty8aREsnWc3bR9ednCLj5/uDLng1EyPh4j+w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+C6UFetkkOkabjlrx29bRj2f/pHq6ZunDxUzZ7B8oJI=; b=cmZJCqNYcTzym+COH4b79ihO3F15GfDOypfUk/ul4N/IrGTeVDcIFicJum2bS/TzE4 nUcgahRGLGcfapi86aBW+tUTrAWJqalfW5rIL4/lSOoU99wX9wZwGTvHY0s4ind9TfYn 7G0upAQJJI4Ft8WYlWXDNt95E7KWynZRSFaBjngoAlHGr25aOFp5hrytb7i/a784vq7J JBpMEhiN7/KfEa5OZU4UhI9DYlfIPTUhN3AQhlBrQqwHAaMZgcH9Xgq6AIYfR5aHvcxr xExOMe7IWNMXJAWFiyvHBiw242uuTxGQOj/vIsaYWIXsL94hr8RXi8ExRb05v6d+e2+z uO7w== X-Gm-Message-State: APjAAAUqx/1YtbFIWvqtAxuoaly1RY1WTnoHEHBDxLqpVlt9tvq0w5Jc gDqgWsQX8XcXQmKrwrfCj/68Ig== X-Google-Smtp-Source: APXvYqwtca4V1MXOZa/BxeDe/jqUfjT4UHa/rribPRAykBqSAV8Y1dWumBHX7aG8dBwq5CyNgx3uLQ== X-Received: by 2002:a2e:8809:: with SMTP id x9mr9979158ljh.82.1573804466324; Thu, 14 Nov 2019 23:54:26 -0800 (PST) Received: from [172.16.11.28] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id w11sm4254332lji.45.2019.11.14.23.54.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Nov 2019 23:54:25 -0800 (PST) Subject: Re: [PATCH v4 46/47] net: ethernet: freescale: make UCC_GETH explicitly depend on PPC32 To: Li Yang , Timur Tabi Cc: Qiang Zhao , Christophe Leroy , linuxppc-dev , linux-arm-kernel , lkml , Scott Wood , netdev References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-47-linux@rasmusvillemoes.dk> From: Rasmus Villemoes Message-ID: <29b45e76-f384-fe16-0891-cc51cfecefd4@rasmusvillemoes.dk> Date: Fri, 15 Nov 2019 08:54:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/11/2019 06.44, Li Yang wrote: > On Thu, Nov 14, 2019 at 10:37 PM Timur Tabi wrote: >> >> On Fri, Nov 8, 2019 at 7:04 AM Rasmus Villemoes >> wrote: >>> >>> Currently, QUICC_ENGINE depends on PPC32, so this in itself does not >>> change anything. In order to allow removing the PPC32 dependency from >>> QUICC_ENGINE and avoid allmodconfig build failures, add this explicit >>> dependency. >> >> Can you add an explanation why we don't want ucc_geth on non-PowerPC platforms? It's not that "we" don't want to allow building this on non-PPC per se, but making it build requires some surgery that I think should be done by whoever might eventually want it. So _my_ reason for lowering this dependency from QUICC_ENGINE to UCC_GETH is exactly what it says above. > I think it is because the QE Ethernet was never integrated in any > non-PowerPC SoC and most likely will not be in the future. Well, that kind of thing is impossible to know for outsiders like me. Maybe one can amend the commit log with that info: "Also, the QE Ethernet has never been integrated on any non-PowerPC SoC and most likely will not be in the future." Rasmus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17CEBC432C3 for ; Fri, 15 Nov 2019 07:56:49 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC7F120718 for ; Fri, 15 Nov 2019 07:56:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="Tj7gXOnq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC7F120718 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rasmusvillemoes.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47DrKB1SyZzF4B9 for ; Fri, 15 Nov 2019 18:56:46 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=rasmusvillemoes.dk (client-ip=2a00:1450:4864:20::241; helo=mail-lj1-x241.google.com; envelope-from=linux@rasmusvillemoes.dk; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=rasmusvillemoes.dk Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="Tj7gXOnq"; dkim-atps=neutral Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47DrGb4K3gzF6d7 for ; Fri, 15 Nov 2019 18:54:30 +1100 (AEDT) Received: by mail-lj1-x241.google.com with SMTP id t5so9663126ljk.0 for ; Thu, 14 Nov 2019 23:54:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+C6UFetkkOkabjlrx29bRj2f/pHq6ZunDxUzZ7B8oJI=; b=Tj7gXOnqtuG0wJhNZbvfhuhFF7Ajj+d/fkSs7BOhJuk6zYcUK3pqsPz4KlpJ5C6cZu CQ9MRWf2wM06ny9O2bnOKcTBNvY1ewmlHc0/L/nIx34DK3gZJOIMBOt6MJMcRJUnM6lj Sty8aREsnWc3bR9ednCLj5/uDLng1EyPh4j+w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+C6UFetkkOkabjlrx29bRj2f/pHq6ZunDxUzZ7B8oJI=; b=H2J+/T1gQKssk6KgpI3XwiNefh/w8DZUoxNS5LgoZYI0WCu9Ggo66deyqPD57f2umb LVchkvD35LNHDPNBuqRITMCWi7TAS2iM0lUwVnrJeFzDrCM+7HTb2Xk+m7WeKuwLuj8C MsZHGyFIofCTu5Fk/8ljoJn4HN85dln1Xz/yxoyZgrtEXqFXJPzvjQ4ewCiigufgZZ7P KMY5IEnH+G0Gfx+GXPW4lB11m6/1ZcLQCgYmkPZH13y4DeUYuA++Li8S5+OQ2xuIWPMS PJq+WJ8VjnJrq3ANYyK/e3qOxbE8qHRP7WRldRimqoR6f+gVGKMgAz6KkLcxUaRIpsRh 7QtQ== X-Gm-Message-State: APjAAAU/gzxJx4pGwxHLejQd6FSeKYawpd5KlKzZNSnkFsaw644MHUt5 7BfGgvFnixiCRsRxlzGSBBYxbA== X-Google-Smtp-Source: APXvYqwtca4V1MXOZa/BxeDe/jqUfjT4UHa/rribPRAykBqSAV8Y1dWumBHX7aG8dBwq5CyNgx3uLQ== X-Received: by 2002:a2e:8809:: with SMTP id x9mr9979158ljh.82.1573804466324; Thu, 14 Nov 2019 23:54:26 -0800 (PST) Received: from [172.16.11.28] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id w11sm4254332lji.45.2019.11.14.23.54.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Nov 2019 23:54:25 -0800 (PST) Subject: Re: [PATCH v4 46/47] net: ethernet: freescale: make UCC_GETH explicitly depend on PPC32 To: Li Yang , Timur Tabi References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-47-linux@rasmusvillemoes.dk> From: Rasmus Villemoes Message-ID: <29b45e76-f384-fe16-0891-cc51cfecefd4@rasmusvillemoes.dk> Date: Fri, 15 Nov 2019 08:54:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev , lkml , Scott Wood , linuxppc-dev , linux-arm-kernel , Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 15/11/2019 06.44, Li Yang wrote: > On Thu, Nov 14, 2019 at 10:37 PM Timur Tabi wrote: >> >> On Fri, Nov 8, 2019 at 7:04 AM Rasmus Villemoes >> wrote: >>> >>> Currently, QUICC_ENGINE depends on PPC32, so this in itself does not >>> change anything. In order to allow removing the PPC32 dependency from >>> QUICC_ENGINE and avoid allmodconfig build failures, add this explicit >>> dependency. >> >> Can you add an explanation why we don't want ucc_geth on non-PowerPC platforms? It's not that "we" don't want to allow building this on non-PPC per se, but making it build requires some surgery that I think should be done by whoever might eventually want it. So _my_ reason for lowering this dependency from QUICC_ENGINE to UCC_GETH is exactly what it says above. > I think it is because the QE Ethernet was never integrated in any > non-PowerPC SoC and most likely will not be in the future. Well, that kind of thing is impossible to know for outsiders like me. Maybe one can amend the commit log with that info: "Also, the QE Ethernet has never been integrated on any non-PowerPC SoC and most likely will not be in the future." Rasmus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A79D6C432C3 for ; Fri, 15 Nov 2019 07:54:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6CCDA2072D for ; Fri, 15 Nov 2019 07:54:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="C5fHspKU"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="Tj7gXOnq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CCDA2072D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rasmusvillemoes.dk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sSTFcQALSV2+dprEGoUOJZW1V9hc6dhB1huJ77FIDEI=; b=C5fHspKUezEnQd WoywesEVtMTluQu4s3ha3Anv388oPqPSTizQQgTer0ZZs/Yqu10//ANZRrv9IB058sP+05HRGqNma ctTzgfoV1sE0gIchXbsgvW9V9Cr2AhicX7qrg1o020nbBr3BQbh0yniidqV6CV0oQM9t2Uc1rWnDX Uqbq4d7HD11o98lhyrSYKQ8kG9MzdM7w02ZSZokFWwCsPxVQlglZcUVbaWDzWrUMJ+Egv6x7zeZQk 0skto+bJLlTb6WSz5zhA2qJqgmk7kHHpctyNHM6ZlBL5a3MkTey05L4wtSoBOehQV5hokvGNlaidk VuTelU5BzTIlLXWX5nRw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVWR4-0004qk-IO; Fri, 15 Nov 2019 07:54:30 +0000 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVWR1-0004qO-Uu for linux-arm-kernel@lists.infradead.org; Fri, 15 Nov 2019 07:54:29 +0000 Received: by mail-lj1-x241.google.com with SMTP id p18so9654147ljc.6 for ; Thu, 14 Nov 2019 23:54:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+C6UFetkkOkabjlrx29bRj2f/pHq6ZunDxUzZ7B8oJI=; b=Tj7gXOnqtuG0wJhNZbvfhuhFF7Ajj+d/fkSs7BOhJuk6zYcUK3pqsPz4KlpJ5C6cZu CQ9MRWf2wM06ny9O2bnOKcTBNvY1ewmlHc0/L/nIx34DK3gZJOIMBOt6MJMcRJUnM6lj Sty8aREsnWc3bR9ednCLj5/uDLng1EyPh4j+w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+C6UFetkkOkabjlrx29bRj2f/pHq6ZunDxUzZ7B8oJI=; b=daBgmkjyoDti0lwDKxO35CC/qtFq5YwKLY9Fq197vH82Lomiyg9uir1Aq8ikZI8xWE GMcC0JDzatipDfruK98qyliiftyaYr7GyR6hMu8ixQ71GYbcRVmbWtlZKTWXgFjwor+A gbCc02/WL8oohNeg/OfCGqHds4IS3+Fgn7e4kJ75Z5I3G5w9zlWywHji71TfgjqeoufJ ifGggy2CrBPYTo8xVbLe/CWaFJ6tkURW5aOu/6fvh9uPjZRa6i5kbaGvBIm3iaaCU3RO CpRo2naMHi3xV3HgacEktohITzvrrO3XfGcmjh9cz6Yxm6OeVvPhcfNaPDAzChsV0pXl DFGA== X-Gm-Message-State: APjAAAWc3W4YE+Z58Qyk/fAYF6oqjxnBGA4LDFM57gYvH8NrWJrtmprf zPGFXghM5DscQ4Tqfdc9dj32cg== X-Google-Smtp-Source: APXvYqwtca4V1MXOZa/BxeDe/jqUfjT4UHa/rribPRAykBqSAV8Y1dWumBHX7aG8dBwq5CyNgx3uLQ== X-Received: by 2002:a2e:8809:: with SMTP id x9mr9979158ljh.82.1573804466324; Thu, 14 Nov 2019 23:54:26 -0800 (PST) Received: from [172.16.11.28] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id w11sm4254332lji.45.2019.11.14.23.54.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Nov 2019 23:54:25 -0800 (PST) Subject: Re: [PATCH v4 46/47] net: ethernet: freescale: make UCC_GETH explicitly depend on PPC32 To: Li Yang , Timur Tabi References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-47-linux@rasmusvillemoes.dk> From: Rasmus Villemoes Message-ID: <29b45e76-f384-fe16-0891-cc51cfecefd4@rasmusvillemoes.dk> Date: Fri, 15 Nov 2019 08:54:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191114_235428_000853_293BECF1 X-CRM114-Status: GOOD ( 14.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christophe Leroy , netdev , lkml , Scott Wood , linuxppc-dev , linux-arm-kernel , Qiang Zhao Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15/11/2019 06.44, Li Yang wrote: > On Thu, Nov 14, 2019 at 10:37 PM Timur Tabi wrote: >> >> On Fri, Nov 8, 2019 at 7:04 AM Rasmus Villemoes >> wrote: >>> >>> Currently, QUICC_ENGINE depends on PPC32, so this in itself does not >>> change anything. In order to allow removing the PPC32 dependency from >>> QUICC_ENGINE and avoid allmodconfig build failures, add this explicit >>> dependency. >> >> Can you add an explanation why we don't want ucc_geth on non-PowerPC platforms? It's not that "we" don't want to allow building this on non-PPC per se, but making it build requires some surgery that I think should be done by whoever might eventually want it. So _my_ reason for lowering this dependency from QUICC_ENGINE to UCC_GETH is exactly what it says above. > I think it is because the QE Ethernet was never integrated in any > non-PowerPC SoC and most likely will not be in the future. Well, that kind of thing is impossible to know for outsiders like me. Maybe one can amend the commit log with that info: "Also, the QE Ethernet has never been integrated on any non-PowerPC SoC and most likely will not be in the future." Rasmus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel