Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]

On 2/4/19 1:49 AM, Vladimir Sementsov-Ogievskiy wrote:

>>> +++ b/qapi/block-core.json

>>>   ##
>>> +# @Qcow2BitmapInfoFlags:
>>> +#
>>> +# An enumeration of flags that a bitmap can report to the user.
>>> +#
>>> +# @in-use: The bitmap was not saved correctly and may be inconsistent.
>>
>> I doubt the casual reader could guess the meaning from the name.  What
>> about @dirty?
> 
> I'd prefer to keep it matching Qcow2 format specification. This Info aims
> to export qcow2 specifics as is. And Qcow2 spec is not something qemu-internal,

Indeed, but we CAN reword the qcow2 spec to pick more useful names, if
the existing names there are confusing.  (The name in the spec does not
matter, so much as the layout described by the name)

> why is it worse than QQPI, and why to have different name for the same thing
> in different parts of spec?
> 
> We may instead rephrase it like
> 
> The bitmap is possibly in use by other process or was not saved correctly (and
> therefore this flag was not cleared). The data of the bitmap may be inconsistent.

s/other/another/

but that rewording works for me.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]