On 03.12.20 15:04, Theodore Y. Ts'o wrote: > On Thu, Oct 15, 2020 at 03:26:28PM +0200, Alexander Lochmann wrote: >> Hi folks, >> >> I've updated the lock documentation according to our finding for >> transaction_t. >> Does this patch look good to you? > > I updated the annotations to match with the local usage, e.g: > > * When commit was requested [journal_t.j_state_lock] > > became: > > * When commit was requested [j_state_lock]What do you mean by local usage? The annotations of other members of transaction_t? Shouldn't the annotation look like this? [t_journal->j_state_lock] It would be more precise. > > Otherwise, looks good. Thanks for the patch! Thanks! - Alex > > - Ted > -- Technische Universität Dortmund Alexander Lochmann PGP key: 0xBC3EF6FD Otto-Hahn-Str. 16 phone: +49.231.7556141 D-44227 Dortmund fax: +49.231.7556116 http://ess.cs.tu-dortmund.de/Staff/al