From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04861C28CC7 for ; Mon, 10 Jun 2019 13:36:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D52702085A for ; Mon, 10 Jun 2019 13:36:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390242AbfFJNgp (ORCPT ); Mon, 10 Jun 2019 09:36:45 -0400 Received: from mx2.suse.de ([195.135.220.15]:57150 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2390071AbfFJNgo (ORCPT ); Mon, 10 Jun 2019 09:36:44 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 38F21ADC1; Mon, 10 Jun 2019 13:36:43 +0000 (UTC) Subject: Re: [PATCH 1/7] clk: actions: Fix factor clk struct member access To: Manivannan Sadhasivam , sboyd@kernel.org Cc: ulf.hansson@linaro.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.liau@actions-semi.com, linux-actions@lists.infradead.org, linus.walleij@linaro.org, linux-clk@vger.kernel.org References: <20190608195317.6336-1-manivannan.sadhasivam@linaro.org> <20190608195317.6336-2-manivannan.sadhasivam@linaro.org> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Openpgp: preference=signencrypt Organization: SUSE Linux GmbH Message-ID: <29ef33a9-f1f1-fe10-9288-8103714d40fa@suse.de> Date: Mon, 10 Jun 2019 15:36:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190608195317.6336-2-manivannan.sadhasivam@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mani, Am 08.06.19 um 21:53 schrieb Manivannan Sadhasivam: > Since the helper "owl_factor_helper_round_rate" is shared between factor > and composite clocks, using the factor clk specific helper function > like "hw_to_owl_factor" to access its members will create issues when > called from composite clk specific code. Hence, pass the "factor_hw" > struct pointer directly instead of fetching it using factor clk specific > helpers. > > This issue has been observed when a composite clock like "sd0_clk" tried > to call "owl_factor_helper_round_rate" resulting in pointer dereferencing > error. > > Fixes: 4bb78fc9744a ("clk: actions: Add factor clock support") > Signed-off-by: Manivannan Sadhasivam > --- > drivers/clk/actions/owl-factor.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/actions/owl-factor.c b/drivers/clk/actions/owl-factor.c > index 317d4a9e112e..f419dfdd334f 100644 > --- a/drivers/clk/actions/owl-factor.c > +++ b/drivers/clk/actions/owl-factor.c > @@ -64,11 +64,10 @@ static unsigned int _get_table_val(const struct clk_factor_table *table, > return val; > } > > -static int clk_val_best(struct clk_hw *hw, unsigned long rate, > +static int clk_val_best(const struct owl_factor_hw *factor_hw, > + struct clk_hw *hw, unsigned long rate, > unsigned long *best_parent_rate) > { > - struct owl_factor *factor = hw_to_owl_factor(hw); > - struct owl_factor_hw *factor_hw = &factor->factor_hw; > const struct clk_factor_table *clkt = factor_hw->table; > unsigned long parent_rate, try_parent_rate, best = 0, cur_rate; > unsigned long parent_rate_saved = *best_parent_rate; > @@ -126,7 +125,7 @@ long owl_factor_helper_round_rate(struct owl_clk_common *common, > const struct clk_factor_table *clkt = factor_hw->table; > unsigned int val, mul = 0, div = 1; > > - val = clk_val_best(&common->hw, rate, parent_rate); > + val = clk_val_best(factor_hw, &common->hw, rate, parent_rate); > _get_table_div_mul(clkt, val, &mul, &div); > > return *parent_rate * mul / div; While at it, I think it would be a good idea to rename it to owl_clk_val_best. Pretty confusing that you're touching only owl files for a clk_ refactoring, which sounds like common clk code. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17244C28CC7 for ; Mon, 10 Jun 2019 13:36:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E04CF207E0 for ; Mon, 10 Jun 2019 13:36:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="K9S37ERF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E04CF207E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lIhd//LUBjiVO3fNjbCuI0i0umCfqoEd9EfVMUc/6uU=; b=K9S37ERF/iWpMe WgKjMEPPSEwQ63xZfDXW0HxxEKmOoJfsAUZBI8CpM1yAdTj2mTyXWdAHR/vJ9wVVSzYMsBPUu6OaT JW+1FdEv4uy7o9Jc4PyS1XgrtjaIgS9xzpMfhM8qJrRU9ViSBZWxlsgUwqPReE4Anf93vtrdmZgzM QmsWZm0uomAywxC+jqVZMFzDMcHevCa7NXljhq1YWJ8iAb7FQ4Xd5QVM4HQ2ebclS5Z/XiQy9hE2x l3aD3cAOscZaiCRP4CvVx7urqroJY+rZXzetISu/QjfmGhFpaYRiebWqd+eL/wnIUFnBkKatawAw1 qH70f99Ai57XVt4pxyLw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1haKTj-0000Tw-V2; Mon, 10 Jun 2019 13:36:51 +0000 Received: from mx2.suse.de ([195.135.220.15] helo=mx1.suse.de) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1haKTg-0000Sa-Go; Mon, 10 Jun 2019 13:36:50 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 38F21ADC1; Mon, 10 Jun 2019 13:36:43 +0000 (UTC) Subject: Re: [PATCH 1/7] clk: actions: Fix factor clk struct member access To: Manivannan Sadhasivam , sboyd@kernel.org References: <20190608195317.6336-1-manivannan.sadhasivam@linaro.org> <20190608195317.6336-2-manivannan.sadhasivam@linaro.org> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Openpgp: preference=signencrypt Organization: SUSE Linux GmbH Message-ID: <29ef33a9-f1f1-fe10-9288-8103714d40fa@suse.de> Date: Mon, 10 Jun 2019 15:36:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190608195317.6336-2-manivannan.sadhasivam@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190610_063648_709464_1D0DDE52 X-CRM114-Status: GOOD ( 18.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, ulf.hansson@linaro.org, linux-actions@lists.infradead.org, linus.walleij@linaro.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.liau@actions-semi.com, robh+dt@kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTWFuaSwKCkFtIDA4LjA2LjE5IHVtIDIxOjUzIHNjaHJpZWIgTWFuaXZhbm5hbiBTYWRoYXNp dmFtOgo+IFNpbmNlIHRoZSBoZWxwZXIgIm93bF9mYWN0b3JfaGVscGVyX3JvdW5kX3JhdGUiIGlz IHNoYXJlZCBiZXR3ZWVuIGZhY3Rvcgo+IGFuZCBjb21wb3NpdGUgY2xvY2tzLCB1c2luZyB0aGUg ZmFjdG9yIGNsayBzcGVjaWZpYyBoZWxwZXIgZnVuY3Rpb24KPiBsaWtlICJod190b19vd2xfZmFj dG9yIiB0byBhY2Nlc3MgaXRzIG1lbWJlcnMgd2lsbCBjcmVhdGUgaXNzdWVzIHdoZW4KPiBjYWxs ZWQgZnJvbSBjb21wb3NpdGUgY2xrIHNwZWNpZmljIGNvZGUuIEhlbmNlLCBwYXNzIHRoZSAiZmFj dG9yX2h3Igo+IHN0cnVjdCBwb2ludGVyIGRpcmVjdGx5IGluc3RlYWQgb2YgZmV0Y2hpbmcgaXQg dXNpbmcgZmFjdG9yIGNsayBzcGVjaWZpYwo+IGhlbHBlcnMuCj4gCj4gVGhpcyBpc3N1ZSBoYXMg YmVlbiBvYnNlcnZlZCB3aGVuIGEgY29tcG9zaXRlIGNsb2NrIGxpa2UgInNkMF9jbGsiIHRyaWVk Cj4gdG8gY2FsbCAib3dsX2ZhY3Rvcl9oZWxwZXJfcm91bmRfcmF0ZSIgcmVzdWx0aW5nIGluIHBv aW50ZXIgZGVyZWZlcmVuY2luZwo+IGVycm9yLgo+IAo+IEZpeGVzOiA0YmI3OGZjOTc0NGEgKCJj bGs6IGFjdGlvbnM6IEFkZCBmYWN0b3IgY2xvY2sgc3VwcG9ydCIpCj4gU2lnbmVkLW9mZi1ieTog TWFuaXZhbm5hbiBTYWRoYXNpdmFtIDxtYW5pdmFubmFuLnNhZGhhc2l2YW1AbGluYXJvLm9yZz4K PiAtLS0KPiAgZHJpdmVycy9jbGsvYWN0aW9ucy9vd2wtZmFjdG9yLmMgfCA3ICsrKy0tLS0KPiAg MSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9jbGsvYWN0aW9ucy9vd2wtZmFjdG9yLmMgYi9kcml2ZXJzL2Nsay9h Y3Rpb25zL293bC1mYWN0b3IuYwo+IGluZGV4IDMxN2Q0YTllMTEyZS4uZjQxOWRmZGQzMzRmIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvY2xrL2FjdGlvbnMvb3dsLWZhY3Rvci5jCj4gKysrIGIvZHJp dmVycy9jbGsvYWN0aW9ucy9vd2wtZmFjdG9yLmMKPiBAQCAtNjQsMTEgKzY0LDEwIEBAIHN0YXRp YyB1bnNpZ25lZCBpbnQgX2dldF90YWJsZV92YWwoY29uc3Qgc3RydWN0IGNsa19mYWN0b3JfdGFi bGUgKnRhYmxlLAo+ICAJcmV0dXJuIHZhbDsKPiAgfQo+ICAKPiAtc3RhdGljIGludCBjbGtfdmFs X2Jlc3Qoc3RydWN0IGNsa19odyAqaHcsIHVuc2lnbmVkIGxvbmcgcmF0ZSwKPiArc3RhdGljIGlu dCBjbGtfdmFsX2Jlc3QoY29uc3Qgc3RydWN0IG93bF9mYWN0b3JfaHcgKmZhY3Rvcl9odywKPiAr CQkJc3RydWN0IGNsa19odyAqaHcsIHVuc2lnbmVkIGxvbmcgcmF0ZSwKPiAgCQkJdW5zaWduZWQg bG9uZyAqYmVzdF9wYXJlbnRfcmF0ZSkKPiAgewo+IC0Jc3RydWN0IG93bF9mYWN0b3IgKmZhY3Rv ciA9IGh3X3RvX293bF9mYWN0b3IoaHcpOwo+IC0Jc3RydWN0IG93bF9mYWN0b3JfaHcgKmZhY3Rv cl9odyA9ICZmYWN0b3ItPmZhY3Rvcl9odzsKPiAgCWNvbnN0IHN0cnVjdCBjbGtfZmFjdG9yX3Rh YmxlICpjbGt0ID0gZmFjdG9yX2h3LT50YWJsZTsKPiAgCXVuc2lnbmVkIGxvbmcgcGFyZW50X3Jh dGUsIHRyeV9wYXJlbnRfcmF0ZSwgYmVzdCA9IDAsIGN1cl9yYXRlOwo+ICAJdW5zaWduZWQgbG9u ZyBwYXJlbnRfcmF0ZV9zYXZlZCA9ICpiZXN0X3BhcmVudF9yYXRlOwo+IEBAIC0xMjYsNyArMTI1 LDcgQEAgbG9uZyBvd2xfZmFjdG9yX2hlbHBlcl9yb3VuZF9yYXRlKHN0cnVjdCBvd2xfY2xrX2Nv bW1vbiAqY29tbW9uLAo+ICAJY29uc3Qgc3RydWN0IGNsa19mYWN0b3JfdGFibGUgKmNsa3QgPSBm YWN0b3JfaHctPnRhYmxlOwo+ICAJdW5zaWduZWQgaW50IHZhbCwgbXVsID0gMCwgZGl2ID0gMTsK PiAgCj4gLQl2YWwgPSBjbGtfdmFsX2Jlc3QoJmNvbW1vbi0+aHcsIHJhdGUsIHBhcmVudF9yYXRl KTsKPiArCXZhbCA9IGNsa192YWxfYmVzdChmYWN0b3JfaHcsICZjb21tb24tPmh3LCByYXRlLCBw YXJlbnRfcmF0ZSk7Cj4gIAlfZ2V0X3RhYmxlX2Rpdl9tdWwoY2xrdCwgdmFsLCAmbXVsLCAmZGl2 KTsKPiAgCj4gIAlyZXR1cm4gKnBhcmVudF9yYXRlICogbXVsIC8gZGl2OwoKV2hpbGUgYXQgaXQs IEkgdGhpbmsgaXQgd291bGQgYmUgYSBnb29kIGlkZWEgdG8gcmVuYW1lIGl0IHRvCm93bF9jbGtf dmFsX2Jlc3QuIFByZXR0eSBjb25mdXNpbmcgdGhhdCB5b3UncmUgdG91Y2hpbmcgb25seSBvd2wg ZmlsZXMKZm9yIGEgY2xrXyByZWZhY3RvcmluZywgd2hpY2ggc291bmRzIGxpa2UgY29tbW9uIGNs ayBjb2RlLgoKUmVnYXJkcywKQW5kcmVhcwoKLS0gClNVU0UgTGludXggR21iSCwgTWF4ZmVsZHN0 ci4gNSwgOTA0MDkgTsO8cm5iZXJnLCBHZXJtYW55CkdGOiBGZWxpeCBJbWVuZMO2cmZmZXIsIE1h cnkgSGlnZ2lucywgU3JpIFJhc2lhaApIUkIgMjEyODQgKEFHIE7DvHJuYmVyZykKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwg bWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK