From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Youn Subject: Re: [PATCH] usb: dwc2: Add extra delay when forcing dr_mode Date: Mon, 15 Feb 2016 23:10:50 +0000 Message-ID: <2B3535C5ECE8B5419E3ECBE30077290901DC4487F6@US01WEMBX2.internal.synopsys.com> References: <52b1b554810ac3a434e3c570cade28cab3dd6b1e.1454633496.git.johnyoun@synopsys.com> <24688651.GlpVaD0cKm@phil> <7C5BF428-E5A3-44A1-A294-9E8018E382AB@mniewoehner.de> Mime-Version: 1.0 Content-Type: text/plain; charset=Windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Language: en-US Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Michael Niewoehner , Heiko Stuebner , John Youn Cc: Caesar Wang , Felipe Balbi , Tao Huang , "linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Doug Anderson , "open list:ARM/Rockchip SoC..." List-Id: linux-rockchip.vger.kernel.org On 2/13/2016 1:41 PM, Michael Niewoehner wrote: > Hi John, > Hi Heiko, >=20 > on rk3188 25 ms don=92t seem to be enough also. > Increasing the sleep time to 50 ms solve the problem for me while 32 = ms seem to be the absolute minimum. >=20 > Best regards > Michael >=20 >=20 >=20 > Am 13.02.2016 um 22:13 schrieb Heiko Stuebner : >=20 >> Am Donnerstag, 4. Februar 2016, 17:50:34 schrieb John Youn: >>> Fixes an issue found on rockchip rk3036-based SOC platforms. For so= me >>> reason, the existing msleep(25) is not enough after the force mode.= The >>> following patch was reported to fix the issue. >>> >>> This does increase the probe delay again slightly, but not up to th= e >>> level it was before the original series of patches that this fixes.= It >>> does not cause any other issues when tested on Synopsys HAPS and Al= tera >>> socfpga platforms. >>> >>> Need to revisit this series next release to see if we can address t= hese >>> issues without having an unconditional delay. >>> >>> Fixes: 09c96980dc72 ("usb: dwc2: Add functions to set and clear for= ce >>> mode") Reported-by: Caesar Wang >>> Tested-by: Caesar Wang >>> Signed-off-by: John Youn >> >> Tested-by: Heiko Stuebner >> (also on a rk3036 where I hit the described problem) >> >> Ok thanks Heiko and Michael. I will update the patch and resend. John -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html