From: "Paauwe, Bob J" <bob.j.paauwe@intel.com>
To: "Roper, Matthew D" <matthew.d.roper@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/icp: Add Wa_14010685332
Date: Fri, 1 May 2020 21:51:29 +0000 [thread overview]
Message-ID: <2BC816AD90F74A48BE4D753FE4818233BC0A7CA3@fmsmsx115.amr.corp.intel.com> (raw)
In-Reply-To: <20200501213701.371443-1-matthew.d.roper@intel.com>
Reviewed by: Bob.J.Paauwe@intel.com
--
Bob Paauwe
Bob.J.Paauwe@intel.com
IOTG / Platform Software Engineering
Intel Corp. Folsom, CA
(916) 356-6193
(530) 409-0831 (cell)
> -----Original Message-----
> From: Roper, Matthew D <matthew.d.roper@intel.com>
> Sent: Friday, May 01, 2020 2:37 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Roper, Matthew D <matthew.d.roper@intel.com>; Paauwe, Bob J
> <bob.j.paauwe@intel.com>
> Subject: [PATCH] drm/i915/icp: Add Wa_14010685332
>
> We need to toggle a SDE chicken bit on and then off as the final
> step when disabling interrupts in preparation for runtime suspend.
>
> Bspec: 33450
> Bspec: 8402
> Cc: Bob Paauwe <bob.j.paauwe@intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/i915_irq.c | 8 ++++++++
> drivers/gpu/drm/i915/i915_reg.h | 1 +
> 2 files changed, 9 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c
> b/drivers/gpu/drm/i915/i915_irq.c
> index bd722d0650c8..f8202a32c112 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -2870,6 +2870,14 @@ static void gen11_display_irq_reset(struct
> drm_i915_private *dev_priv)
>
> if (INTEL_PCH_TYPE(dev_priv) >= PCH_ICP)
> GEN3_IRQ_RESET(uncore, SDE);
> +
> + /* Wa_14010685332:icl */
> + if (INTEL_PCH_TYPE(dev_priv) == PCH_ICP) {
> + intel_uncore_rmw(uncore, SOUTH_CHICKEN1,
> + SBCLK_RUN_REFCLK_DIS,
> SBCLK_RUN_REFCLK_DIS);
> + intel_uncore_rmw(uncore, SOUTH_CHICKEN1,
> + SBCLK_RUN_REFCLK_DIS, 0);
> + }
> }
>
> static void gen11_irq_reset(struct drm_i915_private *dev_priv)
> diff --git a/drivers/gpu/drm/i915/i915_reg.h
> b/drivers/gpu/drm/i915/i915_reg.h
> index fd9f2904d93c..34af899751e2 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -8573,6 +8573,7 @@ enum {
> #define FDI_BC_BIFURCATION_SELECT (1 << 12)
> #define CHASSIS_CLK_REQ_DURATION_MASK (0xf << 8)
> #define CHASSIS_CLK_REQ_DURATION(x) ((x) << 8)
> +#define SBCLK_RUN_REFCLK_DIS (1 << 7)
> #define SPT_PWM_GRANULARITY (1 << 0)
> #define SOUTH_CHICKEN2 _MMIO(0xc2004)
> #define FDI_MPHY_IOSFSB_RESET_STATUS (1 << 13)
> --
> 2.24.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-05-01 21:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 21:37 [Intel-gfx] [PATCH] drm/i915/icp: Add Wa_14010685332 Matt Roper
2020-05-01 21:51 ` Paauwe, Bob J [this message]
2020-05-01 22:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-05-01 23:32 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-05-05 21:30 ` Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2BC816AD90F74A48BE4D753FE4818233BC0A7CA3@fmsmsx115.amr.corp.intel.com \
--to=bob.j.paauwe@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.