From: "Philip Oakley" <philipoakley@iee.org>
To: "Alex Hoffman" <spec@gal.ro>
Cc: "Oleg Taranenko" <olegtaranenko@gmail.com>,
"Jakub Narębski" <jnareb@gmail.com>,
"Jacob Keller" <jacob.keller@gmail.com>,
"Johannes Sixt" <j6t@kdbg.org>,
"Christian Couder" <christian.couder@gmail.com>,
"Stephan Beyer" <s-beyer@gmx.net>, git <git@vger.kernel.org>
Subject: Re: Git bisect does not find commit introducing the bug
Date: Tue, 21 Feb 2017 22:39:58 -0000 [thread overview]
Message-ID: <2C3983FC41474DCC880C1E53149DFBE0@PhilipOakley> (raw)
In-Reply-To: CAMX8fZUR4h0T3hBmh6Z_0=f5LHFJetOi-vO_JJgnYPB7KjU_bg@mail.gmail.com
From: "Alex Hoffman" <spec@gal.ro>
>> isn't that spelt `--ancestry-path` ?
>> (--ancestry-path has it's own issues such as needing
>> an --first-parent-show
>> option, but that's possibly a by the by)
>
> Indeed it is spelled `--ancestry-path`. And interestingly enough you
> may use it multiple times with the wanted effect in our case (e.g when
> the user has multiple good commit and a single bad commit before
> running the bisect itself).
> Also it is `--first-parent` (not `--first-parent-show`),
My spelling was deliberate ;-)
If you use the currently coded --first-parent with a properly relevant
commit for --ancestry-path then you get nothing. The purpose of
ancestry-path is to find the ancestry chain that deviates from being a
first-parent traversal [1], but the first-parent want to hold the walk to
just the first parent chain - a contradiction.
Adding the -show at the end is my attempt to indicate that it is for the
second aspect, that of selecting which commits to show/use.
I had an initial discussion back at [2], but failed then too.
> but I do not understand why do we need this
> option? What kind of issues does `--ancestry-path` have?
>
> Best regards,
> VG
>
--
Philip
[1] \git\Documentation\technical\api-revision-walking.txt ["two
diff_options, one for path limiting, another for output"]
[2]
https://public-inbox.org/git/2FA1998250474E76A386B82AD635E56A@PhilipOakley/
next prev parent reply other threads:[~2017-02-21 22:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 22:29 Git bisect does not find commit introducing the bug Alex Hoffman
2017-02-17 23:21 ` Stephan Beyer
2017-02-18 9:12 ` Johannes Sixt
2017-02-18 11:15 ` Alex Hoffman
2017-02-18 14:18 ` Johannes Sixt
2017-02-18 18:36 ` Alex Hoffman
2017-02-18 19:58 ` Christian Couder
2017-02-19 11:32 ` Alex Hoffman
2017-02-19 12:43 ` Alex Hoffman
2017-02-19 13:07 ` Christian Couder
2017-02-19 14:13 ` Johannes Sixt
2017-02-19 19:05 ` Alex Hoffman
2017-02-19 19:25 ` Jacob Keller
2017-02-20 7:38 ` Oleg Taranenko
2017-02-20 12:27 ` Jakub Narębski
2017-02-20 13:50 ` Oleg Taranenko
2017-02-20 20:31 ` Alex Hoffman
2017-02-20 20:35 ` Jakub Narębski
2017-02-20 20:39 ` Alex Hoffman
2017-02-20 22:24 ` Philip Oakley
2017-02-21 19:40 ` Alex Hoffman
2017-02-21 22:39 ` Philip Oakley [this message]
2017-02-20 9:02 ` Junio C Hamano
2017-02-18 22:10 ` Philip Oakley
2017-02-18 22:36 ` Hilco Wijbenga
2017-02-18 22:37 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2C3983FC41474DCC880C1E53149DFBE0@PhilipOakley \
--to=philipoakley@iee.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=jacob.keller@gmail.com \
--cc=jnareb@gmail.com \
--cc=olegtaranenko@gmail.com \
--cc=s-beyer@gmx.net \
--cc=spec@gal.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.